Re: [PATCH v2 1/7] drm/msm: dpu: Remove impossible checks

[Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>]

On Thu, Sep 13, 2018 at 03:23:47PM -0700, Jeykumar Sankaran wrote:
> On 2018-09-12 06:54, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> > 
> > This patch removes some checks which are impossible to hit. As a result,
> > we can move some of the local var assignments into the declarations.
> > 
> > Changes in v2:
> > - None
> > 
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> 
> Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>

Thanks for the reviews! I've pushed the whole stack to dpu-staging

Sean

> 
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 +------------------
> >  1 file changed, 1 insertion(+), 18 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > index 46de0de466ff..0f428f66b951 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > @@ -1080,30 +1080,13 @@ static int dpu_plane_sspp_atomic_check(struct
> > drm_plane *plane,
> >  		struct drm_plane_state *state)
> >  {
> >  	int ret = 0;
> > -	struct dpu_plane *pdpu;
> > -	struct dpu_plane_state *pstate;
> > +	struct dpu_plane *pdpu = to_dpu_plane(plane);
> >  	const struct dpu_format *fmt;
> >  	struct drm_rect src, dst, fb_rect = { 0 };
> >  	uint32_t max_upscale = 1, max_downscale = 1;
> >  	uint32_t min_src_size, max_linewidth;
> >  	int hscale = 1, vscale = 1;
> > 
> > -	if (!plane || !state) {
> > -		DPU_ERROR("invalid arg(s), plane %d state %d\n",
> > -				plane != 0, state != 0);
> > -		ret = -EINVAL;
> > -		goto exit;
> > -	}
> > -
> > -	pdpu = to_dpu_plane(plane);
> > -	pstate = to_dpu_plane_state(state);
> > -
> > -	if (!pdpu->pipe_sblk) {
> > -		DPU_ERROR_PLANE(pdpu, "invalid catalog\n");
> > -		ret = -EINVAL;
> > -		goto exit;
> > -	}
> > -
> >  	src.x1 = state->src_x >> 16;
> >  	src.y1 = state->src_y >> 16;
> >  	src.x2 = src.x1 + (state->src_w >> 16);
> 
> -- 
> Jeykumar S
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno