From mboxrd@z Thu Jan 1 00:00:00 1970 From: sam@ravnborg.org (Sam Ravnborg) Date: Mon, 17 Sep 2018 21:37:48 +0200 Subject: [RESEND 4/5] drm/mxsfb: Add PM_SLEEP support In-Reply-To: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> References: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> Message-ID: <20180917193748.GA13165@ravnborg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Leonard. On Mon, Aug 27, 2018 at 02:10:40PM +0300, Leonard Crestez wrote: > Since power to the lcdif block can be lost on suspend implement > PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore > the current mode. > > Signed-off-by: Leonard Crestez > Reviewed-by: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 68d79f5dc0d3..d797dfd40d98 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -416,17 +416,38 @@ static int mxsfb_remove(struct platform_device *pdev) > drm_dev_unref(drm); > > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int mxsfb_suspend(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + > + return drm_mode_config_helper_suspend(drm); > +} > + > +static int mxsfb_resume(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + > + return drm_mode_config_helper_resume(drm); > +} > +#endif Other suspend/resume users skip the #ifdef and declare the functions __maybe_unused See for example arm/hdlcd_drv.c. The resulting code is a bit simpler to read and you have the added benefit that the suspend/resume functions are always compiled so bit-rotting is less likely. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [RESEND 4/5] drm/mxsfb: Add PM_SLEEP support Date: Mon, 17 Sep 2018 21:37:48 +0200 Message-ID: <20180917193748.GA13165@ravnborg.org> References: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70E636E33C for ; Mon, 17 Sep 2018 19:37:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Leonard Crestez Cc: Marek Vasut , Dong Aisheng , kernel@pengutronix.de, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabio Estevam , linux-imx@nxp.com, Robert Chiras , Marco Franchi , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGkgTGVvbmFyZC4KCk9uIE1vbiwgQXVnIDI3LCAyMDE4IGF0IDAyOjEwOjQwUE0gKzAzMDAsIExl b25hcmQgQ3Jlc3RleiB3cm90ZToKPiBTaW5jZSBwb3dlciB0byB0aGUgbGNkaWYgYmxvY2sgY2Fu IGJlIGxvc3Qgb24gc3VzcGVuZCBpbXBsZW1lbnQKPiBQTV9TTEVFUF9PUFMgdXNpbmcgZHJtX21v ZGVfY29uZmlnX2hlbHBlcl9zdXNwZW5kL3Jlc3VtZSB0byBzYXZlL3Jlc3RvcmUKPiB0aGUgY3Vy cmVudCBtb2RlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IExlb25hcmQgQ3Jlc3RleiA8bGVvbmFyZC5j cmVzdGV6QG54cC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbiBBZ25lciA8c3RlZmFuQGFnbmVy LmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXhzZmIvbXhzZmJfZHJ2LmMgfCAyMSArKysr KysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKykKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2Rydi5jIGIvZHJpdmVy cy9ncHUvZHJtL214c2ZiL214c2ZiX2Rydi5jCj4gaW5kZXggNjhkNzlmNWRjMGQzLi5kNzk3ZGZk NDBkOTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2Rydi5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2Rydi5jCj4gQEAgLTQxNiwxNyArNDE2 LDM4IEBAIHN0YXRpYyBpbnQgbXhzZmJfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAlkcm1fZGV2X3VucmVmKGRybSk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4g KyNpZmRlZiBDT05GSUdfUE1fU0xFRVAKPiArc3RhdGljIGludCBteHNmYl9zdXNwZW5kKHN0cnVj dCBkZXZpY2UgKmRldikKPiArewo+ICsgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IGRl dl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsKPiArICAgICAgIHJldHVybiBkcm1fbW9kZV9jb25maWdf aGVscGVyX3N1c3BlbmQoZHJtKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBteHNmYl9yZXN1bWUo c3RydWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJt ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ICsgICAgICAgcmV0dXJuIGRybV9tb2RlX2Nv bmZpZ19oZWxwZXJfcmVzdW1lKGRybSk7Cj4gK30KPiArI2VuZGlmCgpPdGhlciBzdXNwZW5kL3Jl c3VtZSB1c2VycyBza2lwIHRoZSAjaWZkZWYgYW5kIGRlY2xhcmUKdGhlIGZ1bmN0aW9ucyBfX21h eWJlX3VudXNlZApTZWUgZm9yIGV4YW1wbGUgYXJtL2hkbGNkX2Rydi5jLgoKVGhlIHJlc3VsdGlu ZyBjb2RlIGlzIGEgYml0IHNpbXBsZXIgdG8gcmVhZCBhbmQgeW91CmhhdmUgdGhlIGFkZGVkIGJl bmVmaXQgdGhhdCB0aGUgc3VzcGVuZC9yZXN1bWUgZnVuY3Rpb25zCmFyZSBhbHdheXMgY29tcGls ZWQgc28gYml0LXJvdHRpbmcgaXMgbGVzcyBsaWtlbHkuCgoJU2FtCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8680DECE560 for ; Mon, 17 Sep 2018 19:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 342E2214D5 for ; Mon, 17 Sep 2018 19:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 342E2214D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728265AbeIRBGk (ORCPT ); Mon, 17 Sep 2018 21:06:40 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:41673 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbeIRBGj (ORCPT ); Mon, 17 Sep 2018 21:06:39 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1487520029; Mon, 17 Sep 2018 21:37:49 +0200 (CEST) Date: Mon, 17 Sep 2018 21:37:48 +0200 From: Sam Ravnborg To: Leonard Crestez Cc: Marek Vasut , Philipp Zabel , Dong Aisheng , David Airlie , linux-kernel@vger.kernel.org, Robert Chiras , dri-devel@lists.freedesktop.org, kernel@pengutronix.de, Fabio Estevam , Marco Franchi , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [RESEND 4/5] drm/mxsfb: Add PM_SLEEP support Message-ID: <20180917193748.GA13165@ravnborg.org> References: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d661819825a36f4aebe412e7bed8fe24c7292ae.1535367027.git.leonard.crestez@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=8AirrxEcAAAA:8 a=or3rrLwTOfPTjjqw9IcA:9 a=CjuIK1q_8ugA:10 a=ST-jHhOKWsTCqRlWije3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leonard. On Mon, Aug 27, 2018 at 02:10:40PM +0300, Leonard Crestez wrote: > Since power to the lcdif block can be lost on suspend implement > PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore > the current mode. > > Signed-off-by: Leonard Crestez > Reviewed-by: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 68d79f5dc0d3..d797dfd40d98 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -416,17 +416,38 @@ static int mxsfb_remove(struct platform_device *pdev) > drm_dev_unref(drm); > > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int mxsfb_suspend(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + > + return drm_mode_config_helper_suspend(drm); > +} > + > +static int mxsfb_resume(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + > + return drm_mode_config_helper_resume(drm); > +} > +#endif Other suspend/resume users skip the #ifdef and declare the functions __maybe_unused See for example arm/hdlcd_drv.c. The resulting code is a bit simpler to read and you have the added benefit that the suspend/resume functions are always compiled so bit-rotting is less likely. Sam