From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
arnd@arndb.de, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Eli Friedman <efriedma@codeaurora.org>,
Christopher Li <sparse@chrisli.org>,
Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Joe Perches <joe@perches.com>,
Dominique Martinet <asmadeus@codewreck.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] Compiler Attributes: naked can be shared
Date: Tue, 18 Sep 2018 09:30:05 +0200 [thread overview]
Message-ID: <20180918073005.GA4067@kroah.com> (raw)
In-Reply-To: <40a059bad54389ff2a9ddc26b9d99a4b@agner.ch>
On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote:
> On 13.09.2018 16:59, Miguel Ojeda wrote:
> > The naked attribute is supported by at least gcc >= 4.6 (for ARM,
> > which is the only current user), gcc >= 8 (for x86), clang >= 3.1
> > and icc >= 13. See https://godbolt.org/z/350Dyc
> >
> > Therefore, move it out of compiler-gcc.h so that the definition
> > is shared by all compilers.
> >
> > This also fixes Clang support for ARM32 --- 815f0ddb346c
> > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive").
> >
> > Cc: Stefan Agner <stefan@agner.ch>
> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > Cc: Eli Friedman <efriedma@codeaurora.org>
> > Cc: Christopher Li <sparse@chrisli.org>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Cc: Joe Perches <joe@perches.com>
> > Cc: Dominique Martinet <asmadeus@codewreck.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: linux-sparse@vger.kernel.org
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
> Reviewed-by: Stefan Agner <stefan@agner.ch>
>
> Ideally this two patches should go into v4.19. Not sure which path the patch should take, MAINTAINERS is not quite clear about that. This fixes 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") for ARM32, which has been merged directly by
> Linus, afaict...
Good point, can you resend these to me with all of the acks added so
far?
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-18 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 23:59 [PATCH 0/2] Compiler Attributes (naked only, for v4.19) Miguel Ojeda
2018-09-13 23:59 ` [PATCH 1/2] Compiler Attributes: naked was fixed in gcc 4.6 Miguel Ojeda
2018-09-18 3:12 ` Stefan Agner
2018-09-13 23:59 ` [PATCH 2/2] Compiler Attributes: naked can be shared Miguel Ojeda
2018-09-18 3:19 ` Stefan Agner
2018-09-18 7:30 ` Greg Kroah-Hartman [this message]
2018-09-18 16:06 ` Miguel Ojeda
2018-09-18 16:17 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918073005.GA4067@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=asmadeus@codewreck.org \
--cc=efriedma@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=sparse@chrisli.org \
--cc=stefan@agner.ch \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.