From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF711ECE565 for ; Tue, 18 Sep 2018 08:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84C0120645 for ; Tue, 18 Sep 2018 08:55:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84C0120645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729361AbeIRO1Q (ORCPT ); Tue, 18 Sep 2018 10:27:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36418 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726759AbeIRO1Q (ORCPT ); Tue, 18 Sep 2018 10:27:16 -0400 Received: from localhost (unknown [147.67.4.98]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D95E5D0A; Tue, 18 Sep 2018 08:55:37 +0000 (UTC) Date: Tue, 18 Sep 2018 10:55:34 +0200 From: Greg KH To: zhong jiang Cc: tomas.winkler@intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: remove redundant include moduleparam.h Message-ID: <20180918085534.GA3374@kroah.com> References: <1537259682-44758-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537259682-44758-1-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote: > module.h already contains moduleparam.h, so it is safe to remove > the redundant include. > > The issue is detected with the help of Coccinelle. > > eePlease enter the commit message for your changes. Lines starting Odd line to have in a changelog text :) Please fix up and resend. tanks, greg k-h