From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Tomislav Požega" <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/5] rt2x00: rework channel config function
Date: Tue, 18 Sep 2018 14:22:37 +0200 [thread overview]
Message-ID: <20180918122237.GC15481@redhat.com> (raw)
In-Reply-To: <1537201975-3032-2-git-send-email-pozega.tomislav@gmail.com>
On Mon, Sep 17, 2018 at 06:32:52PM +0200, Tomislav Požega wrote:
> - switch (rt2x00dev->default_ant.tx_chain_num) {
> - case 3:
> - /* Turn on tertiary PAs */
> - rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A2_EN,
> - rf->channel > 14);
> - rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_G2_EN,
> - rf->channel <= 14);
> - /* fall-through */
> - case 2:
> - /* Turn on secondary PAs */
> - rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A1_EN,
> - rf->channel > 14);
> - rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_G1_EN,
> - rf->channel <= 14);
> - /* fall-through */
> - case 1:
> - /* Turn on primary PAs */
> - rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A0_EN,
> - rf->channel > 14);
> - if (rt2x00_has_cap_bt_coexist(rt2x00dev))
> + if (rt2x00dev->curr_band == NL80211_BAND_5GHZ) {
> + switch (rt2x00dev->default_ant.tx_chain_num) {
> + case 3:
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A2_EN, 1);
> + case 2:
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A1_EN, 1);
> + case 1:
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A0_EN, 1);
> + break;
Please keep /* fall-through */ comments, this is needed
for some automatic code checkers tools.
next prev parent reply other threads:[~2018-09-18 17:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 16:32 [PATCH 1/5] rt2x00: set registers based on current band Tomislav Požega
2018-09-17 16:32 ` [PATCH 2/5] rt2x00: rework channel config function Tomislav Požega
2018-09-18 12:22 ` Stanislaw Gruszka [this message]
2018-10-09 10:57 ` Stanislaw Gruszka
2018-09-17 16:32 ` [PATCH 3/5] rt2x00: remove unneeded check Tomislav Požega
2018-09-17 16:32 ` [PATCH 4/5] rt2x00: remove confusing AGC register Tomislav Požega
2018-09-17 16:32 ` [PATCH 5/5] rt2x00: update TX_SW_CFG2 value Tomislav Požega
2018-09-18 12:20 ` [PATCH 1/5] rt2x00: set registers based on current band Stanislaw Gruszka
2018-09-18 14:14 ` Tomislav Požega
2018-09-19 11:05 ` Stanislaw Gruszka
2018-09-19 12:17 ` Tomislav Požega
2018-09-19 12:47 ` Stanislaw Gruszka
2018-09-19 13:04 ` Stanislaw Gruszka
2018-09-29 9:26 ` Tom Psyborg
2018-10-09 11:00 ` Stanislaw Gruszka
2018-10-09 22:14 ` Tom Psyborg
2018-10-10 8:49 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918122237.GC15481@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.