From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v8 2/2] drm/i915: Allow "max bpc" property
 to limit pipe_bpp
Date: Tue, 18 Sep 2018 21:50:19 +0300
Message-ID: <20180918185019.GY5565@intel.com>
References: <20180918181115.3388-1-radhakrishna.sripada@intel.com>
 <20180918181115.3388-2-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180918181115.3388-2-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Kishore Kadiyala <kishore.kadiyala@intel.com>, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBTZXAgMTgsIDIwMTggYXQgMTE6MTE6MTVBTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gVXNlIHRoZSBuZXdseSBhZGRlZCAibWF4IGJwYyIgY29ubmVjdG9yIHBy
b3BlcnR5IHRvIGxpbWl0IHBpcGUgYnBwLgo+IAo+IFYzOiBVc2UgZHJtX2Nvbm5lY3Rvcl9zdGF0
ZSB0byBhY2Nlc3MgdGhlICJtYXggYnBjIiBwcm9wZXJ0eQo+IFY0OiBJbml0aWFsaXplIHRoZSBk
cm0gcHJvcGVydHksIGFkZCBzdXVwb3J0IHRvIERQKFZpbGxlKQo+IFY1OiBVc2UgdGhlIHByb3Bl
cnR5IGluIHRoZSBjb25uZWN0b3IgYW5kIGZpeCBDSSBmYWlsdXJlKFZpbGxlKQo+IFY2OiBVc2Ug
dGhlIGNvcmUgZnVuY3Rpb24gdG8gYXR0YWNoIG1heF9icGMgcHJvcGVydHksIHJlbW92ZSB0aGUg
cmVkdW5kYW50Cj4gICAgIGNsYW1waW5nIG9mIHBpcGUgYnBwIGJhc2VkIG9uIGNvbm5lY3RvciBp
bmZvCj4gVjc6IEZpeCBDaGVja3BhdGNoIHdhcm5pbmdzCj4gCj4gQ2M6IFZpbGxlIFN5cmrDpGzD
pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh
bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu
dGVsLmNvbT4KPiBDYzogS2lzaG9yZSBLYWRpeWFsYSA8a2lzaG9yZS5rYWRpeWFsYUBpbnRlbC5j
b20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gQ2M6
IFN0YW5pc2xhdiBMaXNvdnNraXkgPHN0YW5pc2xhdi5saXNvdnNraXlAaW50ZWwuY29tPgo+IFNp
Z25lZC1vZmYtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWtyaXNobmEuc3JpcGFkYUBp
bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8
IDQ5ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCAgNSArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2hkbWkuYyAgICB8ICA1ICsrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRp
b25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh
eS5jCj4gaW5kZXggZWIyNTAzN2Q3YjM4Li43NWFmZDUzNTkwYjEgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEwODQ1LDI5ICsxMDg0NSwzNyBAQCBzdGF0aWMg
dm9pZCBpbnRlbF9tb2Rlc2V0X3VwZGF0ZV9jb25uZWN0b3JfYXRvbWljX3N0YXRlKHN0cnVjdCBk
cm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkCj4gLWNvbm5lY3RlZF9zaW5r
X2NvbXB1dGVfYnBwKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAtCQkJICAg
c3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ICtjb25uZWN0ZWRfc2lua19t
YXhfYnBwKHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlLAo+ICsJCSAgICAg
ICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gIHsKPiAtCWNvbnN0IHN0
cnVjdCBkcm1fZGlzcGxheV9pbmZvICppbmZvID0gJmNvbm5lY3Rvci0+YmFzZS5kaXNwbGF5X2lu
Zm87Cj4gLQlpbnQgYnBwID0gcGlwZV9jb25maWctPnBpcGVfYnBwOwo+IC0KPiAtCURSTV9ERUJV
R19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIGNoZWNraW5nIGZvciBzaW5rIGJwcCBjb25zdHJhaW5z
XG4iLAo+IC0JCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5iYXNlLmlkLAo+IC0JCSAgICAgIGNvbm5l
Y3Rvci0+YmFzZS5uYW1lKTsKPiAtCj4gLQkvKiBEb24ndCB1c2UgYW4gaW52YWxpZCBFRElEIGJw
YyB2YWx1ZSAqLwo+IC0JaWYgKGluZm8tPmJwYyAhPSAwICYmIGluZm8tPmJwYyAqIDMgPCBicHAp
IHsKPiAtCQlEUk1fREVCVUdfS01TKCJjbGFtcGluZyBkaXNwbGF5IGJwcCAod2FzICVkKSB0byBF
RElEIHJlcG9ydGVkIG1heCBvZiAlZFxuIiwKPiAtCQkJICAgICAgYnBwLCBpbmZvLT5icGMgKiAz
KTsKPiAtCQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSBpbmZvLT5icGMgKiAzOwo+ICsJaWYgKHBp
cGVfY29uZmlnLT5waXBlX2JwcCA8IGNvbm5fc3RhdGUtPm1heF9icGMgKiAzKSB7Cj4gKwkJY29u
bl9zdGF0ZS0+bWF4X2JwYyA9IHBpcGVfY29uZmlnLT5waXBlX2JwcCAvIDM7Cj4gKwkJcmV0dXJu
OwoKVGhpcyBiYWNrIGFuZCBmb3J0aCBiZXR3ZWVuIG1heF9icGMgYW5kIHBpcGVfYnBwIGlzIGEg
Yml0IGNvbmZ1c2luZy4KSSdkIHByb2JhYmx5IGxlYXZlIG1heF9icGMgYWxvbmUgaGVyZSBhbmQg
anVzdCB1cGRhdGUgcGlwZV9icHAgYXMKbmVlZGVkLgoKPiAgCX0KPiAgCj4gLQkvKiBDbGFtcCBi
cHAgdG8gOCBvbiBzY3JlZW5zIHdpdGhvdXQgRURJRCAxLjQgKi8KPiAtCWlmIChpbmZvLT5icGMg
PT0gMCAmJiBicHAgPiAyNCkgewo+IC0JCURSTV9ERUJVR19LTVMoImNsYW1waW5nIGRpc3BsYXkg
YnBwICh3YXMgJWQpIHRvIGRlZmF1bHQgbGltaXQgb2YgMjRcbiIsCj4gLQkJCSAgICAgIGJwcCk7
Cj4gLQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMjQ7Cj4gKwlzd2l0Y2ggKGNvbm5fc3RhdGUt
Pm1heF9icGMpIHsKClRoaXMgaXMgbWlzc2luZyB0aGUgNmJwYyBjYXNlIGF0IGxlYXN0LiBJIHN1
cHBvc2UgdGhlIGN1cnJlbnQgY29kZQppc24ndCBwYXJ0aWN1cmFseSByb2J1c3QgYWdhaW5zdCB1
bmV4cGVjdGVkIHZhbHVlcyBjb21pbmcgdmlhCmluZm8tPmJwYy4gVGhlIHN3aXRjaCBzdGF0ZW1l
bnQgZG9lcyBzZWVtIGFuIGltcHJvdmVtZW50IGluIHRoYXQKcmVnYXJkLiBUaG91Z2ggd291bGQg
YmUgbmljZSB0byBjb21wYWN0IGl0IGEgYml0IHVzaW5nIGVnLiB0aGUgZ2NjIApjYXNlIHJhbmdl
IGV4dGVuc2lvbi4KCj4gKwljYXNlIDg6Cj4gKwljYXNlIDk6Cj4gKwkJcGlwZV9jb25maWctPnBp
cGVfYnBwID0gOCAqIDM7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDEwOgo+ICsJY2FzZSAxMToKPiAr
CQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSAxMCAqIDM7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDEy
Ogo+ICsJY2FzZSAxMzoKPiArCWNhc2UgMTQ6Cj4gKwljYXNlIDE1OgoKV2l0aCB0aGUgcHJvcG9z
ZWQgbWluKCkgd2UnZCBuZXZlciBnZXQgYnBjID4gMTIgaGVyZS4KCj4gKwkJcGlwZV9jb25maWct
PnBpcGVfYnBwID0gMTIgKiAzOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAxNjoKPiArCQlwaXBlX2Nv
bmZpZy0+cGlwZV9icHAgPSAxNiAqIDM7Cj4gKwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCWJy
ZWFrOwoKTWF5YmUganVzdCByZXR1cm4gYW4gZXJyb3IgaGVyZS4gSSBzdXBwb3NlIGl0IHNob3Vs
ZCBuZXZlciBoYXBwZW4gdW5sZXNzCnRoZXJlJ3Mgc29tZSBib2d1cyBkaXNwbGF5cyBvdXQgdGhl
cmUgdGhhdCByZXBvcnQgPCA2IGJwYy4KCj4gIAl9Cj4gKwo+ICsJRFJNX0RFQlVHX0tNUygiTGlt
aXRpbmcgZGlzcGxheSBicHAgdG8gJWRcbiIsIHBpcGVfY29uZmlnLT5waXBlX2JwcCk7CgpXb3Vs
ZCBiZSBuaWNlIHRvIGluY2x1ZGUgYWxsIHRoZSByZWxldmFudCBpbmZvcm1hdGlvbiBpbiB0aGlz
IGRlYnVnCnByaW50OiBvcmlnaW5hbCBwaXBlX2JwcCwgaW5mby0+YnBjKjMsIG1heF9yZXF1ZXN0
ZWRfYnBjLgoKTWF5YmUgc29tZXRoaW5nIGxpa2UgdGhpcyB3b3VsZCB3b3JrIHRvIGtlZXAgdGhl
IGNvZGUgZWFzeSB0byByZWFkOgp7CglicHAgPSBtaW4ocGlwZV9icHAsIG1heF9icGMqMyk7CgoJ
c3dpdGNoIChicHApIHsKCS4uLgoJfQoKCWlmIChicHAgIT0gcGlwZV9icHApIHsKCQlEUk1fREVC
VUdfS01TKC4uLik7CgkJcGlwZV9icHAgPSBicHA7Cgl9Cn0KCj4gIH0KPiAgCj4gIHN0YXRpYyBp
bnQKPiBAQCAtMTA4OTgsOCArMTA5MDYsNyBAQCBjb21wdXRlX2Jhc2VsaW5lX3BpcGVfYnBwKHN0
cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCWlmIChjb25uZWN0b3Jfc3RhdGUtPmNydGMgIT0g
JmNydGMtPmJhc2UpCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAtCQljb25uZWN0ZWRfc2lua19jb21w
dXRlX2JwcCh0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjdG9yKSwKPiAtCQkJCQkgICBwaXBlX2Nv
bmZpZyk7Cj4gKwkJY29ubmVjdGVkX3NpbmtfbWF4X2JwcChjb25uZWN0b3Jfc3RhdGUsIHBpcGVf
Y29uZmlnKTsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gYnBwOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu
Ywo+IGluZGV4IDQzNmMyMmRlMzNiNi4uYWVmY2ExZDllODdiIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcC5jCj4gQEAgLTU3MTksNiArNTcxOSwxMSBAQCBpbnRlbF9kcF9hZGRfcHJvcGVydGll
cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj
dAo+ICAJCWludGVsX2F0dGFjaF9mb3JjZV9hdWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+ICAK
PiAgCWludGVsX2F0dGFjaF9icm9hZGNhc3RfcmdiX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gKwlp
ZiAoKElTX0c0WChkZXZfcHJpdikgfHwgSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwKPiArCSAg
ICAgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpKQoKSnVzdCBIQVNfR01DSF9ESVNQTEFZKCkgd2ls
bCBkbyBoZXJlLgoKPiArCQlkcm1fY29ubmVjdG9yX2F0dGFjaF9tYXhfYnBjX3Byb3BlcnR5KGNv
bm5lY3RvciwgOCwgMTApOwo+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA1KQo+
ICsJCWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9icGNfcHJvcGVydHkoY29ubmVjdG9yLCA4LCAx
Mik7CgpEUCBkb2VzIHN1cHBvcnQgNiBicGMgYXMgd2VsbCwgc28gd2UgbWF5IHdhbnQgdG8gcmVk
dWNlIHRoZSBtaW4gdG8gNgpoZXJlLgoKPiAgCj4gIAlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVs
X2RwKSkgewo+ICAJCXUzMiBhbGxvd2VkX3NjYWxlcnM7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hk
bWkuYwo+IGluZGV4IGEyZGFiMGI2YmRlNi4uMmI0MzJjN2U0ZjhhIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2hkbWkuYwo+IEBAIC0yMTA5LDExICsyMTA5LDE2IEBAIHN0YXRpYyBjb25zdCBz
dHJ1Y3QgZHJtX2VuY29kZXJfZnVuY3MgaW50ZWxfaGRtaV9lbmNfZnVuY3MgPSB7Cj4gIHN0YXRp
YyB2b2lkCj4gIGludGVsX2hkbWlfYWRkX3Byb3BlcnRpZXMoc3RydWN0IGludGVsX2hkbWkgKmlu
dGVsX2hkbWksIHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIHsKPiArCXN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5kZXYpOwo+
ICsKPiAgCWludGVsX2F0dGFjaF9mb3JjZV9hdWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+ICAJ
aW50ZWxfYXR0YWNoX2Jyb2FkY2FzdF9yZ2JfcHJvcGVydHkoY29ubmVjdG9yKTsKPiAgCWludGVs
X2F0dGFjaF9hc3BlY3RfcmF0aW9fcHJvcGVydHkoY29ubmVjdG9yKTsKPiAgCWRybV9jb25uZWN0
b3JfYXR0YWNoX2NvbnRlbnRfdHlwZV9wcm9wZXJ0eShjb25uZWN0b3IpOwo+ICAJY29ubmVjdG9y
LT5zdGF0ZS0+cGljdHVyZV9hc3BlY3RfcmF0aW8gPSBIRE1JX1BJQ1RVUkVfQVNQRUNUX05PTkU7
Cj4gKwo+ICsJaWYgKCFIQVNfR01DSF9ESVNQTEFZKGRldl9wcml2KSkKPiArCQlkcm1fY29ubmVj
dG9yX2F0dGFjaF9tYXhfYnBjX3Byb3BlcnR5KGNvbm5lY3RvciwgOCwgMTIpOwo+ICB9Cj4gIAo+
ICAvKgo+IC0tIAo+IDIuOS4zCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp
c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=