From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v3 1/6] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake Date: Tue, 18 Sep 2018 13:07:42 -0700 Message-ID: <20180918200742.GR2674@intel.com> References: <20180918181015.11001-1-jose.souza@intel.com> <20180918190412.GA5565@intel.com> <1ba16a30f000180c6d0c035dff989085998a4285.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F67889D7B for ; Tue, 18 Sep 2018 20:07:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1ba16a30f000180c6d0c035dff989085998a4285.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTgsIDIwMTggYXQgMTI6NDA6MjFQTSAtMDcwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gT24gVHVlLCAyMDE4LTA5LTE4IGF0IDIyOjA0ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qg d3JvdGU6Cj4gPiBPbiBUdWUsIFNlcCAxOCwgMjAxOCBhdCAxMToxMDoxMEFNIC0wNzAwLCBKb3PD qSBSb2JlcnRvIGRlIFNvdXphCj4gPiB3cm90ZToKPiA+ID4gSW5zdGVhZCBvZiBoYXZlIHRoZSBz YW1lIGNvZGUgc3ByZWFkIGludG8gNCBwbGF0Zm9ybXMgbGV0cyBzaGFyZQo+ID4gPiBpdC4KPiA+ ID4gQlhUIGRvIG5vdCBoYXZlIGEgUENIIHNvIGhlcmUgYWxzbyBoYW5kbGluZyB0aGlzIGNhc2Ug YnkgdW5zZXRpbmcKPiA+ID4gUkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEUuCj4gPiA+IAo+ID4g PiB2MihSb2RyaWdvKToKPiA+ID4gLSByZW5hbWVkIHRvIGludGVsX3BjaF9yZXNldF9oYW5kc2hh a2UoKQo+ID4gPiAtIGFkZGVkIGNvbW1lbnQgYWJvdXQgd2h5IEJYVCBuZWVkIHRoZSBiaXQgdG8g YmUgdW5zZXQKPiA+ID4gCj4gPiA+IHYzKFJvZHJpZ28gYW5kIFZpbGxlKToKPiA+ID4gLSBhZGRl ZCBib29sIGhhdmVfcGNoIHRvIGludGVsX3BjaF9yZXNldF9oYW5kc2hha2UoKQo+ID4gPiAtIGFk ZGVkIGJhY2sgQlhUIGNvbW1lbnQKPiA+ID4gCj4gPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRvIGRl IFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAzMCArKysrKysrKysrKysrKy0tLS0tLS0K PiA+ID4gLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEzIGRl bGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1 bnRpbWVfcG0uYwo+ID4gPiBpbmRleCA5YmViZWMzODlkZTEuLjRlMDUwZGMzZWJkZSAxMDA2NDQK PiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gPiBAQCAt MzIzOSwxOCArMzIzOSwyOSBAQCBzdGF0aWMgdm9pZCBpY2xfbWJ1c19pbml0KHN0cnVjdAo+ID4g PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gIAlJOTE1X1dSSVRFKE1CVVNfQUJP WF9DVEwsIHZhbCk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyB2b2lkIGludGVsX3Bj aF9yZXNldF9oYW5kc2hha2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ID4gKmRldl9wcml2 LAo+ID4gPiArCQkJCSAgICAgIGJvb2wgaGF2ZV9wY2gpCj4gPiAKPiA+IFlvdSBzZWVtIHZlcnkg aW50ZW50IG9uIG1vdmluZyB0aGUgSEFTX1BDSF9OT1AoKSBpbnRvIHRoaXMgZnVuY3Rpb24uCj4g PiBJIHN0aWxsIGRvbid0IGxpa2UgdGhhdCBhcHByb2FjaC4gSSB0aGluayBpdCdzIGNsZWFybmVy IHRvIGxldCB0aGUKPiA+IGNhbGxlciAxMDAlIGRlY2lkZSB3aGV0aGVyIHRvIGVuYWJsZSBvciBk aXNhYmxlIHRoZSByZXNldCBoYW5kc2hha2UuCj4gCj4gQmVjYXVzZSBpdCB3b3VsZCBqdXN0IG1v dmUgSEFTX1BDSF9OT1AoKSB0byBhbGwgdGhlIGNhbGxlcnMgZXhwZWN0IGZvcgo+IEJYVCwgYWxz byB3ZSBhcmUgZG9pbmcgdGhlIHNhbWUgdGhpbmcgcmlnaHQgbm93IGJ1dCBpbiBhIHdyb25nIHBs YWNlLgo+IEJ1dCBpZiB5b3UgYW5kIFJvZHJpZ28gcmVhbGx5IHdhbnRzIGl0LCBJIGNhbiBjaGFu Z2UgdGhhdC4KCjopCgpUaGFua3MgZm9yIGNoYW5naW5nIHRvIHRoZSBib29sIGFwcHJvYWNoIGFs cmVhZHkuCgpDaGVja2luZyB0aGUgb3RoZXIgcGF0Y2ggSSBhZ3JlZSB3aXRoIHZpbGxlIHRoYXQg bGVhdmluZyB0aGUgZW5hYmxlL2Rpc2FibGUKZGVjaXNpb24gb3V0c2lkZSBpcyBiZXR0ZXIuCgo+ IAo+IAo+ID4gCj4gPiA+ICt7Cj4gPiA+ICsJdTMyIHZhbCA9IEk5MTVfUkVBRChIU1dfTkRFX1JT VFdSTl9PUFQpOwo+ID4gPiArCj4gPiA+ICsJaWYgKGhhdmVfcGNoKQo+ID4gPiArCQl2YWwgfD0g UkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEU7Cj4gPiA+ICsJZWxzZQo+ID4gPiArCQl2YWwgJj0g flJFU0VUX1BDSF9IQU5EU0hBS0VfRU5BQkxFOwo+ID4gPiArCj4gPiA+ICsJSTkxNV9XUklURShI U1dfTkRFX1JTVFdSTl9PUFQsIHZhbCk7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyB2 b2lkIHNrbF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ID4gPiAq ZGV2X3ByaXYsCj4gPiA+ICAJCQkJICAgYm9vbCByZXN1bWUpCj4gPiA+ICB7Cj4gPiA+ICAJc3Ry dWN0IGk5MTVfcG93ZXJfZG9tYWlucyAqcG93ZXJfZG9tYWlucyA9ICZkZXZfcHJpdi0KPiA+ID4g PnBvd2VyX2RvbWFpbnM7Cj4gPiA+ICAJc3RydWN0IGk5MTVfcG93ZXJfd2VsbCAqd2VsbDsKPiA+ ID4gLQl1aW50MzJfdCB2YWw7Cj4gPiA+ICAKPiA+ID4gIAlnZW45X3NldF9kY19zdGF0ZShkZXZf cHJpdiwgRENfU1RBVEVfRElTQUJMRSk7Cj4gPiA+ICAKPiA+ID4gIAkvKiBlbmFibGUgUENIIHJl c2V0IGhhbmRzaGFrZSAqLwo+ID4gPiAtCXZhbCA9IEk5MTVfUkVBRChIU1dfTkRFX1JTVFdSTl9P UFQpOwo+ID4gPiAtCUk5MTVfV1JJVEUoSFNXX05ERV9SU1RXUk5fT1BULCB2YWwgfAo+ID4gPiBS RVNFVF9QQ0hfSEFORFNIQUtFX0VOQUJMRSk7Cj4gPiA+ICsJaW50ZWxfcGNoX3Jlc2V0X2hhbmRz aGFrZShkZXZfcHJpdiwgdHJ1ZSk7Cj4gPiA+ICAKPiA+ID4gIAkvKiBlbmFibGUgUEcxIGFuZCBN aXNjIEkvTyAqLwo+ID4gPiAgCW11dGV4X2xvY2soJnBvd2VyX2RvbWFpbnMtPmxvY2spOwo+ID4g PiBAQCAtMzMwNiw3ICszMzE3LDYgQEAgdm9pZCBieHRfZGlzcGxheV9jb3JlX2luaXQoc3RydWN0 Cj4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgewo+ID4gPiAgCXN0cnVj dCBpOTE1X3Bvd2VyX2RvbWFpbnMgKnBvd2VyX2RvbWFpbnMgPSAmZGV2X3ByaXYtCj4gPiA+ID5w b3dlcl9kb21haW5zOwo+ID4gPiAgCXN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgKndlbGw7Cj4gPiA+ IC0JdWludDMyX3QgdmFsOwo+ID4gPiAgCj4gPiA+ICAJZ2VuOV9zZXRfZGNfc3RhdGUoZGV2X3By aXYsIERDX1NUQVRFX0RJU0FCTEUpOwo+ID4gPiAgCj4gPiA+IEBAIC0zMzE2LDkgKzMzMjYsNyBA QCB2b2lkIGJ4dF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QKPiA+ID4gZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPiA+ICAJICogTW92ZSB0aGUgaGFuZHNoYWtlIHByb2dyYW1taW5nIHRv IGluaXRpYWxpemF0aW9uIHNlcXVlbmNlLgo+ID4gPiAgCSAqIFByZXZpb3VzbHkgd2FzIGxlZnQg dXAgdG8gQklPUy4KPiA+ID4gIAkgKi8KPiA+ID4gLQl2YWwgPSBJOTE1X1JFQUQoSFNXX05ERV9S U1RXUk5fT1BUKTsKPiA+ID4gLQl2YWwgJj0gflJFU0VUX1BDSF9IQU5EU0hBS0VfRU5BQkxFOwo+ ID4gPiAtCUk5MTVfV1JJVEUoSFNXX05ERV9SU1RXUk5fT1BULCB2YWwpOwo+ID4gPiArCWludGVs X3BjaF9yZXNldF9oYW5kc2hha2UoZGV2X3ByaXYsIGZhbHNlKTsKPiA+ID4gIAo+ID4gPiAgCS8q IEVuYWJsZSBQRzEgKi8KPiA+ID4gIAltdXRleF9sb2NrKCZwb3dlcl9kb21haW5zLT5sb2NrKTsK PiA+ID4gQEAgLTM0MzksOSArMzQ0Nyw3IEBAIHN0YXRpYyB2b2lkIGNubF9kaXNwbGF5X2NvcmVf aW5pdChzdHJ1Y3QKPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgcmVzdW1l Cj4gPiA+ICAJZ2VuOV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsIERDX1NUQVRFX0RJU0FCTEUpOwo+ ID4gPiAgCj4gPiA+ICAJLyogMS4gRW5hYmxlIFBDSCBSZXNldCBIYW5kc2hha2UgKi8KPiA+ID4g LQl2YWwgPSBJOTE1X1JFQUQoSFNXX05ERV9SU1RXUk5fT1BUKTsKPiA+ID4gLQl2YWwgfD0gUkVT RVRfUENIX0hBTkRTSEFLRV9FTkFCTEU7Cj4gPiA+IC0JSTkxNV9XUklURShIU1dfTkRFX1JTVFdS Tl9PUFQsIHZhbCk7Cj4gPiA+ICsJaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFrZShkZXZfcHJpdiwg dHJ1ZSk7Cj4gPiA+ICAKPiA+ID4gIAkvKiAyLiBFbmFibGUgQ29tcCAqLwo+ID4gPiAgCXZhbCA9 IEk5MTVfUkVBRChDSElDS0VOX01JU0NfMik7Cj4gPiA+IEBAIC0zNTI0LDkgKzM1MzAsNyBAQCBz dGF0aWMgdm9pZCBpY2xfZGlzcGxheV9jb3JlX2luaXQoc3RydWN0Cj4gPiA+IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ID4gPiAgCWdlbjlfc2V0X2RjX3N0YXRlKGRldl9wcml2LCBEQ19T VEFURV9ESVNBQkxFKTsKPiA+ID4gIAo+ID4gPiAgCS8qIDEuIEVuYWJsZSBQQ0ggcmVzZXQgaGFu ZHNoYWtlLiAqLwo+ID4gPiAtCXZhbCA9IEk5MTVfUkVBRChIU1dfTkRFX1JTVFdSTl9PUFQpOwo+ ID4gPiAtCXZhbCB8PSBSRVNFVF9QQ0hfSEFORFNIQUtFX0VOQUJMRTsKPiA+ID4gLQlJOTE1X1dS SVRFKEhTV19OREVfUlNUV1JOX09QVCwgdmFsKTsKPiA+ID4gKwlpbnRlbF9wY2hfcmVzZXRfaGFu ZHNoYWtlKGRldl9wcml2LCB0cnVlKTsKPiA+ID4gIAo+ID4gPiAgCWZvciAocG9ydCA9IFBPUlRf QTsgcG9ydCA8PSBQT1JUX0I7IHBvcnQrKykgewo+ID4gPiAgCQkvKiAyLiBFbmFibGUgRERJIGNv bWJvIFBIWSBjb21wLiAqLwo+ID4gPiAtLSAKPiA+ID4gMi4xOS4wCj4gPiAKPiA+IApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK