All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: zhe.he@windriver.com
Cc: pmladek@suse.com, sergey.senozhatsky@gmail.com,
	rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line
Date: Wed, 19 Sep 2018 10:50:30 +0900	[thread overview]
Message-ID: <20180919015030.GA423@jagdpanzerIV> (raw)
In-Reply-To: <1537291068-443145-1-git-send-email-zhe.he@windriver.com>

On (09/19/18 01:17), zhe.he@windriver.com wrote:
> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size)
>  /* save requested log_buf_len since it's too early to process it */
>  static int __init log_buf_len_setup(char *str)
>  {
> -	unsigned size = memparse(str, &str);
> +	unsigned size;

	unsigned int size;

> +	if (!str) {
> +		pr_err("Config string not provided\n");

pr_debug() may be?

It's not clear from this error message which one of the "config strings"
was not provided. Besides, I think "config string" is misleading and in
fact it's a "boot command line parameter". But, dunno, I guess I'd just
drop that print out.

Otherwise,

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

  parent reply	other threads:[~2018-09-19  1:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 17:17 [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line zhe.he
2018-09-18 17:17 ` [PATCH v2 2/2] printk: Add KBUILD_MODNAME and correct bare use of unsigned zhe.he
2018-09-19  2:06   ` Sergey Senozhatsky
2018-09-19 11:20     ` Petr Mladek
2018-09-19  1:50 ` Sergey Senozhatsky [this message]
2018-09-19  2:27   ` [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line He Zhe
2018-09-19  2:39     ` Sergey Senozhatsky
2018-09-19  2:43       ` Steven Rostedt
2018-09-19  2:47         ` Sergey Senozhatsky
2018-09-19  3:05           ` Steven Rostedt
2018-09-20 16:16         ` He Zhe
2018-09-20 16:30           ` Steven Rostedt
2018-09-21  7:37             ` Petr Mladek
2018-09-22 15:36               ` He Zhe
2018-09-25 12:16                 ` Sergey Senozhatsky
2018-09-25 12:01               ` Sergey Senozhatsky
2018-09-25 12:23                 ` Petr Mladek
2018-09-25 12:37                   ` Sergey Senozhatsky
2018-09-25 13:31                   ` Sergey Senozhatsky
2018-09-25 15:31                     ` He Zhe
2018-09-26 11:05                     ` Petr Mladek
2018-09-28  7:35                       ` Sergey Senozhatsky
2018-09-28  8:22                         ` He Zhe
2018-09-19  6:44     ` Sergey Senozhatsky
2018-09-19 10:09       ` He Zhe
2018-09-19 18:58 ` Sasha Levin
2018-09-22 14:45   ` He Zhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919015030.GA423@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.