From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: rostedt@goodmis.org, tglx@linutronix.de, mhiramat@kernel.org,
namhyung@kernel.org, vedang.patel@intel.com,
bigeasy@linutronix.de, joel@joelfernandes.org,
mathieu.desnoyers@efficios.com, julia@ni.com,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v4 8/8] trace: Add alternative synthetic event trace action syntax
Date: Wed, 19 Sep 2018 03:54:46 +0900 [thread overview]
Message-ID: <20180919035446.4fb6b856ab51229984eb2736@kernel.org> (raw)
In-Reply-To: <95e91d682061a3a43ea293b20ff4beea755b945a.1536605847.git.tom.zanussi@linux.intel.com>
Hi Tom,
On Mon, 10 Sep 2018 14:10:46 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> Add a 'trace(synthetic_event_name, params)' alternative to
> synthetic_event_name(params).
>
> Currently, the syntax used for generating synthetic events is to
> invoke synthetic_event_name(params) i.e. use the synthetic event name
> as a function call.
>
> Users requested a new form that more explicitly shows that the
> synthetic event is in effect being traced. In this version, a new
> 'trace()' keyword is used, and the synthetic event name is passed in
> as the first argument.
Hmm, what is the advantage of adding this new form?
Thanks,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-09-18 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 19:10 [PATCH v4 0/8] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 1/8] tracing: Refactor hist trigger action code Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 2/8] tracing: Split up onmatch action data Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 3/8] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 4/8] tracing: Add conditional snapshot Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 5/8] tracing: Move hist trigger key printing into a separate function Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 6/8] tracing: Add snapshot action Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 7/8] tracing: Add hist trigger onchange() handler Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 8/8] trace: Add alternative synthetic event trace action syntax Tom Zanussi
2018-09-18 18:54 ` Masami Hiramatsu [this message]
2018-09-18 19:16 ` Tom Zanussi
2018-09-18 23:54 ` Masami Hiramatsu
2018-09-19 16:33 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919035446.4fb6b856ab51229984eb2736@kernel.org \
--to=mhiramat@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.