From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd
Date: Wed, 19 Sep 2018 15:23:34 +0200 [thread overview]
Message-ID: <20180919132334.GA31335@x230> (raw)
In-Reply-To: <1536937329-13902-1-git-send-email-alexey.kodanev@oracle.com>
Hi Alexey,
> The drivers are checked with modprobe. If modprobe is not available
> on the system, the checks are silently skipped.
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> v3: * Changed the docs according to the Cyril's comment
> * Added curly braces in tst_check_drivers.c
> * Added dry-run option to modprobe
I like this change as it allows to load module with parameters later.
Kind regards,
Petr
prev parent reply other threads:[~2018-09-19 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 15:02 [LTP] [PATCH v3 1/2] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Alexey Kodanev
2018-09-14 15:02 ` [LTP] [PATCH v3 2/2] lib/tst_test.sh: add TST_NEEDS_DRIVERS parameter Alexey Kodanev
2018-09-19 13:29 ` Petr Vorel
2018-09-20 11:51 ` Alexey Kodanev
2018-09-19 13:23 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919132334.GA31335@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.