From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: a.zummo@towertech.it, andy.shevchenko@gmail.com, robh@kernel.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx
Date: Wed, 19 Sep 2018 19:06:18 +0200 [thread overview]
Message-ID: <20180919170618.GC2479@piout.net> (raw)
In-Reply-To: <20180725172605.108040-4-giulio.benetti@micronovasrl.com>
On 25/07/2018 19:26:05+0200, Giulio Benetti wrote:
> On m41txx you can enable open-drain OUT pin to check if offset is ok.
> Enabling OUT pin with frequency_test_enable attribute, OUT pin will tick
> 512 times faster than 1s tick base.
>
> Enable or Disable FT bit on CONTROL register if freq_test is 1 or 0.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> V10 => V11:
> * kstrtobool(): check error if (ret) avoiding checking specific error.
>
> drivers/rtc/rtc-ds1307.c | 94 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 94 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-09-19 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 17:26 [PATCH v11 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
2018-07-25 17:26 ` [PATCH v11 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-07-25 17:26 ` [PATCH v11 3/4] rtc: ds1307: add offset sysfs for mt41txx chips Giulio Benetti
2018-09-19 17:05 ` Alexandre Belloni
2018-07-25 17:26 ` [PATCH v11 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Giulio Benetti
2018-09-19 17:06 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919170618.GC2479@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andy.shevchenko@gmail.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.