All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Roman Gushchin <guro@fb.com>, Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com
Subject: Re: [PATCH v2] mm: memcg: update memcg OOM messages on cgroup2
Date: Wed, 19 Sep 2018 13:17:44 -0400	[thread overview]
Message-ID: <20180919171744.GA18068@cmpxchg.org> (raw)
In-Reply-To: <20180806181926.GF410235@devbig004.ftw2.facebook.com>

On Mon, Aug 06, 2018 at 11:19:26AM -0700, Tejun Heo wrote:
> On Mon, Aug 06, 2018 at 11:08:45AM -0700, Andrew Morton wrote:
> > On Mon, 6 Aug 2018 09:15:29 -0700 Tejun Heo <tj@kernel.org> wrote:
> > 
> > > mem_cgroup_print_oom_info() currently prints the same info for cgroup1
> > > and cgroup2 OOMs.  It doesn't make much sense on cgroup2, which
> > > doesn't use memsw or separate kmem accounting - the information
> > > reported is both superflous and insufficient.  This patch updates the
> > > memcg OOM messages on cgroup2 so that
> > > 
> > > * It prints memory and swap usages and limits used on cgroup2.
> > > 
> > > * It shows the same information as memory.stat.
> > > 
> > > I took out the recursive printing for cgroup2 because the amount of
> > > output could be a lot and the benefits aren't clear.  An example dump
> > > follows.
> > 
> > This conflicts rather severely with Shakeel's "memcg: reduce memcg tree
> > traversals for stats collection".  Can we please park this until after
> > 4.19-rc1?
> 
> Sure, or I can refresh the patch on top of -mm too.

Now that 4.19 is released, do you mind refreshing this for 4.20?

  reply	other threads:[~2018-09-19 17:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 17:57 [PATCH] mm: memcg: update memcg OOM messages on cgroup2 Tejun Heo
2018-08-03 20:30 ` Roman Gushchin
2018-08-06 15:55   ` Johannes Weiner
2018-08-06 15:48 ` Johannes Weiner
2018-08-06 16:15 ` [PATCH v2] " Tejun Heo
2018-08-06 16:34   ` Roman Gushchin
2018-08-06 18:08   ` Andrew Morton
2018-08-06 18:19     ` Tejun Heo
2018-09-19 17:17       ` Johannes Weiner [this message]
2018-08-06 20:06   ` Michal Hocko
2018-08-06 20:19     ` Tejun Heo
2018-08-07  7:13       ` Michal Hocko
2018-08-07 15:09         ` Tejun Heo
2018-08-07 17:54           ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919171744.GA18068@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=tj@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.