All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915/dp: Move hdcp link check function into short pulse handler
Date: Wed, 19 Sep 2018 20:30:08 +0300	[thread overview]
Message-ID: <20180919173008.GK5565@intel.com> (raw)
In-Reply-To: <20180918072009.4836-5-dhinakaran.pandiyan@intel.com>

On Tue, Sep 18, 2018 at 12:20:09AM -0700, Dhinakaran Pandiyan wrote:
> This way all short pulse handlers except MST are in one place.
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 123c2eafafab..03d2c6426016 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4501,6 +4501,9 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
>  		drm_kms_helper_hotplug_event(&dev_priv->drm);
>  	}
>  
> +	/* Short pulse can signify loss of hdcp authentication */
> +	intel_hdcp_check_link(intel_dp->attached_connector);
> +
>  	return true;
>  }
>  
> @@ -5634,9 +5637,6 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>  
>  		handled = intel_dp_short_pulse(intel_dp);
>  
> -		/* Short pulse can signify loss of hdcp authentication */
> -		intel_hdcp_check_link(intel_dp->attached_connector);
> -

This changes the behaviour to skip intel_hdcp_check_link() when
intel_dp_short_pulse() decides to fall back to full detect. Not sure if
that's OK or not.

>  		if (!handled)
>  			goto put_power;
>  	}
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-09-19 17:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  7:20 [PATCH 1/5] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse() Dhinakaran Pandiyan
2018-09-18  7:20 ` [PATCH 2/5] drm/i915/dp: Restrict link retrain workaround to external monitors Dhinakaran Pandiyan
2018-09-18 15:33   ` Lyude Paul
2018-09-18 15:50     ` Rodrigo Vivi
2018-09-19 17:58       ` Pandiyan, Dhinakaran
2018-09-19 18:28         ` Lyude Paul
2018-09-18  7:20 ` [PATCH 3/5] drm/i915/dp: Remove intel_dp->detect_done flag Dhinakaran Pandiyan
2018-09-19 17:28   ` Ville Syrjälä
2018-09-19 17:43     ` Pandiyan, Dhinakaran
2018-09-18  7:20 ` [PATCH 4/5] drm/i915/dp: Fix duplication of DEVICE_SERVICE_IRQ handling Dhinakaran Pandiyan
2018-09-18  7:20 ` [PATCH 5/5] drm/i915/dp: Move hdcp link check function into short pulse handler Dhinakaran Pandiyan
2018-09-19 17:30   ` Ville Syrjälä [this message]
2018-09-19 17:49     ` Pandiyan, Dhinakaran
2018-09-19 18:05       ` Ville Syrjälä
2018-09-21 19:06         ` Dhinakaran Pandiyan
2018-09-22 23:08         ` Pandiyan, Dhinakaran
2018-09-18  7:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse() Patchwork
2018-09-18  7:55 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-09-18 15:51 ` [PATCH 1/5] " Rodrigo Vivi
2018-09-18 19:03   ` Pandiyan, Dhinakaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919173008.GK5565@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.