Re: [PATCH 1/3] sim800: adding support for Simcom SIM800 modem

[Clement Viel <vielclement@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3932 bytes --]


On Wed, Sep 19, 2018 at 08:03:27PM +0300, Pičugins Arsenijs wrote:
Hi,

I guess I submit it in a hurry and forgot to add the firmware version.
BTW, your problem may be related to this. Are you sure your CMUX command is not returning an error ? Thus preventing ofono from enabling the modem ? I had this problem and Simcom sent me an updated firmware that supports the CMUX command.

> <div>Hello!</div><div> </div><div>&gt; You might want to describe how this is different from sim900 that it<br />&gt; warrants a fully separate driver?</div><div> </div><div>I've tried to apply this patch yesterday evening (since I too am</div><div>interested in SIM800 integration) and tried to apply it, patch 2</div><div>doesn't apply on current master for some reason. Here's a diff</div><div>between current SIM900 and this SIM800:</div><div><a href="https://matrix.org/_matrix/media/v1/download/matrix.org/KqDxbcuYLxrcceUfRorxYgus" data-external="true">https://matrix.org/_matrix/media/v1/download/matrix.org/KqDxbcuYLxrcceUfRorxYgus</a></div><div> </div><div>tl;dr: apart from</div><div> </div><div>- adding phonebook support (two lines, I don't understand it quite yet)</div><div>- the sleep() hack</div><div>- a comment clarifying a problem with some unknown version of firmware</div><div>- DBG() log calls</div><div>- sim900 =&gt; sim800 renaming</div><div> </div><div>it's no different than current SIM900 driver. Unfortunately, that</div><div>doesn't solve the problems I'm personally experiencing (hang on</div><div>CFUN, for one).</div><div> </div><div>Cheers!<br />Arsenijs</div><div> </div><div>19.09.2018, 19:51, "Denis Kenzior" &lt;denkenz(a)gmail.com&gt;:</div><blockquote type="cite"><p>Hi,<br /><br />On 09/18/2018 03:36 PM, ClémentViel wrote:</p><blockquote> From: clem &lt;<a data-external="true" href="mailto:vielclement@gmail.com">vielclement(a)gmail.com</a>&gt;<br /> </blockquote><p><br />You might want to describe how this is different from sim900 that it<br />warrants a fully separate driver?<br /><br />If there are only minor differences, then this can be handled via UDEV<br />attributes or querying +CGMM, etc.<br /> </p><blockquote> ---<br />   Makefile.am | 4 +<br />   plugins/sim800.c | 424 +++++++++++++++++++++++++++++++++++++++++++++++++++++++<br />   2 files changed, 428 insertions(+)<br />   create mode 100644 plugins/sim800.c<br /> </blockquote><p><br />&lt;snip&gt;<br /> </p><blockquote> +<br /> +static void sim800_post_sim(struct ofono_modem *modem)<br /> +{<br /> + struct sim800_data *data = ofono_modem_get_data(modem);<br /> + struct ofono_gprs *gprs;<br /> + struct ofono_gprs_context *gc;<br /> +<br /> + DBG("%p", modem);<br /> +<br /> + /* Dirty Hack : give some time to sim800 for multiplexing<br /> + * to be effective and avoid VOICE_DLC to be<br /> + * flooded thus leading to a "famine" situation<br /> + */<br /> +<br /> + sleep(2);</blockquote><p><br />No sleeps inside plugins. That blocks the entire daemon and we can't<br />have that. How does this help you anyway? GAtChat is a queue, so only<br />1 command is outstanding at a time.<br /> </p><blockquote> + ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem",<br /> + data-&gt;dlcs[SMS_DLC]);<br /> +<br /> +<br /> + gprs = ofono_gprs_create(modem, 0, "atmodem", data-&gt;dlcs[GPRS_DLC]);<br /> + if (gprs == NULL)<br /> + return;<br /> +<br /> + gc = ofono_gprs_context_create(modem, OFONO_VENDOR_SIMCOM,<br /> + "atmodem", data-&gt;dlcs[GPRS_DLC]);<br /> + if (gc)<br /> + ofono_gprs_add_context(gprs, gc);<br /> +}<br /> +</blockquote><p><br />Regards,<br />-Denis<br />_______________________________________________<br />ofono mailing list<br /><a data-external="true" href="mailto:ofono@ofono.org">ofono(a)ofono.org</a><br /><a href="https://lists.ofono.org/mailman/listinfo/ofono">https://lists.ofono.org/mailman/listinfo/ofono</a></p></blockquote>