From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
Andrei Vagin <avagin@openvz.org>,
Dmitry Safonov <dima@arista.com>, Adrian Reber <adrian@lisas.de>,
Andy Lutomirski <luto@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jeff Dike <jdike@addtoit.com>, Oleg Nesterov <oleg@redhat.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
containers@lists.linux-foundation.org, criu@openvz.org,
linux-api@vger.kernel.org, x86@kernel.org
Subject: [RFC 02/20] timens: Add timens_offsets
Date: Wed, 19 Sep 2018 21:50:19 +0100 [thread overview]
Message-ID: <20180919205037.9574-3-dima@arista.com> (raw)
In-Reply-To: <20180919205037.9574-1-dima@arista.com>
From: Andrei Vagin <avagin@openvz.org>
Introduce offsets for time namespace. They will contain adjustment
needed to convert clocks to/from host's.
Allocate one page for each time namespace that will be premapped into
userspace with vvar pages.
Signed-off-by: Andrei Vagin <avagin@openvz.org>
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
include/linux/time_namespace.h | 2 ++
include/linux/timens_offsets.h | 8 ++++++++
kernel/time_namespace.c | 14 ++++++++++++--
3 files changed, 22 insertions(+), 2 deletions(-)
create mode 100644 include/linux/timens_offsets.h
diff --git a/include/linux/time_namespace.h b/include/linux/time_namespace.h
index bf98f35efe07..4960c54f1b33 100644
--- a/include/linux/time_namespace.h
+++ b/include/linux/time_namespace.h
@@ -8,6 +8,7 @@
#include <linux/nsproxy.h>
#include <linux/ns_common.h>
#include <linux/err.h>
+#include <linux/timens_offsets.h>
struct user_namespace;
extern struct user_namespace init_user_ns;
@@ -17,6 +18,7 @@ struct time_namespace {
struct user_namespace *user_ns;
struct ucounts *ucounts;
struct ns_common ns;
+ struct timens_offsets *offsets;
} __randomize_layout;
extern struct time_namespace init_time_ns;
diff --git a/include/linux/timens_offsets.h b/include/linux/timens_offsets.h
new file mode 100644
index 000000000000..7d7cb68ea778
--- /dev/null
+++ b/include/linux/timens_offsets.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_TIME_OFFSETS_H
+#define _LINUX_TIME_OFFSETS_H
+
+struct timens_offsets {
+};
+
+#endif
diff --git a/kernel/time_namespace.c b/kernel/time_namespace.c
index 902cd9c22159..a985529754b4 100644
--- a/kernel/time_namespace.c
+++ b/kernel/time_namespace.c
@@ -13,6 +13,7 @@
#include <linux/user_namespace.h>
#include <linux/proc_ns.h>
#include <linux/sched/task.h>
+#include <linux/mm.h>
static struct ucounts *inc_time_namespaces(struct user_namespace *ns)
{
@@ -44,6 +45,7 @@ static struct time_namespace *clone_time_ns(struct user_namespace *user_ns,
{
struct time_namespace *ns;
struct ucounts *ucounts;
+ struct page *page;
int err;
err = -ENOSPC;
@@ -56,15 +58,22 @@ static struct time_namespace *clone_time_ns(struct user_namespace *user_ns,
if (!ns)
goto fail_dec;
+ page = alloc_page(GFP_KERNEL | __GFP_ZERO);
+ if (!page)
+ goto fail_free;
+ ns->offsets = page_address(page);
+ BUILD_BUG_ON(sizeof(*ns->offsets) > PAGE_SIZE);
+
err = ns_alloc_inum(&ns->ns);
if (err)
- goto fail_free;
+ goto fail_page;
ns->ucounts = ucounts;
ns->ns.ops = &timens_operations;
ns->user_ns = get_user_ns(user_ns);
return ns;
-
+fail_page:
+ free_page((unsigned long)ns->offsets);
fail_free:
kfree(ns);
fail_dec:
@@ -93,6 +102,7 @@ void free_time_ns(struct kref *kref)
struct time_namespace *ns;
ns = container_of(kref, struct time_namespace, kref);
+ free_page((unsigned long)ns->offsets);
dec_time_namespaces(ns->ucounts);
put_user_ns(ns->user_ns);
ns_free_inum(&ns->ns);
--
2.13.6
next prev parent reply other threads:[~2018-09-19 20:50 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 20:50 [RFC 00/20] ns: Introduce Time Namespace Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-19 20:50 ` [RFC 01/20] " Dmitry Safonov
2018-09-28 18:20 ` Laurent Vivier
2018-09-19 20:50 ` Dmitry Safonov [this message]
2018-09-20 18:45 ` [RFC 02/20] timens: Add timens_offsets Cyrill Gorcunov
2018-09-20 22:14 ` Cyrill Gorcunov
2018-09-19 20:50 ` [RFC 03/20] timens: Introduce CLOCK_MONOTONIC offsets Dmitry Safonov
2018-09-19 20:50 ` [RFC 04/20] timens: Introduce CLOCK_BOOTTIME offset Dmitry Safonov
2018-09-30 3:18 ` [LKP] [timens] 3cc8de9dcb: RIP:posix_get_boottime kernel test robot
2018-09-30 3:18 ` kernel test robot
2018-09-30 3:18 ` kernel test robot
2018-09-19 20:50 ` [RFC 05/20] timerfd/timens: Take into account ns clock offsets Dmitry Safonov
2018-09-19 20:50 ` [RFC 06/20] kernel: Take into account timens clock offsets in clock_nanosleep Dmitry Safonov
2018-09-19 20:50 ` [RFC 07/20] timens: Shift /proc/uptime Dmitry Safonov
2018-09-19 20:50 ` [RFC 08/20] x86/vdso: Restrict splitting vvar vma Dmitry Safonov
2018-09-19 20:50 ` [RFC 09/20] x86/vdso/timens: Add offsets page in vvar Dmitry Safonov
2018-09-19 20:50 ` [RFC 10/20] x86/vdso: Use set_normalized_timespec() to avoid 32 bit overflow Dmitry Safonov
2018-09-19 20:50 ` [RFC 11/20] x86/vdso: Purge timens page on setns()/unshare()/clone() Dmitry Safonov
2018-09-19 20:50 ` [RFC 12/20] x86/vdso: Look for vvar vma to purge timens page Dmitry Safonov
2018-09-19 20:50 ` [RFC 13/20] posix-timers/timens: Take into account clock offsets Dmitry Safonov
2018-09-30 3:11 ` [LKP] [posix] 25217c6e39: BUG:KASAN:null-ptr-deref_in_c kernel test robot
2018-09-30 3:11 ` kernel test robot
2018-09-30 3:11 ` kernel test robot
2018-09-19 20:50 ` [RFC 14/20] timens: Add align for timens_offsets Dmitry Safonov
2018-09-19 20:50 ` [RFC 15/20] timens: Optimize zero-offsets Dmitry Safonov
2018-09-19 20:50 ` [RFC 16/20] selftest: Add Time Namespace test for supported clocks Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-24 21:36 ` Shuah Khan
2018-09-24 21:36 ` Shuah Khan
2018-09-24 21:36 ` shuah
2018-09-19 20:50 ` [RFC 17/20] selftest/timens: Add test for timerfd Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-19 20:50 ` [RFC 18/20] selftest/timens: Add test for clock_nanosleep Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-19 20:50 ` [RFC 19/20] timens/selftest: Add procfs selftest Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-19 20:50 ` [RFC 20/20] timens/selftest: Add timer offsets test Dmitry Safonov
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` dima
2018-09-21 12:27 ` [RFC 00/20] ns: Introduce Time Namespace Eric W. Biederman
2018-09-21 12:27 ` Eric W. Biederman
2018-09-21 12:27 ` ebiederm
2018-09-24 20:51 ` Andrey Vagin
2018-09-24 20:51 ` Andrey Vagin
2018-09-24 20:51 ` Andrey Vagin
2018-09-24 20:51 ` avagin
2018-09-24 22:02 ` Eric W. Biederman
2018-09-24 22:02 ` Eric W. Biederman
2018-09-24 22:02 ` Eric W. Biederman
2018-09-24 22:02 ` ebiederm
2018-09-25 1:42 ` Andrey Vagin
2018-09-25 1:42 ` Andrey Vagin
2018-09-25 1:42 ` Andrey Vagin
2018-09-25 1:42 ` avagin
2018-09-26 17:36 ` Eric W. Biederman
2018-09-26 17:36 ` Eric W. Biederman
2018-09-26 17:36 ` Eric W. Biederman
2018-09-26 17:36 ` ebiederm
2018-09-26 17:59 ` Dmitry Safonov
2018-09-26 17:59 ` Dmitry Safonov
2018-09-26 17:59 ` Dmitry Safonov
2018-09-26 17:59 ` 0x7f454c46
2018-09-27 21:30 ` Thomas Gleixner
2018-09-27 21:30 ` Thomas Gleixner
2018-09-27 21:30 ` Thomas Gleixner
2018-09-27 21:30 ` tglx
2018-09-27 21:41 ` Thomas Gleixner
2018-09-27 21:41 ` Thomas Gleixner
2018-09-27 21:41 ` Thomas Gleixner
2018-09-27 21:41 ` tglx
2018-10-01 23:20 ` Andrey Vagin
2018-10-01 23:20 ` Andrey Vagin
2018-10-01 23:20 ` Andrey Vagin
2018-10-01 23:20 ` avagin
2018-10-02 6:15 ` Thomas Gleixner
2018-10-02 6:15 ` Thomas Gleixner
2018-10-02 6:15 ` Thomas Gleixner
2018-10-02 6:15 ` tglx
2018-10-02 21:05 ` Dmitry Safonov
2018-10-02 21:05 ` Dmitry Safonov
2018-10-02 21:05 ` 0x7f454c46
2018-10-02 21:26 ` Thomas Gleixner
2018-10-02 21:26 ` Thomas Gleixner
2018-10-02 21:26 ` tglx
2018-09-28 17:03 ` Eric W. Biederman
2018-09-28 17:03 ` Eric W. Biederman
2018-09-28 17:03 ` Eric W. Biederman
2018-09-28 17:03 ` ebiederm
2018-09-28 19:32 ` Thomas Gleixner
2018-09-28 19:32 ` Thomas Gleixner
2018-09-28 19:32 ` Thomas Gleixner
2018-09-28 19:32 ` tglx
2018-10-01 9:05 ` Eric W. Biederman
2018-10-01 9:05 ` Eric W. Biederman
2018-10-01 9:05 ` Eric W. Biederman
2018-10-01 9:05 ` ebiederm
2018-10-01 9:15 ` Setting monotonic time? Eric W. Biederman
2018-10-01 9:15 ` Eric W. Biederman
2018-10-01 9:15 ` Eric W. Biederman
2018-10-01 9:15 ` ebiederm
2018-10-01 18:52 ` Thomas Gleixner
2018-10-01 18:52 ` Thomas Gleixner
2018-10-01 18:52 ` Thomas Gleixner
2018-10-01 18:52 ` tglx
2018-10-02 20:00 ` Arnd Bergmann
2018-10-02 20:00 ` Arnd Bergmann
2018-10-02 20:00 ` arnd
2018-10-02 20:06 ` Thomas Gleixner
2018-10-02 20:06 ` Thomas Gleixner
2018-10-02 20:06 ` tglx
2018-10-03 4:50 ` Eric W. Biederman
2018-10-03 4:50 ` Eric W. Biederman
2018-10-03 4:50 ` ebiederm
2018-10-03 5:25 ` Thomas Gleixner
2018-10-03 5:25 ` Thomas Gleixner
2018-10-03 5:25 ` tglx
2018-10-03 6:14 ` Eric W. Biederman
2018-10-03 6:14 ` Eric W. Biederman
2018-10-03 6:14 ` ebiederm
2018-10-03 7:02 ` Arnd Bergmann
2018-10-03 7:02 ` Arnd Bergmann
2018-10-03 7:02 ` arnd
2018-10-03 6:14 ` Thomas Gleixner
2018-10-03 6:14 ` Thomas Gleixner
2018-10-03 6:14 ` tglx
2018-10-01 20:51 ` Andrey Vagin
2018-10-01 20:51 ` Andrey Vagin
2018-10-01 20:51 ` Andrey Vagin
2018-10-01 20:51 ` avagin
2018-10-02 6:16 ` Thomas Gleixner
2018-10-02 6:16 ` Thomas Gleixner
2018-10-02 6:16 ` Thomas Gleixner
2018-10-02 6:16 ` tglx
2018-10-21 1:41 ` [RFC 00/20] ns: Introduce Time Namespace Andrei Vagin
2018-10-21 1:41 ` Andrei Vagin
2018-10-21 1:41 ` Andrei Vagin
2018-10-21 1:41 ` avagin
2018-10-21 3:54 ` Andrei Vagin
2018-10-21 3:54 ` Andrei Vagin
2018-10-21 3:54 ` Andrei Vagin
2018-10-21 3:54 ` avagin
2018-10-29 20:33 ` Thomas Gleixner
2018-10-29 20:33 ` Thomas Gleixner
2018-10-29 20:33 ` Thomas Gleixner
2018-10-29 20:33 ` tglx
2018-10-29 21:21 ` Eric W. Biederman
2018-10-29 21:21 ` Eric W. Biederman
2018-10-29 21:21 ` Eric W. Biederman
2018-10-29 21:21 ` ebiederm
2018-10-29 21:36 ` Thomas Gleixner
2018-10-29 21:36 ` Thomas Gleixner
2018-10-29 21:36 ` Thomas Gleixner
2018-10-29 21:36 ` tglx
2018-10-31 16:26 ` Andrei Vagin
2018-10-31 16:26 ` Andrei Vagin
2018-10-31 16:26 ` Andrei Vagin
2018-10-31 16:26 ` avagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919205037.9574-3-dima@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=adrian@lisas.de \
--cc=avagin@openvz.org \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=criu@openvz.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.