From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 2F5237D57F for ; Wed, 19 Sep 2018 21:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbeITDFf convert rfc822-to-8bit (ORCPT ); Wed, 19 Sep 2018 23:05:35 -0400 Received: from mail.bootlin.com ([62.4.15.54]:36344 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727745AbeITDFe (ORCPT ); Wed, 19 Sep 2018 23:05:34 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 3970D20795; Wed, 19 Sep 2018 23:25:44 +0200 (CEST) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 7D51E203DA; Wed, 19 Sep 2018 23:25:42 +0200 (CEST) Date: Wed, 19 Sep 2018 23:25:42 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Marek Vasut , Jonathan Corbet , linux-doc@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap@vger.kernel.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ralf Baechle , linux-mips@linux-mips.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Message-ID: <20180919232542.5e8f066e@xps13> In-Reply-To: <20180917102939.3ff716db@bbrezillon> References: <20180906223851.6964-1-boris.brezillon@bootlin.com> <20180915195440.251fea18@xps13> <20180917102939.3ff716db@bbrezillon> Organization: Bootlin X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Boris, Boris Brezillon wrote on Mon, 17 Sep 2018 10:29:39 +0200: > On Sat, 15 Sep 2018 19:54:40 +0200 > Miquel Raynal wrote: > > > Hi Boris, > > > > Boris Brezillon wrote on Fri, 7 Sep 2018 > > 00:38:32 +0200: > > > > > Hello, > > > > > > This is the 2nd batch of API cleanup patches. This time we move > > > deprecated hooks/fields to the nand_legacy struct, and then move some > > > of the code found in nand_base.c into separate source/header files. > > > > > > With this new organization, new comers should more easily identify the > > > bits they can use in their NAND controller drivers and those that are > > > only meant for core code. It also shrink a bit nand_base.c which was > > > over 6000 lines of code. > > > > > > Note that existing coding style issues (reported by checkpatch) in arch > > > or driver code are intentionally not fixed to keep the series focused > > > on the API/core cleanup. > > > > > > Regards, > > > > > > Boris > > > > > > Boris Brezillon (19): > > > mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused > > > mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there > > > mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks > > > mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc() > > > mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc() > > > mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks > > > mtd: rawnand: Deprecate ->erase() > > > mtd: rawnand: Deprecate ->{set,get}_features() hooks > > > mtd: rawnand: Deprecate ->chip_delay > > > mtd: rawnand: Move function prototypes after struct declarations > > > mtd: rawnand: Get rid of nand_flash_dev forward declation > > > mtd: rawnand: Get rid of the duplicate nand_chip forward declaration > > > mtd: rawnand: Get rid of a few unused definitions > > > mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h > > > mtd: rawnand: Inline onfi_get_async_timing_mode() > > > mtd: rawnand: Keep all internal stuff private > > > mtd: rawnand: Move legacy code to nand_legacy.c > > > mtd: rawnand: Move ONFI code to nand_onfi.c > > > mtd: rawnand: Move JEDEC code to nand_jedec.c > > > > > > Documentation/driver-api/mtdnand.rst | 30 +- > > > arch/arm/mach-ep93xx/snappercl15.c | 8 +- > > > arch/arm/mach-ep93xx/ts72xx.c | 9 +- > > > arch/arm/mach-imx/mach-qong.c | 6 +- > > > arch/arm/mach-ixp4xx/ixdp425-setup.c | 2 +- > > > arch/arm/mach-omap1/board-fsample.c | 3 +- > > > arch/arm/mach-omap1/board-h2.c | 3 +- > > > arch/arm/mach-omap1/board-h3.c | 2 +- > > > arch/arm/mach-omap1/board-nand.c | 2 +- > > > arch/arm/mach-omap1/board-perseus2.c | 3 +- > > > arch/arm/mach-orion5x/ts78xx-setup.c | 9 +- > > > arch/arm/mach-pxa/balloon3.c | 5 +- > > > arch/arm/mach-pxa/em-x270.c | 9 +- > > > arch/arm/mach-pxa/palmtx.c | 5 +- > > > arch/mips/alchemy/devboards/db1200.c | 9 +- > > > arch/mips/alchemy/devboards/db1300.c | 9 +- > > > arch/mips/alchemy/devboards/db1550.c | 9 +- > > > arch/mips/netlogic/xlr/platform-flash.c | 3 +- > > > arch/mips/pnx833x/common/platform.c | 5 +- > > > arch/mips/rb532/devices.c | 5 +- > > > arch/sh/boards/mach-migor/setup.c | 8 +- > > > drivers/mtd/nand/raw/Makefile | 4 +- > > > drivers/mtd/nand/raw/ams-delta.c | 22 +- > > > drivers/mtd/nand/raw/atmel/nand-controller.c | 22 +- > > > drivers/mtd/nand/raw/au1550nd.c | 43 +- > > > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 22 +- > > > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 15 +- > > > drivers/mtd/nand/raw/cafe_nand.c | 22 +- > > > drivers/mtd/nand/raw/cmx270_nand.c | 28 +- > > > drivers/mtd/nand/raw/cs553x_nand.c | 42 +- > > > drivers/mtd/nand/raw/davinci_nand.c | 34 +- > > > drivers/mtd/nand/raw/denali.c | 23 +- > > > drivers/mtd/nand/raw/diskonchip.c | 50 +- > > > drivers/mtd/nand/raw/fsl_elbc_nand.c | 18 +- > > > drivers/mtd/nand/raw/fsl_ifc_nand.c | 24 +- > > > drivers/mtd/nand/raw/fsl_upm.c | 30 +- > > > drivers/mtd/nand/raw/fsmc_nand.c | 1 - > > > drivers/mtd/nand/raw/gpio.c | 16 +- > > > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 22 +- > > > drivers/mtd/nand/raw/hisi504_nand.c | 18 +- > > > drivers/mtd/nand/raw/internals.h | 114 ++ > > > drivers/mtd/nand/raw/jz4740_nand.c | 14 +- > > > drivers/mtd/nand/raw/jz4780_nand.c | 10 +- > > > drivers/mtd/nand/raw/lpc32xx_mlc.c | 12 +- > > > drivers/mtd/nand/raw/lpc32xx_slc.c | 26 +- > > > drivers/mtd/nand/raw/mpc5121_nfc.c | 14 +- > > > drivers/mtd/nand/raw/mtk_nand.c | 12 +- > > > drivers/mtd/nand/raw/mxc_nand.c | 20 +- > > > drivers/mtd/nand/raw/nand_amd.c | 2 +- > > > drivers/mtd/nand/raw/nand_base.c | 1260 +++------------------- > > > drivers/mtd/nand/raw/nand_bbt.c | 5 +- > > > drivers/mtd/nand/raw/nand_hynix.c | 9 +- > > > drivers/mtd/nand/raw/nand_ids.c | 4 +- > > > drivers/mtd/nand/raw/nand_jedec.c | 113 ++ > > > drivers/mtd/nand/raw/nand_legacy.c | 642 +++++++++++ > > > drivers/mtd/nand/raw/nand_macronix.c | 2 +- > > > drivers/mtd/nand/raw/nand_micron.c | 3 +- > > > drivers/mtd/nand/raw/nand_onfi.c | 305 ++++++ > > > drivers/mtd/nand/raw/nand_samsung.c | 2 +- > > > drivers/mtd/nand/raw/nand_timings.c | 18 +- > > > drivers/mtd/nand/raw/nand_toshiba.c | 2 +- > > > drivers/mtd/nand/raw/nandsim.c | 14 +- > > > drivers/mtd/nand/raw/ndfc.c | 14 +- > > > drivers/mtd/nand/raw/nuc900_nand.c | 22 +- > > > drivers/mtd/nand/raw/omap2.c | 62 +- > > > drivers/mtd/nand/raw/orion_nand.c | 12 +- > > > drivers/mtd/nand/raw/oxnas_nand.c | 10 +- > > > drivers/mtd/nand/raw/pasemi_nand.c | 32 +- > > > drivers/mtd/nand/raw/plat_nand.c | 17 +- > > > drivers/mtd/nand/raw/qcom_nandc.c | 39 +- > > > drivers/mtd/nand/raw/r852.c | 14 +- > > > drivers/mtd/nand/raw/s3c2410.c | 34 +- > > > drivers/mtd/nand/raw/sh_flctl.c | 18 +- > > > drivers/mtd/nand/raw/sharpsl.c | 12 +- > > > drivers/mtd/nand/raw/sm_common.c | 2 +- > > > drivers/mtd/nand/raw/socrates_nand.c | 16 +- > > > drivers/mtd/nand/raw/sunxi_nand.c | 14 +- > > > drivers/mtd/nand/raw/tango_nand.c | 12 +- > > > drivers/mtd/nand/raw/tmio_nand.c | 20 +- > > > drivers/mtd/nand/raw/txx9ndfmc.c | 12 +- > > > drivers/mtd/nand/raw/xway_nand.c | 12 +- > > > drivers/staging/mt29f_spinand/mt29f_spinand.c | 16 +- > > > include/linux/mtd/jedec.h | 91 ++ > > > include/linux/mtd/onfi.h | 178 +++ > > > include/linux/mtd/platnand.h | 74 ++ > > > include/linux/mtd/rawnand.h | 555 ++-------- > > > 86 files changed, 2300 insertions(+), 2191 deletions(-) > > > create mode 100644 drivers/mtd/nand/raw/internals.h > > > create mode 100644 drivers/mtd/nand/raw/nand_jedec.c > > > create mode 100644 drivers/mtd/nand/raw/nand_legacy.c > > > create mode 100644 drivers/mtd/nand/raw/nand_onfi.c > > > create mode 100644 include/linux/mtd/jedec.h > > > create mode 100644 include/linux/mtd/onfi.h > > > create mode 100644 include/linux/mtd/platnand.h > > > > > > > Series reviewed, there is one typo in patch 2/19 and 16/19 and a > > s/ONFI/JEDEC/ in patch 19/19, otherwise I like the cleanup very much! > > Can I modify when applying or you plan to do more/other changes? > > Yep, you can fix+apply the series if you're happy with it. Applied on nand/next (with fixes). Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Date: Wed, 19 Sep 2018 23:25:42 +0200 Message-ID: <20180919232542.5e8f066e@xps13> References: <20180906223851.6964-1-boris.brezillon@bootlin.com> <20180915195440.251fea18@xps13> <20180917102939.3ff716db@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180917102939.3ff716db@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Boris Brezillon Cc: Andrew Lunn , Rich Felker , linux-doc@vger.kernel.org, Tony Lindgren , linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, Thomas Petazzoni , Robert Jarzmik , Alexander Clouter , devel@driverdev.osuosl.org, Alexander Shiyan , Jonathan Corbet , Richard Weinberger , Gregory CLEMENT , linux-sh@vger.kernel.org, Yoshinori Sato , Marek Vasut , NXP Linux Team , Sebastian Hesselbarth , Jason Cooper , Haojian Zhuang , Krzysztof Halasa , linux-omap@vger.kernel.org, Brian Norris List-Id: linux-omap@vger.kernel.org SGkgQm9yaXMsCgpCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4g d3JvdGUgb24gTW9uLCAxNyBTZXAgMjAxOAoxMDoyOTozOSArMDIwMDoKCj4gT24gU2F0LCAxNSBT ZXAgMjAxOCAxOTo1NDo0MCArMDIwMAo+IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9v dGxpbi5jb20+IHdyb3RlOgo+IAo+ID4gSGkgQm9yaXMsCj4gPiAKPiA+IEJvcmlzIEJyZXppbGxv biA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPiB3cm90ZSBvbiBGcmksICA3IFNlcCAyMDE4 Cj4gPiAwMDozODozMiArMDIwMDoKPiA+ICAgCj4gPiA+IEhlbGxvLAo+ID4gPiAKPiA+ID4gVGhp cyBpcyB0aGUgMm5kIGJhdGNoIG9mIEFQSSBjbGVhbnVwIHBhdGNoZXMuIFRoaXMgdGltZSB3ZSBt b3ZlCj4gPiA+IGRlcHJlY2F0ZWQgaG9va3MvZmllbGRzIHRvIHRoZSBuYW5kX2xlZ2FjeSBzdHJ1 Y3QsIGFuZCB0aGVuIG1vdmUgc29tZQo+ID4gPiBvZiB0aGUgY29kZSBmb3VuZCBpbiBuYW5kX2Jh c2UuYyBpbnRvIHNlcGFyYXRlIHNvdXJjZS9oZWFkZXIgZmlsZXMuCj4gPiA+IAo+ID4gPiBXaXRo IHRoaXMgbmV3IG9yZ2FuaXphdGlvbiwgbmV3IGNvbWVycyBzaG91bGQgbW9yZSBlYXNpbHkgaWRl bnRpZnkgdGhlCj4gPiA+IGJpdHMgdGhleSBjYW4gdXNlIGluIHRoZWlyIE5BTkQgY29udHJvbGxl ciBkcml2ZXJzIGFuZCB0aG9zZSB0aGF0IGFyZQo+ID4gPiBvbmx5IG1lYW50IGZvciBjb3JlIGNv ZGUuIEl0IGFsc28gc2hyaW5rIGEgYml0IG5hbmRfYmFzZS5jIHdoaWNoIHdhcwo+ID4gPiBvdmVy IDYwMDAgbGluZXMgb2YgY29kZS4KPiA+ID4gCj4gPiA+IE5vdGUgdGhhdCBleGlzdGluZyBjb2Rp bmcgc3R5bGUgaXNzdWVzIChyZXBvcnRlZCBieSBjaGVja3BhdGNoKSBpbiBhcmNoCj4gPiA+IG9y IGRyaXZlciBjb2RlIGFyZSBpbnRlbnRpb25hbGx5IG5vdCBmaXhlZCB0byBrZWVwIHRoZSBzZXJp ZXMgZm9jdXNlZAo+ID4gPiBvbiB0aGUgQVBJL2NvcmUgY2xlYW51cC4KPiA+ID4gCj4gPiA+IFJl Z2FyZHMsCj4gPiA+IAo+ID4gPiBCb3Jpcwo+ID4gPiAKPiA+ID4gQm9yaXMgQnJlemlsbG9uICgx OSk6Cj4gPiA+ICAgbXRkOiByYXduYW5kOiBMZWF2ZSBjaGlwLT5JT19BRERSX3tSLFd9IHRvIE5V TEwgd2hlbiB1bnVzZWQKPiA+ID4gICBtdGQ6IHJhd25hbmQ6IENyZWF0ZSBhIGxlZ2FjeSBzdHJ1 Y3QgYW5kIG1vdmUgLT5JT19BRERSX3tSLFd9IHRoZXJlCj4gPiA+ICAgbXRkOiByYXduYW5kOiBE ZXByZWNhdGUgLT57cmVhZCx3cml0ZX1fe2J5dGUsYnVmfSgpIGhvb2tzCj4gPiA+ICAgbXRkOiBy YXduYW5kOiBEZXByZWNhdGUgLT5jbWRfY3RybCgpIGFuZCAtPmNtZGZ1bmMoKQo+ID4gPiAgIG10 ZDogcmF3bmFuZDogRGVwcmVjYXRlIC0+ZGV2X3JlYWR5KCkgYW5kIC0+d2FpdGZ1bmMoKQo+ID4g PiAgIG10ZDogcmF3bmFuZDogRGVwcmVjYXRlIC0+YmxvY2tfe2JhZCxtYXJrYmFkfSgpIGhvb2tz Cj4gPiA+ICAgbXRkOiByYXduYW5kOiBEZXByZWNhdGUgLT5lcmFzZSgpCj4gPiA+ICAgbXRkOiBy YXduYW5kOiBEZXByZWNhdGUgLT57c2V0LGdldH1fZmVhdHVyZXMoKSBob29rcwo+ID4gPiAgIG10 ZDogcmF3bmFuZDogRGVwcmVjYXRlIC0+Y2hpcF9kZWxheQo+ID4gPiAgIG10ZDogcmF3bmFuZDog TW92ZSBmdW5jdGlvbiBwcm90b3R5cGVzIGFmdGVyIHN0cnVjdCBkZWNsYXJhdGlvbnMKPiA+ID4g ICBtdGQ6IHJhd25hbmQ6IEdldCByaWQgb2YgbmFuZF9mbGFzaF9kZXYgZm9yd2FyZCBkZWNsYXRp b24KPiA+ID4gICBtdGQ6IHJhd25hbmQ6IEdldCByaWQgb2YgdGhlIGR1cGxpY2F0ZSBuYW5kX2No aXAgZm9yd2FyZCBkZWNsYXJhdGlvbgo+ID4gPiAgIG10ZDogcmF3bmFuZDogR2V0IHJpZCBvZiBh IGZldyB1bnVzZWQgZGVmaW5pdGlvbnMKPiA+ID4gICBtdGQ6IHJhd25hbmQ6IE1vdmUgcGxhdGZv cm1fbmFuZF94eHggZGVmaW5pdGlvbnMgb3V0IG9mIHJhd25hbmQuaAo+ID4gPiAgIG10ZDogcmF3 bmFuZDogSW5saW5lIG9uZmlfZ2V0X2FzeW5jX3RpbWluZ19tb2RlKCkKPiA+ID4gICBtdGQ6IHJh d25hbmQ6IEtlZXAgYWxsIGludGVybmFsIHN0dWZmIHByaXZhdGUKPiA+ID4gICBtdGQ6IHJhd25h bmQ6IE1vdmUgbGVnYWN5IGNvZGUgdG8gbmFuZF9sZWdhY3kuYwo+ID4gPiAgIG10ZDogcmF3bmFu ZDogTW92ZSBPTkZJIGNvZGUgdG8gbmFuZF9vbmZpLmMKPiA+ID4gICBtdGQ6IHJhd25hbmQ6IE1v dmUgSkVERUMgY29kZSB0byBuYW5kX2plZGVjLmMKPiA+ID4gCj4gPiA+ICBEb2N1bWVudGF0aW9u L2RyaXZlci1hcGkvbXRkbmFuZC5yc3QgICAgICAgICAgICAgfCAgIDMwICstCj4gPiA+ICBhcmNo L2FybS9tYWNoLWVwOTN4eC9zbmFwcGVyY2wxNS5jICAgICAgICAgICAgICAgfCAgICA4ICstCj4g PiA+ICBhcmNoL2FybS9tYWNoLWVwOTN4eC90czcyeHguYyAgICAgICAgICAgICAgICAgICAgfCAg ICA5ICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLWlteC9tYWNoLXFvbmcuYyAgICAgICAgICAgICAg ICAgICAgfCAgICA2ICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLWl4cDR4eC9peGRwNDI1LXNldHVw LmMgICAgICAgICAgICAgfCAgICAyICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLW9tYXAxL2JvYXJk LWZzYW1wbGUuYyAgICAgICAgICAgICAgfCAgICAzICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLW9t YXAxL2JvYXJkLWgyLmMgICAgICAgICAgICAgICAgICAgfCAgICAzICstCj4gPiA+ICBhcmNoL2Fy bS9tYWNoLW9tYXAxL2JvYXJkLWgzLmMgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gPiA+ ICBhcmNoL2FybS9tYWNoLW9tYXAxL2JvYXJkLW5hbmQuYyAgICAgICAgICAgICAgICAgfCAgICAy ICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLW9tYXAxL2JvYXJkLXBlcnNldXMyLmMgICAgICAgICAg ICAgfCAgICAzICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLW9yaW9uNXgvdHM3OHh4LXNldHVwLmMg ICAgICAgICAgICAgfCAgICA5ICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLXB4YS9iYWxsb29uMy5j ICAgICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4gPiA+ICBhcmNoL2FybS9tYWNoLXB4YS9l bS14MjcwLmMgICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICstCj4gPiA+ICBhcmNoL2FybS9t YWNoLXB4YS9wYWxtdHguYyAgICAgICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4gPiA+ICBh cmNoL21pcHMvYWxjaGVteS9kZXZib2FyZHMvZGIxMjAwLmMgICAgICAgICAgICAgfCAgICA5ICst Cj4gPiA+ICBhcmNoL21pcHMvYWxjaGVteS9kZXZib2FyZHMvZGIxMzAwLmMgICAgICAgICAgICAg fCAgICA5ICstCj4gPiA+ICBhcmNoL21pcHMvYWxjaGVteS9kZXZib2FyZHMvZGIxNTUwLmMgICAg ICAgICAgICAgfCAgICA5ICstCj4gPiA+ICBhcmNoL21pcHMvbmV0bG9naWMveGxyL3BsYXRmb3Jt LWZsYXNoLmMgICAgICAgICAgfCAgICAzICstCj4gPiA+ICBhcmNoL21pcHMvcG54ODMzeC9jb21t b24vcGxhdGZvcm0uYyAgICAgICAgICAgICAgfCAgICA1ICstCj4gPiA+ICBhcmNoL21pcHMvcmI1 MzIvZGV2aWNlcy5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4gPiA+ICBhcmNo L3NoL2JvYXJkcy9tYWNoLW1pZ29yL3NldHVwLmMgICAgICAgICAgICAgICAgfCAgICA4ICstCj4g PiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAgfCAg ICA0ICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9hbXMtZGVsdGEuYyAgICAgICAgICAg ICAgICAgfCAgIDIyICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9hdG1lbC9uYW5kLWNv bnRyb2xsZXIuYyAgICAgfCAgIDIyICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9hdTE1 NTBuZC5jICAgICAgICAgICAgICAgICAgfCAgIDQzICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5k L3Jhdy9iY200N3h4bmZsYXNoL29wc19iY200NzA2LmMgfCAgIDIyICstCj4gPiA+ICBkcml2ZXJz L210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5jICAgICAgICAgfCAgIDE1ICstCj4gPiA+ ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9jYWZlX25hbmQuYyAgICAgICAgICAgICAgICAgfCAgIDIy ICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9jbXgyNzBfbmFuZC5jICAgICAgICAgICAg ICAgfCAgIDI4ICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9jczU1M3hfbmFuZC5jICAg ICAgICAgICAgICAgfCAgIDQyICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9kYXZpbmNp X25hbmQuYyAgICAgICAgICAgICAgfCAgIDM0ICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jh dy9kZW5hbGkuYyAgICAgICAgICAgICAgICAgICAgfCAgIDIzICstCj4gPiA+ICBkcml2ZXJzL210 ZC9uYW5kL3Jhdy9kaXNrb25jaGlwLmMgICAgICAgICAgICAgICAgfCAgIDUwICstCj4gPiA+ICBk cml2ZXJzL210ZC9uYW5kL3Jhdy9mc2xfZWxiY19uYW5kLmMgICAgICAgICAgICAgfCAgIDE4ICst Cj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9mc2xfaWZjX25hbmQuYyAgICAgICAgICAgICAg fCAgIDI0ICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9mc2xfdXBtLmMgICAgICAgICAg ICAgICAgICAgfCAgIDMwICstCj4gPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9mc21jX25hbmQu YyAgICAgICAgICAgICAgICAgfCAgICAxIC0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2dw aW8uYyAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25h bmQvcmF3L2dwbWktbmFuZC9ncG1pLW5hbmQuYyAgICAgICB8ICAgMjIgKy0KPiA+ID4gIGRyaXZl cnMvbXRkL25hbmQvcmF3L2hpc2k1MDRfbmFuZC5jICAgICAgICAgICAgICB8ICAgMTggKy0KPiA+ ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2ludGVybmFscy5oICAgICAgICAgICAgICAgICB8ICAx MTQgKysKPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2p6NDc0MF9uYW5kLmMgICAgICAgICAg ICAgICB8ICAgMTQgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2p6NDc4MF9uYW5kLmMg ICAgICAgICAgICAgICB8ICAgMTAgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2xwYzMy eHhfbWxjLmMgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L2xwYzMyeHhfc2xjLmMgICAgICAgICAgICAgICB8ICAgMjYgKy0KPiA+ID4gIGRyaXZlcnMv bXRkL25hbmQvcmF3L21wYzUxMjFfbmZjLmMgICAgICAgICAgICAgICB8ICAgMTQgKy0KPiA+ID4g IGRyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMgICAgICAgICAgICAgICAgICB8ICAgMTIg Ky0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L214Y19uYW5kLmMgICAgICAgICAgICAgICAg ICB8ICAgMjAgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfYW1kLmMgICAgICAg ICAgICAgICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfYmFz ZS5jICAgICAgICAgICAgICAgICB8IDEyNjAgKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAg ZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9iYnQuYyAgICAgICAgICAgICAgICAgIHwgICAgNSAr LQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9oeW5peC5jICAgICAgICAgICAgICAg IHwgICAgOSArLQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9pZHMuYyAgICAgICAg ICAgICAgICAgIHwgICAgNCArLQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9qZWRl Yy5jICAgICAgICAgICAgICAgIHwgIDExMyArKwo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcv bmFuZF9sZWdhY3kuYyAgICAgICAgICAgICAgIHwgIDY0MiArKysrKysrKysrKwo+ID4gPiAgZHJp dmVycy9tdGQvbmFuZC9yYXcvbmFuZF9tYWNyb25peC5jICAgICAgICAgICAgIHwgICAgMiArLQo+ ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9taWNyb24uYyAgICAgICAgICAgICAgIHwg ICAgMyArLQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9vbmZpLmMgICAgICAgICAg ICAgICAgIHwgIDMwNSArKysrKysKPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfc2Ft c3VuZy5jICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3 L25hbmRfdGltaW5ncy5jICAgICAgICAgICAgICB8ICAgMTggKy0KPiA+ID4gIGRyaXZlcnMvbXRk L25hbmQvcmF3L25hbmRfdG9zaGliYS5jICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ID4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L25hbmRzaW0uYyAgICAgICAgICAgICAgICAgICB8ICAgMTQgKy0K PiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25kZmMuYyAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTQgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L251YzkwMF9uYW5kLmMgICAgICAg ICAgICAgICB8ICAgMjIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29tYXAyLmMgICAg ICAgICAgICAgICAgICAgICB8ICAgNjIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29y aW9uX25hbmQuYyAgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25h bmQvcmF3L294bmFzX25hbmQuYyAgICAgICAgICAgICAgICB8ICAgMTAgKy0KPiA+ID4gIGRyaXZl cnMvbXRkL25hbmQvcmF3L3Bhc2VtaV9uYW5kLmMgICAgICAgICAgICAgICB8ICAgMzIgKy0KPiA+ ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3BsYXRfbmFuZC5jICAgICAgICAgICAgICAgICB8ICAg MTcgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFuZGMuYyAgICAgICAgICAg ICAgICB8ICAgMzkgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3I4NTIuYyAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTQgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3MzYzI0 MTAuYyAgICAgICAgICAgICAgICAgICB8ICAgMzQgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L3NoX2ZsY3RsLmMgICAgICAgICAgICAgICAgICB8ICAgMTggKy0KPiA+ID4gIGRyaXZlcnMv bXRkL25hbmQvcmF3L3NoYXJwc2wuYyAgICAgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiA+ID4g IGRyaXZlcnMvbXRkL25hbmQvcmF3L3NtX2NvbW1vbi5jICAgICAgICAgICAgICAgICB8ICAgIDIg Ky0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3NvY3JhdGVzX25hbmQuYyAgICAgICAgICAg ICB8ICAgMTYgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYyAgICAg ICAgICAgICAgICB8ICAgMTQgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3RhbmdvX25h bmQuYyAgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiA+ID4gIGRyaXZlcnMvbXRkL25hbmQvcmF3 L3RtaW9fbmFuZC5jICAgICAgICAgICAgICAgICB8ICAgMjAgKy0KPiA+ID4gIGRyaXZlcnMvbXRk L25hbmQvcmF3L3R4eDluZGZtYy5jICAgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiA+ID4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L3h3YXlfbmFuZC5jICAgICAgICAgICAgICAgICB8ICAgMTIgKy0K PiA+ID4gIGRyaXZlcnMvc3RhZ2luZy9tdDI5Zl9zcGluYW5kL210MjlmX3NwaW5hbmQuYyAgICB8 ICAgMTYgKy0KPiA+ID4gIGluY2x1ZGUvbGludXgvbXRkL2plZGVjLmggICAgICAgICAgICAgICAg ICAgICAgICB8ICAgOTEgKysKPiA+ID4gIGluY2x1ZGUvbGludXgvbXRkL29uZmkuaCAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAxNzggKysrCj4gPiA+ICBpbmNsdWRlL2xpbnV4L210ZC9wbGF0 bmFuZC5oICAgICAgICAgICAgICAgICAgICAgfCAgIDc0ICsrCj4gPiA+ICBpbmNsdWRlL2xpbnV4 L210ZC9yYXduYW5kLmggICAgICAgICAgICAgICAgICAgICAgfCAgNTU1ICsrLS0tLS0tLS0KPiA+ ID4gIDg2IGZpbGVzIGNoYW5nZWQsIDIzMDAgaW5zZXJ0aW9ucygrKSwgMjE5MSBkZWxldGlvbnMo LSkKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL210ZC9uYW5kL3Jhdy9pbnRlcm5h bHMuaAo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRf amVkZWMuYwo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbXRkL25hbmQvcmF3L25h bmRfbGVnYWN5LmMKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL210ZC9uYW5kL3Jh dy9uYW5kX29uZmkuYwo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbXRk L2plZGVjLmgKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L210ZC9vbmZp LmgKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L210ZC9wbGF0bmFuZC5o Cj4gPiA+ICAgICAKPiA+IAo+ID4gU2VyaWVzIHJldmlld2VkLCB0aGVyZSBpcyBvbmUgdHlwbyBp biBwYXRjaCAyLzE5IGFuZCAxNi8xOSBhbmQgYQo+ID4gcy9PTkZJL0pFREVDLyBpbiBwYXRjaCAx OS8xOSwgb3RoZXJ3aXNlIEkgbGlrZSB0aGUgY2xlYW51cCB2ZXJ5IG11Y2ghCj4gPiBDYW4gSSBt b2RpZnkgd2hlbiBhcHBseWluZyBvciB5b3UgcGxhbiB0byBkbyBtb3JlL290aGVyIGNoYW5nZXM/ ICAKPiAKPiBZZXAsIHlvdSBjYW4gZml4K2FwcGx5IHRoZSBzZXJpZXMgaWYgeW91J3JlIGhhcHB5 IHdpdGggaXQuCgpBcHBsaWVkIG9uIG5hbmQvbmV4dCAod2l0aCBmaXhlcykuCgpUaGFua3MsCk1p cXXDqGwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2 ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZl cmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Wed, 19 Sep 2018 21:25:42 +0000 Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Message-Id: <20180919232542.5e8f066e@xps13> List-Id: References: <20180906223851.6964-1-boris.brezillon@bootlin.com> <20180915195440.251fea18@xps13> <20180917102939.3ff716db@bbrezillon> In-Reply-To: <20180917102939.3ff716db@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Marek Vasut , Jonathan Corbet , linux-doc@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap@vger.kernel.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ralf Baechle , linux-mips@linux-mips.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org Hi Boris, Boris Brezillon wrote on Mon, 17 Sep 2018 10:29:39 +0200: > On Sat, 15 Sep 2018 19:54:40 +0200 > Miquel Raynal wrote: >=20 > > Hi Boris, > >=20 > > Boris Brezillon wrote on Fri, 7 Sep 2018 > > 00:38:32 +0200: > > =20 > > > Hello, > > >=20 > > > This is the 2nd batch of API cleanup patches. This time we move > > > deprecated hooks/fields to the nand_legacy struct, and then move some > > > of the code found in nand_base.c into separate source/header files. > > >=20 > > > With this new organization, new comers should more easily identify the > > > bits they can use in their NAND controller drivers and those that are > > > only meant for core code. It also shrink a bit nand_base.c which was > > > over 6000 lines of code. > > >=20 > > > Note that existing coding style issues (reported by checkpatch) in ar= ch > > > or driver code are intentionally not fixed to keep the series focused > > > on the API/core cleanup. > > >=20 > > > Regards, > > >=20 > > > Boris > > >=20 > > > Boris Brezillon (19): > > > mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused > > > mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there > > > mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks > > > mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc() > > > mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc() > > > mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks > > > mtd: rawnand: Deprecate ->erase() > > > mtd: rawnand: Deprecate ->{set,get}_features() hooks > > > mtd: rawnand: Deprecate ->chip_delay > > > mtd: rawnand: Move function prototypes after struct declarations > > > mtd: rawnand: Get rid of nand_flash_dev forward declation > > > mtd: rawnand: Get rid of the duplicate nand_chip forward declaration > > > mtd: rawnand: Get rid of a few unused definitions > > > mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h > > > mtd: rawnand: Inline onfi_get_async_timing_mode() > > > mtd: rawnand: Keep all internal stuff private > > > mtd: rawnand: Move legacy code to nand_legacy.c > > > mtd: rawnand: Move ONFI code to nand_onfi.c > > > mtd: rawnand: Move JEDEC code to nand_jedec.c > > >=20 > > > Documentation/driver-api/mtdnand.rst | 30 +- > > > arch/arm/mach-ep93xx/snappercl15.c | 8 +- > > > arch/arm/mach-ep93xx/ts72xx.c | 9 +- > > > arch/arm/mach-imx/mach-qong.c | 6 +- > > > arch/arm/mach-ixp4xx/ixdp425-setup.c | 2 +- > > > arch/arm/mach-omap1/board-fsample.c | 3 +- > > > arch/arm/mach-omap1/board-h2.c | 3 +- > > > arch/arm/mach-omap1/board-h3.c | 2 +- > > > arch/arm/mach-omap1/board-nand.c | 2 +- > > > arch/arm/mach-omap1/board-perseus2.c | 3 +- > > > arch/arm/mach-orion5x/ts78xx-setup.c | 9 +- > > > arch/arm/mach-pxa/balloon3.c | 5 +- > > > arch/arm/mach-pxa/em-x270.c | 9 +- > > > arch/arm/mach-pxa/palmtx.c | 5 +- > > > arch/mips/alchemy/devboards/db1200.c | 9 +- > > > arch/mips/alchemy/devboards/db1300.c | 9 +- > > > arch/mips/alchemy/devboards/db1550.c | 9 +- > > > arch/mips/netlogic/xlr/platform-flash.c | 3 +- > > > arch/mips/pnx833x/common/platform.c | 5 +- > > > arch/mips/rb532/devices.c | 5 +- > > > arch/sh/boards/mach-migor/setup.c | 8 +- > > > drivers/mtd/nand/raw/Makefile | 4 +- > > > drivers/mtd/nand/raw/ams-delta.c | 22 +- > > > drivers/mtd/nand/raw/atmel/nand-controller.c | 22 +- > > > drivers/mtd/nand/raw/au1550nd.c | 43 +- > > > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 22 +- > > > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 15 +- > > > drivers/mtd/nand/raw/cafe_nand.c | 22 +- > > > drivers/mtd/nand/raw/cmx270_nand.c | 28 +- > > > drivers/mtd/nand/raw/cs553x_nand.c | 42 +- > > > drivers/mtd/nand/raw/davinci_nand.c | 34 +- > > > drivers/mtd/nand/raw/denali.c | 23 +- > > > drivers/mtd/nand/raw/diskonchip.c | 50 +- > > > drivers/mtd/nand/raw/fsl_elbc_nand.c | 18 +- > > > drivers/mtd/nand/raw/fsl_ifc_nand.c | 24 +- > > > drivers/mtd/nand/raw/fsl_upm.c | 30 +- > > > drivers/mtd/nand/raw/fsmc_nand.c | 1 - > > > drivers/mtd/nand/raw/gpio.c | 16 +- > > > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 22 +- > > > drivers/mtd/nand/raw/hisi504_nand.c | 18 +- > > > drivers/mtd/nand/raw/internals.h | 114 ++ > > > drivers/mtd/nand/raw/jz4740_nand.c | 14 +- > > > drivers/mtd/nand/raw/jz4780_nand.c | 10 +- > > > drivers/mtd/nand/raw/lpc32xx_mlc.c | 12 +- > > > drivers/mtd/nand/raw/lpc32xx_slc.c | 26 +- > > > drivers/mtd/nand/raw/mpc5121_nfc.c | 14 +- > > > drivers/mtd/nand/raw/mtk_nand.c | 12 +- > > > drivers/mtd/nand/raw/mxc_nand.c | 20 +- > > > drivers/mtd/nand/raw/nand_amd.c | 2 +- > > > drivers/mtd/nand/raw/nand_base.c | 1260 +++---------= ---------- > > > drivers/mtd/nand/raw/nand_bbt.c | 5 +- > > > drivers/mtd/nand/raw/nand_hynix.c | 9 +- > > > drivers/mtd/nand/raw/nand_ids.c | 4 +- > > > drivers/mtd/nand/raw/nand_jedec.c | 113 ++ > > > drivers/mtd/nand/raw/nand_legacy.c | 642 +++++++++++ > > > drivers/mtd/nand/raw/nand_macronix.c | 2 +- > > > drivers/mtd/nand/raw/nand_micron.c | 3 +- > > > drivers/mtd/nand/raw/nand_onfi.c | 305 ++++++ > > > drivers/mtd/nand/raw/nand_samsung.c | 2 +- > > > drivers/mtd/nand/raw/nand_timings.c | 18 +- > > > drivers/mtd/nand/raw/nand_toshiba.c | 2 +- > > > drivers/mtd/nand/raw/nandsim.c | 14 +- > > > drivers/mtd/nand/raw/ndfc.c | 14 +- > > > drivers/mtd/nand/raw/nuc900_nand.c | 22 +- > > > drivers/mtd/nand/raw/omap2.c | 62 +- > > > drivers/mtd/nand/raw/orion_nand.c | 12 +- > > > drivers/mtd/nand/raw/oxnas_nand.c | 10 +- > > > drivers/mtd/nand/raw/pasemi_nand.c | 32 +- > > > drivers/mtd/nand/raw/plat_nand.c | 17 +- > > > drivers/mtd/nand/raw/qcom_nandc.c | 39 +- > > > drivers/mtd/nand/raw/r852.c | 14 +- > > > drivers/mtd/nand/raw/s3c2410.c | 34 +- > > > drivers/mtd/nand/raw/sh_flctl.c | 18 +- > > > drivers/mtd/nand/raw/sharpsl.c | 12 +- > > > drivers/mtd/nand/raw/sm_common.c | 2 +- > > > drivers/mtd/nand/raw/socrates_nand.c | 16 +- > > > drivers/mtd/nand/raw/sunxi_nand.c | 14 +- > > > drivers/mtd/nand/raw/tango_nand.c | 12 +- > > > drivers/mtd/nand/raw/tmio_nand.c | 20 +- > > > drivers/mtd/nand/raw/txx9ndfmc.c | 12 +- > > > drivers/mtd/nand/raw/xway_nand.c | 12 +- > > > drivers/staging/mt29f_spinand/mt29f_spinand.c | 16 +- > > > include/linux/mtd/jedec.h | 91 ++ > > > include/linux/mtd/onfi.h | 178 +++ > > > include/linux/mtd/platnand.h | 74 ++ > > > include/linux/mtd/rawnand.h | 555 ++-------- > > > 86 files changed, 2300 insertions(+), 2191 deletions(-) > > > create mode 100644 drivers/mtd/nand/raw/internals.h > > > create mode 100644 drivers/mtd/nand/raw/nand_jedec.c > > > create mode 100644 drivers/mtd/nand/raw/nand_legacy.c > > > create mode 100644 drivers/mtd/nand/raw/nand_onfi.c > > > create mode 100644 include/linux/mtd/jedec.h > > > create mode 100644 include/linux/mtd/onfi.h > > > create mode 100644 include/linux/mtd/platnand.h > > > =20 > >=20 > > Series reviewed, there is one typo in patch 2/19 and 16/19 and a > > s/ONFI/JEDEC/ in patch 19/19, otherwise I like the cleanup very much! > > Can I modify when applying or you plan to do more/other changes? =20 >=20 > Yep, you can fix+apply the series if you're happy with it. Applied on nand/next (with fixes). Thanks, Miqu=C3=A8l