From: Christoph Hellwig <hch@lst.de>
To: Jason Yan <yanaijie@huawei.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
john.garry@huawei.com, zhaohongjiang@huawei.com, hare@suse.com,
dan.j.williams@intel.com, jthumshirn@suse.de, hch@lst.de,
huangdaode@hisilicon.com, chenxiang66@hisilicon.com,
miaoxie@huawei.com, Ewan Milne <emilne@redhat.com>,
Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly
Date: Thu, 20 Sep 2018 08:34:09 +0200 [thread overview]
Message-ID: <20180920063409.GE12913@lst.de> (raw)
In-Reply-To: <20180919033204.11102-3-yanaijie@huawei.com>
On Wed, Sep 19, 2018 at 11:32:01AM +0800, Jason Yan wrote:
> We are using lldd_port_deformed so we'd better check if lldd_port_deformed
> is NULL.
>
> After this, we can remove hisi_sas_port_deformed() because it is just a
> stub to avoid a NULL dereference caused by the wrong check.
>
The wording seems a bit odd. I'd do something like:
libsas: make the lldd_port_deformed method optional
... and remove the dummy implementation in hisi_sas.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-09-20 6:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 3:31 [PATCH v2 0/5] scsi: libsas: some code cleanups and bug fixes Jason Yan
2018-09-19 3:31 ` Jason Yan
2018-09-19 3:32 ` [PATCH v2 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c Jason Yan
2018-09-19 3:32 ` Jason Yan
2018-09-19 14:54 ` Johannes Thumshirn
2018-09-20 6:32 ` Christoph Hellwig
2018-09-19 3:32 ` [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly Jason Yan
2018-09-19 3:32 ` Jason Yan
2018-09-19 14:56 ` Johannes Thumshirn
2018-09-20 6:34 ` Christoph Hellwig [this message]
2018-09-19 3:32 ` [PATCH v2 3/5] scsi: libsas: always unregister the old device if going to discover new Jason Yan
2018-09-19 3:32 ` Jason Yan
2018-09-19 3:32 ` [PATCH v2 4/5] scsi: libsas: check the ata device status by ata_dev_enabled() Jason Yan
2018-09-19 3:32 ` Jason Yan
2018-09-19 14:57 ` Johannes Thumshirn
2018-09-20 6:34 ` Christoph Hellwig
2018-09-19 3:32 ` [PATCH v2 5/5] scsi: libsas: fix a race condition when smp task timeout Jason Yan
2018-09-19 3:32 ` Jason Yan
2018-09-19 8:42 ` John Garry
2018-09-19 8:42 ` John Garry
2018-09-19 14:57 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920063409.GE12913@lst.de \
--to=hch@lst.de \
--cc=chenxiang66@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=huangdaode@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=thenzl@redhat.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.