From: Phil Sutter <phil@nwl.cc>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH iproute2 v2 0/3] testsuite: make alltests fixes
Date: Thu, 20 Sep 2018 10:02:20 +0200 [thread overview]
Message-ID: <20180920080220.GF14666@orbyte.nwl.cc> (raw)
In-Reply-To: <20180919233624.18494-1-petr.vorel@gmail.com>
Hi Petr,
On Thu, Sep 20, 2018 at 01:36:21AM +0200, Petr Vorel wrote:
> here are simply fixes to restore 'make alltests'.
> Currently it does not run.
Yeah, that testsuite definitely deserves some love.
Just one nit: The one-line summary in Fixes: tags should be enclosed in
quotes and parens, e.g.:
| Fixes: deadbeef ("foo bar")
Cheers, Phil
next prev parent reply other threads:[~2018-09-20 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 23:36 [PATCH iproute2 v2 0/3] testsuite: make alltests fixes Petr Vorel
2018-09-19 23:36 ` [PATCH iproute2 v2 1/3] testsuite: Fix missing generate_nlmsg Petr Vorel
2018-09-19 23:36 ` [PATCH iproute2 v2 2/3] testsuite: Generate generate_nlmsg when needed Petr Vorel
2018-09-19 23:36 ` [PATCH iproute2 v2 3/3] testsuite: Warn about empty $(IPVERS) Petr Vorel
2018-09-20 8:02 ` Phil Sutter [this message]
2018-09-20 10:02 ` [PATCH iproute2 v2 0/3] testsuite: make alltests fixes Luca Boccassi
2018-09-21 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920080220.GF14666@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.