From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Simon Wunderlich <sw@simonwunderlich.de>
Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net,
Simon Wunderlich <sw@simonwunderlich.de>,
Eliad Peller <eliad@wizery.com>
Subject: Re: [PATCH] mac80211: allow scans on radar channels, unless there is CAC or CSA
Date: Thu, 20 Sep 2018 12:20:14 +0300 [thread overview]
Message-ID: <20180920092014.ajgykw7o7p73grfj@mwanda> (raw)
In-Reply-To: <20180918141633.10282-1-sw@simonwunderlich.de>
Hi Simon,
I love your patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Simon-Wunderlich/mac80211-allow-scans-on-radar-channels-unless-there-is-CAC-or-CSA/20180919-071924
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
New smatch warnings:
net/mac80211/scan.c:508 ieee80211_can_scan() warn: signedness bug returning '(-16)'
Old smatch warnings:
net/mac80211/scan.c:511 ieee80211_can_scan() warn: signedness bug returning '(-16)'
# https://github.com/0day-ci/linux/commit/ad9617f275c425ddf25eb83678062ab87d4c0870
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout ad9617f275c425ddf25eb83678062ab87d4c0870
vim +508 net/mac80211/scan.c
f3b85252 Johannes Berg 2009-04-23 503
133d40f9 Stanislaw Gruszka 2012-03-28 504 static bool ieee80211_can_scan(struct ieee80211_local *local,
^^^^
133d40f9 Stanislaw Gruszka 2012-03-28 505 struct ieee80211_sub_if_data *sdata)
133d40f9 Stanislaw Gruszka 2012-03-28 506 {
ad9617f2 Simon Wunderlich 2018-09-18 507 if (sdata->wdev.cac_started)
ad9617f2 Simon Wunderlich 2018-09-18 @508 return -EBUSY;
^^^^^^^^^^^^^
ad9617f2 Simon Wunderlich 2018-09-18 509
ad9617f2 Simon Wunderlich 2018-09-18 510 if (sdata->vif.csa_active)
ad9617f2 Simon Wunderlich 2018-09-18 511 return -EBUSY;
^^^^^^^^^^^^^^
164eb02d Simon Wunderlich 2013-02-08 512
2eb278e0 Johannes Berg 2012-06-05 513 if (!list_empty(&local->roc_list))
133d40f9 Stanislaw Gruszka 2012-03-28 514 return false;
133d40f9 Stanislaw Gruszka 2012-03-28 515
133d40f9 Stanislaw Gruszka 2012-03-28 516 if (sdata->vif.type == NL80211_IFTYPE_STATION &&
392b9ffb Stanislaw Gruszka 2013-08-27 517 sdata->u.mgd.flags & IEEE80211_STA_CONNECTION_POLL)
133d40f9 Stanislaw Gruszka 2012-03-28 518 return false;
133d40f9 Stanislaw Gruszka 2012-03-28 519
133d40f9 Stanislaw Gruszka 2012-03-28 520 return true;
133d40f9 Stanislaw Gruszka 2012-03-28 521 }
133d40f9 Stanislaw Gruszka 2012-03-28 522
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-09-20 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 14:16 [PATCH] mac80211: allow scans on radar channels, unless there is CAC or CSA Simon Wunderlich
2018-09-20 9:20 ` Dan Carpenter [this message]
2018-09-20 13:30 ` Simon Wunderlich
2018-09-20 13:40 ` Dan Carpenter
2018-09-20 9:21 ` Johannes Berg
2018-09-20 10:27 ` Simon Wunderlich
2019-03-29 10:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920092014.ajgykw7o7p73grfj@mwanda \
--to=dan.carpenter@oracle.com \
--cc=eliad@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.