From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] kernel-shark-qt: Add Plugin event handlers to session.
Date: Thu, 20 Sep 2018 09:48:32 -0400 [thread overview]
Message-ID: <20180920094832.7e3a0cfb@gandalf.local.home> (raw)
In-Reply-To: <e79dde81-68a4-4310-348d-a7da677a5d4d@gmail.com>
On Thu, 20 Sep 2018 16:26:11 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> On 20.09.2018 06:24, Steven Rostedt wrote:
> >> /** Special mask used whene filtering events. */
> >> KS_EVENT_VIEW_FILTER_MASK = 1 << 2,
> >> +
> >> + /**
> >> + * Use this mask to check if the content of the entry has been accessed
> >> + * by a plugin-defined function.
> >> + */
> >> + KS_PLUGIN_UNTOUCHED_MASK = 1 << 7
> > Why the jump to 7?
>
> The "visible" field of the entry will use 8 bits. I know that it is
> uint16_t now, but my plan is to use 8 of its bits for the stream_id field.
>
> Currently we use the first 3 bits as different visibility flags and we
> have 4 unused bits available for adding more visibility flags in the
> future. Because the PLUGIN_UNTOUCHED flag has a different meaning I
> decided to place it at the very end.
>
> Is this a problem?
No, it just seems out of place. Can you add a comment after the
VIEW_FILTER_MASK stating that the next 4 bits are reserved for more
VIEW bits.
-- Steve
next prev parent reply other threads:[~2018-09-20 19:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:36 [PATCH v4 0/7] Add infrastructure for plugins Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS Yordan Karadzhov (VMware)
2018-09-20 3:13 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 2/7] kernel-shark-qt: Add Plugin event handlers to session Yordan Karadzhov (VMware)
2018-09-20 3:24 ` Steven Rostedt
2018-09-20 13:26 ` Yordan Karadzhov (VMware)
2018-09-20 13:48 ` Steven Rostedt [this message]
2018-09-20 13:29 ` Yordan Karadzhov (VMware)
2018-09-20 13:49 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 3/7] kernel-shark-qt: Add C++/C conversion for args of a plugin draw function Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 4/7] kernel-shark-qt: Make kshark_read_at() non-static Yordan Karadzhov (VMware)
2018-09-20 3:29 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 5/7] kernel-shark-qt: Add src/plugins dir. to hold the source code of the plugins Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 6/7] kernel-shark-qt: Tell Doxygen to enter ../src/plugins/ Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 7/7] kernel-shark-qt: Add a plugin for sched events Yordan Karadzhov (VMware)
2018-09-20 4:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920094832.7e3a0cfb@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.