From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] usb: typec: mux: Take care of driver module reference counting From: Greg Kroah-Hartman Message-Id: <20180920112003.GA12655@kroah.com> Date: Thu, 20 Sep 2018 13:20:03 +0200 To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gV2VkLCBTZXAgMTksIDIwMTggYXQgMTA6NTg6MDRBTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IEZ1bmN0aW9ucyB0eXBlY19tdXhfZ2V0KCkgYW5kIHR5cGVjX3N3aXRjaF9nZXQo KSBhbHJlYWR5Cj4gbWFrZSBzdXJlIHRoYXQgdGhlIG11eCBkZXZpY2UgcmVmZXJlbmNlIGNvdW50 IGlzCj4gaW5jcmVtZW50ZWQsIGJ1dCB0aGUgc2FtZSBtdXN0IGJlIGRvbmUgdG8gdGhlIGRyaXZl ciBtb2R1bGUKPiBhcyB3ZWxsIHRvIHByZXZlbnQgdGhlIGRyaXZlcnMgZnJvbSBiZWluZyB1bmxv YWRlZCBpbiB0aGUKPiBtaWRkbGUgb2Ygb3BlcmF0aW9uLgo+IAo+IFRoaXMgZml4ZXMgYSBwb3Rl bnRpYWwgIkJVRzogdW5hYmxlIHRvIGhhbmRsZSBrZXJuZWwgcGFnaW5nCj4gcmVxdWVzdCBhdCAu Li4iIGZyb20gaGFwcGVuaW5nLgo+IAo+IEZpeGVzOiA5M2RkMjExMmM3YjIgKCJ1c2I6IHR5cGVj OiBtdXg6IEdldCB0aGUgbXV4IGlkZW50aWZpZXIgZnJvbSBmdW5jdGlvbiBwYXJhbWV0ZXIiKQo+ IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KCldoeSBpcyB0aGlzIGZsYWdnZWQgZm9yIHN0 YWJsZT8gOTNkZDIxMTJjN2IyIHdlbnQgaW50byA0LjE5LXJjMSBhbmQgaGFzCm5vdCBiZWVuIGJh Y2twb3J0ZWQgYW55d2hlcmUgZWxzZS4KCmNvbmZ1c2VkLAoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732640AbeITRDH (ORCPT ); Thu, 20 Sep 2018 13:03:07 -0400 Date: Thu, 20 Sep 2018 13:20:03 +0200 From: Greg KH To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting Message-ID: <20180920112003.GA12655@kroah.com> References: <20180919075805.61319-1-heikki.krogerus@linux.intel.com> <20180919075805.61319-2-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919075805.61319-2-heikki.krogerus@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote: > Functions typec_mux_get() and typec_switch_get() already > make sure that the mux device reference count is > incremented, but the same must be done to the driver module > as well to prevent the drivers from being unloaded in the > middle of operation. > > This fixes a potential "BUG: unable to handle kernel paging > request at ..." from happening. > > Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter") > Cc: Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has not been backported anywhere else. confused, greg k-h