From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] usb: typec: mux: Take care of driver module reference counting From: Heikki Krogerus Message-Id: <20180920112628.GE11965@kuha.fi.intel.com> Date: Thu, 20 Sep 2018 14:26:28 +0300 To: Greg KH Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMDE6MjA6MDNQTSArMDIwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBXZWQsIFNlcCAxOSwgMjAxOCBhdCAxMDo1ODowNEFNICswMzAwLCBIZWlra2kgS3JvZ2Vy dXMgd3JvdGU6Cj4gPiBGdW5jdGlvbnMgdHlwZWNfbXV4X2dldCgpIGFuZCB0eXBlY19zd2l0Y2hf Z2V0KCkgYWxyZWFkeQo+ID4gbWFrZSBzdXJlIHRoYXQgdGhlIG11eCBkZXZpY2UgcmVmZXJlbmNl IGNvdW50IGlzCj4gPiBpbmNyZW1lbnRlZCwgYnV0IHRoZSBzYW1lIG11c3QgYmUgZG9uZSB0byB0 aGUgZHJpdmVyIG1vZHVsZQo+ID4gYXMgd2VsbCB0byBwcmV2ZW50IHRoZSBkcml2ZXJzIGZyb20g YmVpbmcgdW5sb2FkZWQgaW4gdGhlCj4gPiBtaWRkbGUgb2Ygb3BlcmF0aW9uLgo+ID4gCj4gPiBU aGlzIGZpeGVzIGEgcG90ZW50aWFsICJCVUc6IHVuYWJsZSB0byBoYW5kbGUga2VybmVsIHBhZ2lu Zwo+ID4gcmVxdWVzdCBhdCAuLi4iIGZyb20gaGFwcGVuaW5nLgo+ID4gCj4gPiBGaXhlczogOTNk ZDIxMTJjN2IyICgidXNiOiB0eXBlYzogbXV4OiBHZXQgdGhlIG11eCBpZGVudGlmaWVyIGZyb20g ZnVuY3Rpb24gcGFyYW1ldGVyIikKPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiAK PiBXaHkgaXMgdGhpcyBmbGFnZ2VkIGZvciBzdGFibGU/IDkzZGQyMTEyYzdiMiB3ZW50IGludG8g NC4xOS1yYzEgYW5kIGhhcwo+IG5vdCBiZWVuIGJhY2twb3J0ZWQgYW55d2hlcmUgZWxzZS4KPiAK PiBjb25mdXNlZCwKClNvcnJ5LCBpdCBzaG91bGQgbm90IGhhdmUgdGhlIHN0YWJsZSB0YWcuIFNo YWxsIEkgcmVzZW5kIHRoZXNlPwoKVGhhbmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com ([192.55.52.136]:65360 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITRJd (ORCPT ); Thu, 20 Sep 2018 13:09:33 -0400 Date: Thu, 20 Sep 2018 14:26:28 +0300 From: Heikki Krogerus To: Greg KH Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting Message-ID: <20180920112628.GE11965@kuha.fi.intel.com> References: <20180919075805.61319-1-heikki.krogerus@linux.intel.com> <20180919075805.61319-2-heikki.krogerus@linux.intel.com> <20180920112003.GA12655@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180920112003.GA12655@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote: > On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote: > > Functions typec_mux_get() and typec_switch_get() already > > make sure that the mux device reference count is > > incremented, but the same must be done to the driver module > > as well to prevent the drivers from being unloaded in the > > middle of operation. > > > > This fixes a potential "BUG: unable to handle kernel paging > > request at ..." from happening. > > > > Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter") > > Cc: > > Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has > not been backported anywhere else. > > confused, Sorry, it should not have the stable tag. Shall I resend these? Thanks, -- heikki