From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] usb: typec: mux: Take care of driver module reference counting From: Greg Kroah-Hartman Message-Id: <20180920113452.GA25571@kroah.com> Date: Thu, 20 Sep 2018 13:34:52 +0200 To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMDI6MjY6MjhQTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IE9uIFRodSwgU2VwIDIwLCAyMDE4IGF0IDAxOjIwOjAzUE0gKzAyMDAsIEdyZWcg S0ggd3JvdGU6Cj4gPiBPbiBXZWQsIFNlcCAxOSwgMjAxOCBhdCAxMDo1ODowNEFNICswMzAwLCBI ZWlra2kgS3JvZ2VydXMgd3JvdGU6Cj4gPiA+IEZ1bmN0aW9ucyB0eXBlY19tdXhfZ2V0KCkgYW5k IHR5cGVjX3N3aXRjaF9nZXQoKSBhbHJlYWR5Cj4gPiA+IG1ha2Ugc3VyZSB0aGF0IHRoZSBtdXgg ZGV2aWNlIHJlZmVyZW5jZSBjb3VudCBpcwo+ID4gPiBpbmNyZW1lbnRlZCwgYnV0IHRoZSBzYW1l IG11c3QgYmUgZG9uZSB0byB0aGUgZHJpdmVyIG1vZHVsZQo+ID4gPiBhcyB3ZWxsIHRvIHByZXZl bnQgdGhlIGRyaXZlcnMgZnJvbSBiZWluZyB1bmxvYWRlZCBpbiB0aGUKPiA+ID4gbWlkZGxlIG9m IG9wZXJhdGlvbi4KPiA+ID4gCj4gPiA+IFRoaXMgZml4ZXMgYSBwb3RlbnRpYWwgIkJVRzogdW5h YmxlIHRvIGhhbmRsZSBrZXJuZWwgcGFnaW5nCj4gPiA+IHJlcXVlc3QgYXQgLi4uIiBmcm9tIGhh cHBlbmluZy4KPiA+ID4gCj4gPiA+IEZpeGVzOiA5M2RkMjExMmM3YjIgKCJ1c2I6IHR5cGVjOiBt dXg6IEdldCB0aGUgbXV4IGlkZW50aWZpZXIgZnJvbSBmdW5jdGlvbiBwYXJhbWV0ZXIiKQo+ID4g PiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Cj4gPiAKPiA+IFdoeSBpcyB0aGlzIGZsYWdn ZWQgZm9yIHN0YWJsZT8gOTNkZDIxMTJjN2IyIHdlbnQgaW50byA0LjE5LXJjMSBhbmQgaGFzCj4g PiBub3QgYmVlbiBiYWNrcG9ydGVkIGFueXdoZXJlIGVsc2UuCj4gPiAKPiA+IGNvbmZ1c2VkLAo+ IAo+IFNvcnJ5LCBpdCBzaG91bGQgbm90IGhhdmUgdGhlIHN0YWJsZSB0YWcuIFNoYWxsIEkgcmVz ZW5kIHRoZXNlPwoKTm8gbmVlZCwgSSdsbCBoYW5kbGUgaXQsIHRoYW5rcy4KCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57762 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727029AbeITRR7 (ORCPT ); Thu, 20 Sep 2018 13:17:59 -0400 Date: Thu, 20 Sep 2018 13:34:52 +0200 From: Greg KH To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting Message-ID: <20180920113452.GA25571@kroah.com> References: <20180919075805.61319-1-heikki.krogerus@linux.intel.com> <20180919075805.61319-2-heikki.krogerus@linux.intel.com> <20180920112003.GA12655@kroah.com> <20180920112628.GE11965@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180920112628.GE11965@kuha.fi.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Sep 20, 2018 at 02:26:28PM +0300, Heikki Krogerus wrote: > On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote: > > On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote: > > > Functions typec_mux_get() and typec_switch_get() already > > > make sure that the mux device reference count is > > > incremented, but the same must be done to the driver module > > > as well to prevent the drivers from being unloaded in the > > > middle of operation. > > > > > > This fixes a potential "BUG: unable to handle kernel paging > > > request at ..." from happening. > > > > > > Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter") > > > Cc: > > > > Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has > > not been backported anywhere else. > > > > confused, > > Sorry, it should not have the stable tag. Shall I resend these? No need, I'll handle it, thanks. greg k-h