All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <billodo@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfsprogs: define xfs_stack_trace() for debug builds
Date: Thu, 20 Sep 2018 07:42:52 -0500	[thread overview]
Message-ID: <20180920124252.GA745@redhat.com> (raw)
In-Reply-To: <d260b935-c518-1fdb-c728-84db5a1224a8@redhat.com>

On Wed, Sep 19, 2018 at 03:19:14PM -0500, Eric Sandeen wrote:
> Building with -DDEBUG fails due to lack of an xfs_stack_trace def'n.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
> index 2f2ca06..b6746ca 100644
> --- a/libxfs/libxfs_priv.h
> +++ b/libxfs/libxfs_priv.h
> @@ -118,6 +118,8 @@ enum ce { CE_DEBUG, CE_CONT, CE_NOTE, CE_WARN, CE_ALERT, CE_PANIC };
>  #define xfs_alert_tag(mp,tag,fmt,args...)	cmn_err(CE_ALERT,fmt, ## args)
>  
>  #define xfs_hex_dump(d,n)		((void) 0)
> +#define xfs_stack_trace()		((void) 0)
> +
>  
>  #define xfs_force_shutdown(d,n)		((void) 0)
>  
> 

      reply	other threads:[~2018-09-20 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 20:19 [PATCH] xfsprogs: define xfs_stack_trace() for debug builds Eric Sandeen
2018-09-20 12:42 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920124252.GA745@redhat.com \
    --to=billodo@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.