From: Segher Boessenkool <segher@kernel.crashing.org>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org, maddy@linux.ibm.com, paulus@samba.org
Subject: Re: [PATCH] powerpc/perf: Add missing break in power7_marked_instr_event()
Date: Thu, 20 Sep 2018 09:47:15 -0500 [thread overview]
Message-ID: <20180920144715.GA23155@gate.crashing.org> (raw)
In-Reply-To: <e1868207-7dd4-e6cc-0fce-04e0fd1e5edc@linux.vnet.ibm.com>
On Thu, Sep 20, 2018 at 03:29:22PM +0530, Madhavan Srinivasan wrote:
> On Thursday 20 September 2018 03:11 PM, Michael Ellerman wrote:
> >In power7_marked_instr_event() there is a switch case that is missing
> >a break or an explicit fallthrough, it's not immediately clear which
> >it should be.
> Just curious to know, how did you find this. Static code checker compiled
> or any specific compiler warnings or just by code read?
Newer GCC warns about suspicious fallthroughs (-Wimplicit-fallthrough,
which is in -Wextra).
Segher
next prev parent reply other threads:[~2018-09-20 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 9:41 [PATCH] powerpc/perf: Add missing break in power7_marked_instr_event() Michael Ellerman
2018-09-20 9:59 ` Madhavan Srinivasan
2018-09-20 14:47 ` Segher Boessenkool [this message]
2018-09-24 7:03 ` Michael Ellerman
2018-09-24 7:05 ` Madhavan Srinivasan
2018-10-04 6:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920144715.GA23155@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.