From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 0/6] nvme-cli: fixup large log page transfer
Date: Thu, 20 Sep 2018 09:22:08 -0600 [thread overview]
Message-ID: <20180920152207.GB30677@localhost.localdomain> (raw)
In-Reply-To: <20180920090939.6348-1-hare@suse.de>
On Thu, Sep 20, 2018@11:09:33AM +0200, Hannes Reinecke wrote:
> Hi all,
>
> on large installations the MDTS value might prevent the controller to
> transfer the entire log page in one go. This patchset updates nvme_get_log()
> to retrieve the log page in 4k chunks so as having to avoid checking the
> MDTS value.
That looks good. Shoudn't matter for most pages since only a few may
exceed 4k.
> I've also added an 'rae' field to nvme_get_log() to avoid it accidentally
> clearing outstanding AENs.
Thanks for setting that up!
> And the seagate plugin has been cleaned up :-)
I think that code must have been ported from an internal project. :)
> As usual, comments and reviews are welcome.
Looks good to me. Patches applied.
prev parent reply other threads:[~2018-09-20 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 9:09 [PATCH 0/6] nvme-cli: fixup large log page transfer Hannes Reinecke
2018-09-20 9:09 ` [PATCH 1/6] nvme-discover: Retry discovery log if the generation counter changes Hannes Reinecke
2018-09-20 9:09 ` [PATCH 2/6] nvme-ioctl: retrieve log pages in 4k chunks Hannes Reinecke
2018-09-20 9:09 ` [PATCH 3/6] nvme-discover: Re-check generation counter after log page transfer Hannes Reinecke
2018-09-20 9:09 ` [PATCH 4/6] seagate-nvme: fixup coding style Hannes Reinecke
2018-09-20 9:09 ` [PATCH 5/6] nvme-cli: Add 'rae' argument to nvme_get_log() Hannes Reinecke
2018-09-20 9:09 ` [PATCH 6/6] nvme-cli: kill nvme_passthru_admin() Hannes Reinecke
2018-09-20 15:22 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920152207.GB30677@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.