All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seebs <seebs@seebs.net>
To: <Jack.Fewx@dell.com>
Cc: yocto@yoctoproject.org
Subject: Re: [pseudo] Pseudo 1.8+ xattr sqlite corruption
Date: Thu, 20 Sep 2018 15:46:56 -0500	[thread overview]
Message-ID: <20180920154656.6dc19bc3@seebsdell> (raw)
In-Reply-To: <7fa6c890755b4712828365593fcfe088@AUSX13MPC104.AMER.DELL.COM>

On Thu, 20 Sep 2018 20:41:02 +0000
<Jack.Fewx@dell.com> wrote:

> Okay, so I found the problem, and I have a patch for it.  Throughout
> the pseudo_db.c code, the handling of the msg->ino objects is not
> consistent.  Many get passed to the sqlite3_bind_int64 function, but
> NOT ALL.  9 instances in the code, including all of them in the xattr
> code use only sqlite3_bind_int which truncates the integers to signed
> 32-bits.

D'oh. I should have noticed that since I was looking at the code.

Thanks, that's a very good fix.

-s


  reply	other threads:[~2018-09-20 20:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 18:45 [pseudo] Pseudo 1.8+ xattr sqlite corruption Jack.Fewx
2018-08-22  8:41 ` Alexander Kanavin
2018-08-22 13:58   ` Jack.Fewx
2018-08-22 14:41     ` Joshua Watt
2018-08-22 14:54       ` Jack.Fewx
2018-08-22 15:09         ` Richard Purdie
2018-08-22 15:32           ` Jack.Fewx
2018-09-18 20:26           ` Jack.Fewx
2018-09-18 21:09             ` Seebs
2018-09-18 21:16               ` Joshua Watt
2018-09-18 21:20                 ` Seebs
2018-09-19 11:33                   ` Burton, Ross
2018-09-19 14:39                     ` Seebs
2018-09-19 16:25                       ` Jack.Fewx
2018-09-20 19:16                     ` Seebs
2018-09-20 20:41                       ` Jack.Fewx
2018-09-20 20:46                         ` Seebs [this message]
2018-09-20 20:50                         ` Seebs
2018-09-21 12:50                           ` Burton, Ross
2018-09-23 13:23                             ` Martin Jansa
2018-08-22 16:41         ` Seebs
2018-08-22 14:44     ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920154656.6dc19bc3@seebsdell \
    --to=seebs@seebs.net \
    --cc=Jack.Fewx@dell.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.