All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: zhong jiang <zhongjiang@huawei.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: remove redundant continue
Date: Thu, 20 Sep 2018 10:30:45 -0700	[thread overview]
Message-ID: <20180920173045.GA15272@roeck-us.net> (raw)
In-Reply-To: <1537431070-38261-1-git-send-email-zhongjiang@huawei.com>

On Thu, Sep 20, 2018 at 04:11:10PM +0800, zhong jiang wrote:
> The continue will not truely skip any code. hence it is safe to
> remove it.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

The proper subject line would be

hwmon: (scpi-hwmon) <summary>

Since it now happened several times that I got a patch without proper
subject (ie where the subject does not even mention the affected driver),
I am no longer going to accept patches if the affected driver is missing,
sorry.

Guenter

> ---
>  drivers/hwmon/scpi-hwmon.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
> index 7e49da5..111d521 100644
> --- a/drivers/hwmon/scpi-hwmon.c
> +++ b/drivers/hwmon/scpi-hwmon.c
> @@ -286,10 +286,8 @@ static int scpi_hwmon_probe(struct platform_device *pdev)
>  		 * any thermal zones or if the thermal subsystem is
>  		 * not configured.
>  		 */
> -		if (IS_ERR(z)) {
> +		if (IS_ERR(z))
>  			devm_kfree(dev, zone);
> -			continue;
> -		}
>  	}
>  
>  	return 0;
> -- 
> 1.7.12.4
> 

  reply	other threads:[~2018-09-20 23:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20  8:11 [PATCH] hwmon: remove redundant continue zhong jiang
2018-09-20 17:30 ` Guenter Roeck [this message]
2018-09-21  1:38   ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920173045.GA15272@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.