All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Eric Engestrom <eric.engestrom@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm] omap: fix symbol annotations
Date: Thu, 20 Sep 2018 11:08:18 -0700	[thread overview]
Message-ID: <20180920180818.GD13507@ldmartin-desk.jf.intel.com> (raw)
In-Reply-To: <20180920172913.10337-1-eric.engestrom@intel.com>

On Thu, Sep 20, 2018 at 06:29:13PM +0100, Eric Engestrom wrote:
> Fixes: f3f7266d94e0354bfd97 "omap: annotate public functions"
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

> ---
>  omap/omap_drm.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/omap/omap_drm.c b/omap/omap_drm.c
> index 3136e04e4170ac3bb94d..3aed4e0a2f65a9aec6f5 100644
> --- a/omap/omap_drm.c
> +++ b/omap/omap_drm.c
> @@ -128,8 +128,8 @@ drm_public void omap_device_del(struct omap_device *dev)
>  	free(dev);
>  }
>  
> -int
> -drm_public omap_get_param(struct omap_device *dev, uint64_t param, uint64_t *value)
> +drm_public int
> +omap_get_param(struct omap_device *dev, uint64_t param, uint64_t *value)
>  {
>  	struct drm_omap_param req = {
>  			.param = param,
> @@ -146,8 +146,8 @@ drm_public omap_get_param(struct omap_device *dev, uint64_t param, uint64_t *val
>  	return 0;
>  }
>  
> -int
> -drm_public omap_set_param(struct omap_device *dev, uint64_t param, uint64_t value)
> +drm_public int
> +omap_set_param(struct omap_device *dev, uint64_t param, uint64_t value)
>  {
>  	struct drm_omap_param req = {
>  			.param = param,
> @@ -226,8 +226,8 @@ static struct omap_bo * omap_bo_new_impl(struct omap_device *dev,
>  
>  
>  /* allocate a new (un-tiled) buffer object */
> -struct omap_bo *
> -drm_public omap_bo_new(struct omap_device *dev, uint32_t size, uint32_t flags)
> +drm_public struct omap_bo *
> +omap_bo_new(struct omap_device *dev, uint32_t size, uint32_t flags)
>  {
>  	union omap_gem_size gsize = {
>  			.bytes = size,
> @@ -239,8 +239,8 @@ drm_public omap_bo_new(struct omap_device *dev, uint32_t size, uint32_t flags)
>  }
>  
>  /* allocate a new buffer object */
> -struct omap_bo *
> -drm_public omap_bo_new_tiled(struct omap_device *dev, uint32_t width,
> +drm_public struct omap_bo *
> +omap_bo_new_tiled(struct omap_device *dev, uint32_t width,
>  		  uint32_t height, uint32_t flags)
>  {
>  	union omap_gem_size gsize = {
> @@ -281,8 +281,8 @@ static int get_buffer_info(struct omap_bo *bo)
>  }
>  
>  /* import a buffer object from DRI2 name */
> -struct omap_bo *
> -drm_public omap_bo_from_name(struct omap_device *dev, uint32_t name)
> +drm_public struct omap_bo *
> +omap_bo_from_name(struct omap_device *dev, uint32_t name)
>  {
>  	struct omap_bo *bo = NULL;
>  	struct drm_gem_open req = {
> @@ -315,8 +315,8 @@ drm_public omap_bo_from_name(struct omap_device *dev, uint32_t name)
>   * fd so caller should close() the fd when it is otherwise done
>   * with it (even if it is still using the 'struct omap_bo *')
>   */
> -struct omap_bo *
> -drm_public omap_bo_from_dmabuf(struct omap_device *dev, int fd)
> +drm_public struct omap_bo *
> +omap_bo_from_dmabuf(struct omap_device *dev, int fd)
>  {
>  	struct omap_bo *bo = NULL;
>  	struct drm_prime_handle req = {
> -- 
> Cheers,
>   Eric
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-09-20 18:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 15:58 [PATCH libdrm 1/3] intel: add missing drm_public exports Eric Engestrom
2018-09-20 15:58 ` [PATCH libdrm 2/3] nouveau: " Eric Engestrom
2018-09-20 17:14   ` Dylan Baker
2018-09-20 15:58 ` [PATCH libdrm 3/3] radeon: " Eric Engestrom
2018-09-20 16:09   ` Michel Dänzer
2018-09-20 17:21     ` Eric Engestrom
2018-09-20 18:31       ` Eric Engestrom
2018-09-21  7:48         ` Michel Dänzer
2018-09-20 16:46 ` [PATCH libdrm 1/3] intel: " Lucas De Marchi
2018-09-20 17:12   ` Eric Engestrom
2018-09-20 17:29     ` Eric Engestrom
2018-09-20 17:29       ` [PATCH libdrm] omap: fix symbol annotations Eric Engestrom
2018-09-20 18:08         ` Lucas De Marchi [this message]
2018-09-20 17:58     ` [PATCH libdrm 1/3] intel: add missing drm_public exports Lucas De Marchi
2018-09-20 18:12     ` Lucas De Marchi
2018-09-20 18:30       ` Eric Engestrom
2018-09-20 17:09 ` Dylan Baker
2018-09-20 17:30 ` Emil Velikov
2018-09-20 17:39   ` Eric Engestrom
2018-09-20 17:50   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920180818.GD13507@ldmartin-desk.jf.intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.