From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: RFC/error: Re: [PATCH 3/6] perf tools: Improve thread_stack__event() for trace begin / end
Date: Thu, 20 Sep 2018 15:18:54 -0300 [thread overview]
Message-ID: <20180920181854.GB9919@kernel.org> (raw)
In-Reply-To: <20180920181352.GA9919@kernel.org>
Em Thu, Sep 20, 2018 at 03:13:52PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Sep 19, 2018 at 02:23:35PM +0300, Adrian Hunter escreveu:
> > + return thread_stack__push(thread->ts, ret_addr,
> > + flags && PERF_IP_FLAG_TRACE_END);
> > + } else if (flags & PERF_IP_FLAG_TRACE_BEGIN) {
>
> Some of the build containers caught this:
>
> util/thread-stack.c:274:14: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
> flags && PERF_IP_FLAG_TRACE_END);
> ^ ~~~~~~~~~~~~~~~~~~~~~~
> util/thread-stack.c:274:14: note: use '&' for a bitwise operation
> flags && PERF_IP_FLAG_TRACE_END);
> ^~
> &
> util/thread-stack.c:274:14: note: remove constant to silence this warning
> flags && PERF_IP_FLAG_TRACE_END);
> ~^~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
>
> --------------------------
>
> Should be a '&' as suggested by:
>
> 16 146.45 debian:9 : FAIL gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
> 17 138.35 debian:experimental : FAIL gcc (Debian 8.2.0-4) 8.2.0
Ok, the compilers that caught this was:
debian:9: clang version 3.8.1-24 (tags/RELEASE_381/final)
debian:experimental: clang version 6.0.1-6 (tags/RELEASE_601/final)
Those gcc versions (6.3 and 8.2) compiled it without warnings.
- Arnaldo
>
> I'm changing this here, please Ack.
>
> - Arnaldo
next prev parent reply other threads:[~2018-09-20 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 11:23 [PATCH 0/6] perf intel-pt: Improve the data displayed when using address filters Adrian Hunter
2018-09-19 11:23 ` [PATCH 1/6] perf script: Enhance sample flags for trace begin / end Adrian Hunter
2018-09-19 18:45 ` Arnaldo Carvalho de Melo
2018-09-19 18:48 ` Arnaldo Carvalho de Melo
2018-09-19 11:23 ` [PATCH 2/6] perf db-export: Add trace begin / end branch type variants Adrian Hunter
2018-09-19 11:23 ` [PATCH 3/6] perf tools: Improve thread_stack__event() for trace begin / end Adrian Hunter
2018-09-20 18:13 ` RFC/error: " Arnaldo Carvalho de Melo
2018-09-20 18:18 ` Arnaldo Carvalho de Melo [this message]
2018-09-21 8:55 ` Adrian Hunter
2018-09-19 11:23 ` [PATCH 4/6] perf tools: Improve thread_stack__process() " Adrian Hunter
2018-09-19 11:23 ` [PATCH 5/6] perf intel-pt: Add decoder flags " Adrian Hunter
2018-09-19 11:23 ` [PATCH 6/6] perf intel-pt: Implement " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920181854.GB9919@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.