All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libv4l: fix build with glibc 2.28
Date: Thu, 20 Sep 2018 21:27:48 +0200	[thread overview]
Message-ID: <20180920212748.2bc0b59a@windsurf> (raw)
In-Reply-To: <7acb964ef43990041ffde9bf8477122943a1c5aa.1537386923.git.baruch@tkos.co.il>

Hello,

On Wed, 19 Sep 2018 22:55:23 +0300, Baruch Siach wrote:
> Add two upstream patches adding the needed header for the major/minor
> macros.
> 
> Fixes:
> http://autobuild.buildroot.net/results/f38/f3858970c1bbb7b0201389f7656c9ccf15a59fda/
> 
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

I've applied, but I have one request, see below.


> diff --git a/package/libv4l/0006-fix-glibc-2.28-build.patch b/package/libv4l/0006-fix-glibc-2.28-build.patch
> new file mode 100644
> index 000000000000..295c0bb54525
> --- /dev/null
> +++ b/package/libv4l/0006-fix-glibc-2.28-build.patch
> @@ -0,0 +1,23 @@
> +v4l2-ctl: fix glibc 2.28 build
> +
> +Include header needed for the major/minor macros in glibc 2.28+.
> +
> +This patch is extracted from upstream commit 65e7b2a4076845d (v4l2-ctl: show
> +media/entity info if available).
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>

This patch should have been Git-formatted, just like the other 5
patches that already existed in libv4l. I fixed that up when applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-09-20 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 19:55 [Buildroot] [PATCH] libv4l: fix build with glibc 2.28 Baruch Siach
2018-09-20 19:27 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920212748.2bc0b59a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.