From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] check-package: detect the use of ${} in .mk files
Date: Fri, 21 Sep 2018 00:06:11 +0200 [thread overview]
Message-ID: <20180921000611.055be497@windsurf> (raw)
In-Reply-To: <20180709015647.6619-1-ricardo.martincoski@gmail.com>
Hello,
On Sun, 8 Jul 2018 22:56:47 -0300, Ricardo Martincoski wrote:
> And warn to use $() instead.
> For examples see [1] and [2].
>
> In the regexp, search for ${VARIABLE} but:
> - ignore comments;
> - ignore variables to be expanded by the shell "$${}".
>
> [1] http://lists.busybox.net/pipermail/buildroot/2018-July/225211.html
> [2] https://github.com/buildroot/buildroot/commit/36305380db1312442623128689fe5067d9058381
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Changes v1 -> v2:
> - use \w instead of [A-Z0-9_] because we do have lowercase make
> variables and macros, and we want to catch them as well; (suggested
> by Arnout)
> - collect review tag.
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-20 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 5:16 [Buildroot] [PATCH 1/5] gconf: use $() to reference make variables instead of ${} Ricardo Martincoski
2018-07-08 5:16 ` [Buildroot] [PATCH 2/5] json-for-modern-cpp: " Ricardo Martincoski
2018-07-08 5:16 ` [Buildroot] [PATCH 3/5] libpng: " Ricardo Martincoski
2018-07-08 5:17 ` [Buildroot] [PATCH 4/5] php: " Ricardo Martincoski
2018-07-08 5:17 ` [Buildroot] [PATCH 5/5] check-package: detect the use of ${} in .mk files Ricardo Martincoski
2018-07-08 9:57 ` Arnout Vandecappelle
2018-07-08 10:14 ` Yann E. MORIN
2018-07-09 1:56 ` [Buildroot] [PATCH v2 1/1] " Ricardo Martincoski
2018-09-20 22:06 ` Thomas Petazzoni [this message]
2018-07-08 10:25 ` [Buildroot] [PATCH 1/5] gconf: use $() to reference make variables instead of ${} Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921000611.055be497@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.