From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v1] drm/tegra: dpaux: Fix always-failing probing of the driver
Date: Fri, 21 Sep 2018 14:42:41 +0300 [thread overview]
Message-ID: <20180921114241.17002-1-digetx@gmail.com> (raw)
Some of definitions in the code changed the meaning, unfortunately one
place missed the change.
Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support")
Cc: <stable@vger.kernel.org> # v4.8+
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
I don't have HW to test DPAUX driver, apparently it has been broken for
2+ years now. There is also a known issue on with the DPAUX driver that
prevents it from probing, that was discussed on the #tegra IRC. Thierry,
please take a closer look at this driver and test it thoroughly, it has
some obvious problems.
drivers/gpu/drm/tegra/dpaux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index d84e81ff36ad..ba5681fab73b 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -521,7 +521,7 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
* is no possibility to perform the I2C mode configuration in the
* HDMI path.
*/
- err = tegra_dpaux_pad_config(dpaux, DPAUX_HYBRID_PADCTL_MODE_I2C);
+ err = tegra_dpaux_pad_config(dpaux, DPAUX_PADCTL_FUNC_I2C);
if (err < 0)
return err;
--
2.19.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-09-21 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 11:42 Dmitry Osipenko [this message]
2018-09-24 11:59 ` [PATCH v1] drm/tegra: dpaux: Fix always-failing probing of the driver Thierry Reding
2018-09-24 12:32 ` Jon Hunter
2018-09-24 12:40 ` Dmitry Osipenko
2018-09-24 13:36 ` Thierry Reding
2018-09-24 13:56 ` Dmitry Osipenko
2018-09-24 14:15 ` Thierry Reding
2018-09-24 14:04 ` Thierry Reding
2018-09-24 19:15 ` Dmitry Osipenko
2018-09-24 13:30 ` Thierry Reding
2018-09-24 12:34 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921114241.17002-1-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.