From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Make sure fb gtt offsets stay
 within 32bits
Date: Fri, 21 Sep 2018 16:06:02 +0300
Message-ID: <20180921130602.GR5565@intel.com>
References: <20180920191018.19720-1-ville.syrjala@linux.intel.com>
 <153747405554.30044.13840862168097912993@skylake-alporthouse-com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 35BFB6E7B4
 for <intel-gfx@lists.freedesktop.org>; Fri, 21 Sep 2018 13:06:05 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <153747405554.30044.13840862168097912993@skylake-alporthouse-com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMDk6MDc6MzVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOC0wOS0yMCAyMDoxMDoxOCkKPiA+IEZy
b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK
PiA+IExldCdzIHRyeSB0byBtYWtlIHN1cmUgdGhlIGZiIG9mZnNldCBjb21wdXRhdGlvbnMgbmV2
ZXIgaGl0Cj4gPiBhbiBpbnRlZ2VyIG92ZXJmbG93IGJ5IG1ha2luZyBzdXJlIHRoZSBlbnRpcmUg
ZmIgc3RheXMKPiA+IGJlbG93IDMyYml0cy4gZnJhbWVidWZmZXJfY2hlY2soKSBpbiB0aGUgY29y
ZSBhbHJlYWR5IGRvZXMKPiA+IHRoZSBzYW1lIGNoZWNrLCBidXQgYXMgaXQgZG9lc24ndCBrbm93
IGFib3V0IHRpbGluZyBzb21lIHRoaW5ncwo+ID4gY2FuIHNsaXAgdGhyb3VnaC4gUmVwZWF0IHRo
ZSBjaGVjayBpbiB0aGUgZHJpdmVyIHdpdGggdGlsaW5nCj4gPiB0YWtlbiBpbnRvIGFjY291bnQu
Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMgfCAxOCArKysrKysrKysrKysrKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTcg
aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBlNjQyYjc3MTcxMDYuLjY3MjU5YzcxOWZmZSAxMDA2NDQK
PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMjQwMCwxMCArMjQw
MCwyNiBAQCBzdGF0aWMgaW50IGludGVsX2ZiX29mZnNldF90b194eShpbnQgKngsIGludCAqeSwK
PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBjb2xvcl9wbGFuZSkKPiA+
ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5
MTUoZmItPmRldik7Cj4gPiArICAgICAgIHVuc2lnbmVkIGludCBoZWlnaHQ7Cj4gPiAgCj4gPiAg
ICAgICAgIGlmIChmYi0+bW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSICYmCj4gPiAt
ICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0gJSBpbnRlbF90aWxlX3NpemUoZGV2
X3ByaXYpKQo+ID4gKyAgICAgICAgICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdICUgaW50ZWxf
dGlsZV9zaXplKGRldl9wcml2KSkgewo+ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMo
Ik1pc2FsaWduZWQgb2Zmc2V0IDB4JTA4eCBmb3IgY29sb3IgcGxhbmUgJWRcbiIsCj4gPiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0sIGNvbG9y
X3BsYW5lKTsKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICsgICAgICAg
fQo+ID4gKwo+ID4gKyAgICAgICBoZWlnaHQgPSBkcm1fZnJhbWVidWZmZXJfcGxhbmVfaGVpZ2h0
KGZiLT5oZWlnaHQsIGZiLCBjb2xvcl9wbGFuZSk7Cj4gPiArICAgICAgIGhlaWdodCA9IEFMSUdO
KGhlaWdodCwgaW50ZWxfdGlsZV9oZWlnaHQoZmIsIGNvbG9yX3BsYW5lKSk7Cj4gPiArCj4gPiAr
ICAgICAgIC8qIENhdGNoIHBvdGVudGlhbCBvdmVyZmxvd3MgZWFybHkgKi8KPiA+ICsgICAgICAg
aWYgKG11bF91MzJfdTMyKGhlaWdodCwgZmItPnBpdGNoZXNbY29sb3JfcGxhbmVdKSArCj4gCj4g
aWYgKGFkZF9vdmVyZmxvd3MobXVsX3UzMl91MzIoaGVpZ2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9w
bGFuZV0pLAo+IAkJICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0sCj4gCQkgIFUzMl9NQVgpIHsK
PiA/CgpEaWRuJ3Qga25vdyB3ZSBoYWQgdGhhdC4gTG9va3MgbGlrZSB3aGF0IHdlIGhhdmUgcmln
aHQgbm93IGRvZXNuJ3QgcXVpdGUKd29yayBhcyBpdCBvbmx5IHRha2VzIHR3byBhcmd1bWVudHMu
CgpPaCBpbnRlcmVzdGluZy4gX19idWlsdGluX2FkZF9vdmVyZmxvd19wKCkgJiBjby4gd29yayBz
dXBwb3NlZGx5IHdvcmsgb24KYml0ZmllbGRzIGFzIHdlbGwuCgpCYWguIExvb2tzIGxpa2UgdGhp
cyBzdHVmZiBnZW5lcmF0ZXNzIHdvcnNlIGNvZGUgdGhhbiB0aGUgbm9ybWFsIHRoaW5nOgoKICAg
IDQwMWU6ICAgICAgIGY3IGUzICAgICAgICAgICAgICAgICAgIG11bCAgICAlZWJ4CiAgICA0MDIw
OiAgICAgICA4OSA0NSBhYyAgICAgICAgICAgICAgICBtb3YgICAgJWVheCwtMHg1NCglZWJwKQog
ICAgNDAyMzogICAgICAgODkgYzggICAgICAgICAgICAgICAgICAgbW92ICAgICVlY3gsJWVheAog
ICAgNDAyNTogICAgICAgODkgNTUgYjAgICAgICAgICAgICAgICAgbW92ICAgICVlZHgsLTB4NTAo
JWVicCkKICAgIDQwMjg6ICAgICAgIDMxIGQyICAgICAgICAgICAgICAgICAgIHhvciAgICAlZWR4
LCVlZHgKICAgIDQwMmE6ICAgICAgIDAzIDQ1IGFjICAgICAgICAgICAgICAgIGFkZCAgICAtMHg1
NCglZWJwKSwlZWF4CiAgICA0MDJkOiAgICAgICAxMyA1NSBiMCAgICAgICAgICAgICAgICBhZGMg
ICAgLTB4NTAoJWVicCksJWVkeAogICAgNDAzMDogICAgICAgODMgZmEgMDAgICAgICAgICAgICAg
ICAgY21wICAgICQweDAsJWVkeAogICAgNDAzMzogICAgICAgMGYgODcgODcgMDIgMDAgMDAgICAg
ICAgamEgICAgIDQyYzAgPGludGVsX2ZyYW1lYnVmZmVyX2luaXQrMHhiNTA+Cgp2cy4KCiAgICA0
MDFhOiAgICAgICBmNyA2NSBiOCAgICAgICAgICAgICAgICBtdWxsICAgLTB4NDgoJWVicCkKICAg
IDQwMWQ6ICAgICAgIDg5IDQ1IGFjICAgICAgICAgICAgICAgIG1vdiAgICAlZWF4LC0weDU0KCVl
YnApCiAgICA0MDIwOiAgICAgICA4OSBkOCAgICAgICAgICAgICAgICAgICBtb3YgICAgJWVieCwl
ZWF4CiAgICA0MDIyOiAgICAgICA4OSA1NSBiMCAgICAgICAgICAgICAgICBtb3YgICAgJWVkeCwt
MHg1MCglZWJwKQogICAgNDAyNTogICAgICAgMzEgZDIgICAgICAgICAgICAgICAgICAgeG9yICAg
ICVlZHgsJWVkeAogICAgNDAyNzogICAgICAgMDMgNDUgYWMgICAgICAgICAgICAgICAgYWRkICAg
IC0weDU0KCVlYnApLCVlYXgKICAgIDQwMmE6ICAgICAgIDEzIDU1IGIwICAgICAgICAgICAgICAg
IGFkYyAgICAtMHg1MCglZWJwKSwlZWR4CiAgICA0MDJkOiAgICAgICAzYiA1NSBiMCAgICAgICAg
ICAgICAgICBjbXAgICAgLTB4NTAoJWVicCksJWVkeAogICAgNDAzMDogICAgICAgNzcgMGMgICAg
ICAgICAgICAgICAgICAgamEgICAgIDQwM2UgPGludGVsX2ZyYW1lYnVmZmVyX2luaXQrMHg4Y2U+
CiAgICA0MDMyOiAgICAgICA3MiAwNSAgICAgICAgICAgICAgICAgICBqYiAgICAgNDAzOSA8aW50
ZWxfZnJhbWVidWZmZXJfaW5pdCsweDhjOT4KICAgIDQwMzQ6ICAgICAgIDNiIDQ1IGFjICAgICAg
ICAgICAgICAgIGNtcCAgICAtMHg1NCglZWJwKSwlZWF4CiAgICA0MDM3OiAgICAgICA3MyAwNSAg
ICAgICAgICAgICAgICAgICBqYWUgICAgNDAzZSA8aW50ZWxfZnJhbWVidWZmZXJfaW5pdCsweDhj
ZT4KICAgIDQwMzk6ICAgICAgIGI5IDAxIDAwIDAwIDAwICAgICAgICAgIG1vdiAgICAkMHgxLCVl
Y3gKICAgIDQwM2U6ICAgICAgIDg1IGQyICAgICAgICAgICAgICAgICAgIHRlc3QgICAlZWR4LCVl
ZHgKICAgIDQwNDA6ICAgICAgIDBmIDg1IDlhIDAyIDAwIDAwICAgICAgIGpuZSAgICA0MmUwIDxp
bnRlbF9mcmFtZWJ1ZmZlcl9pbml0KzB4YjcwPgogICAgNDA0NjogICAgICAgODUgYzkgICAgICAg
ICAgICAgICAgICAgdGVzdCAgICVlY3gsJWVjeAogICAgNDA0ODogICAgICAgMGYgODUgOTIgMDIg
MDAgMDAgICAgICAgam5lICAgIDQyZTAgPGludGVsX2ZyYW1lYnVmZmVyX2luaXQrMHhiNzA+CgpT
byBmaXZlIGJyYW5jaGVzIGluc3RlYWQgb2YganVzdCB0aGUgb25lLiBUaGF0IHNlZW1zIGEgYml0
IGV4Y2Vzc2l2ZS4KCj4gCj4gPiArICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0g
PiBVSU5UX01BWCkgewo+ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIkJhZCBvZmZz
ZXQgMHglMDh4IG9yIHBpdGNoICVkIGZvciBjb2xvciBwbGFuZSAlZFxuIiwKPiA+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5lXSwgZmItPnBpdGNo
ZXNbY29sb3JfcGxhbmVdLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29sb3Jf
cGxhbmUpOwo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiAtRVJBTkdFOwo+ID4gKyAgICAgICB9
Cj4gPiAgCj4gPiAgICAgICAgICp4ID0gMDsKPiA+ICAgICAgICAgKnkgPSAwOwo+ID4gLS0gCj4g
PiAyLjE2LjQKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp
c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=