From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: clearfog: fix sdhci supply property name
Date: Fri, 21 Sep 2018 14:51:20 +0100 [thread overview]
Message-ID: <20180921135120.GL30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <871s9nhsr2.fsf@bootlin.com>
On Fri, Sep 21, 2018 at 03:42:09PM +0200, Gregory CLEMENT wrote:
> Hi Baruch,
>
> On mar., ao?t 21 2018, Baruch Siach <baruch@tkos.co.il> wrote:
>
> > The vmmc phandle, like all power supply property names, must have the
> > '-supply' suffix.
> >
>
> I also noticed it a few months ago and then I forgot. However, does it
> add any value to have this regulator?
>
> Now that I found my note, I considered to just remove this line as well
> as the regulator node.
The "value" is it's a fuller description of the hardware, and DT is a
hardware description, not a description of what the software requires.
So, imho, it's completely correct to specify the vmmc. As maintainer
for the Clearfog DT, I'd like it to stay (and be fixed). Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-09-21 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 19:12 [PATCH] ARM: dts: clearfog: fix sdhci supply property name Baruch Siach
2018-09-21 13:42 ` Gregory CLEMENT
2018-09-21 13:51 ` Russell King - ARM Linux [this message]
2018-09-21 14:05 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921135120.GL30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.