From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types Date: Fri, 21 Sep 2018 17:01:35 +0300 Message-ID: <20180921140135.GX5565@intel.com> References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans Verkuil Cc: intel-gfx@lists.freedesktop.org, Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMTA6NDE6NDZBTSArMDIwMCwgSGFucyBWZXJrdWlsIHdy b3RlOgo+IE9uIDA5LzIwLzE4IDIwOjUxLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ID4gRnJvbTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4g V2UnbGwgYmUgd2FudGluZyB0byBzZW5kIG1vcmUgdGhhbiBqdXN0IGluZm9mcmFtZXMgb3ZlciBI RE1JLiBTbyBhZGQgYW4KPiA+IGVudW0gZm9yIG90aGVyIHBhY2tldCB0eXBlcy4KPiA+IAo+ID4g VE9ETzogTWF5YmUganVzdCBpbmNsdWRlIHRoZSBpbmZvZnJhbWUgdHlwZXMgaW4gdGhlIHBhY2tl dCB0eXBlIGVudW0KPiA+ICAgICAgIGFuZCBnZXQgcmlkIG9mIHRoZSBpbmZvZnJhbWUgdHlwZSBl bnVtPwo+IAo+IEkgdGhpbmsgdGhhdCdzIGJldHRlciwgSU1ITy4gV2l0aCBhIGNvbW1lbnQgdGhh dCB0aGUgdHlwZXMgc3RhcnRpbmcgd2l0aAo+IDB4ODEgYXJlIGRlZmluZWQgaW4gQ1RBLTg2MS1H Lgo+IAo+IEl0J3MgcmVhbGx5IHRoZSBzYW1lIGJ5dGUgdGhhdCBpcyBiZWluZyBjaGVja2VkLCBz byBoYXZpbmcgdHdvIGVudW1zIGlzCj4gYSBiaXQgbWlzbGVhZGluZy4gVGhlIG1haW4gZGlmZmVy ZW5jZSBpcyByZWFsbHkgd2hpY2ggc3RhbmRhcmQgZGVmaW5lcwo+IHRoZSBwYWNrZXQgdHlwZXMu CgpSaWdodC4gVGhlIG9ubHkgc2xpZ2h0IGFubm95YW5jZSBpcyB0aGF0IHdlJ2xsIGdldCBhIGJ1 bmNoIG9mIHdhcm5pbmdzCmZyb20gdGhlIGNvbXBpbGVyIGlmIHdlIGRvbid0IGhhbmRsZSBhbGwg dGhlIGVudW0gdmFsdXMgaW4gdGhlIHN3aXRjaApzdGF0ZW1lbnRzLiBJZiB3ZSB3YW50IHRvIGF2 b2lkIHRoYXQgSSBndWVzcyBJIGNvdWxkIGxpbWl0IHRoaXMKdG8ganVzdCB0aGUgbnVsbCwgZ2Nw IGFuZCBnYW11dCBtZXRhZGF0YSBwYWNrZXRzIGluaXRpYWxseSBhbmQgdHJ5IHRvCndyaXRlIHNv bWUgYWN0dWFsIGNvZGUgZm9yIHRoZW0uIFRob3NlIHRocmVlIGFyZSB0aGUgb25seSBvbmVzIHdl CmNhcmUgYWJvdXQgaW4gaTkxNSBhdCB0aGUgbW9tZW50LgoKPiAKPiBSZWdhcmRzLAo+IAo+IAlI YW5zCj4gCj4gPiAKPiA+IENjOiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwu Y29tPgo+ID4gQ2M6IEhhbnMgVmVya3VpbCA8aGFucy52ZXJrdWlsQGNpc2NvLmNvbT4KPiA+IENj OiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBpbmNs dWRlL2xpbnV4L2hkbWkuaCB8IDE1ICsrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAxNSBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2hk bWkuaCBiL2luY2x1ZGUvbGludXgvaGRtaS5oCj4gPiBpbmRleCBjNzZiNTBhNDhlNDguLjgwNTIx ZDk1OTFhMSAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvbGludXgvaGRtaS5oCj4gPiArKysgYi9p bmNsdWRlL2xpbnV4L2hkbWkuaAo+ID4gQEAgLTI3LDYgKzI3LDIxIEBACj4gPiAgI2luY2x1ZGUg PGxpbnV4L3R5cGVzLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+ID4gIAo+ID4g K2VudW0gaGRtaV9wYWNrZXRfdHlwZSB7Cj4gPiArCUhETUlfUEFDS0VUX1RZUEVfTlVMTCA9IDB4 MDAsCj4gPiArCUhETUlfUEFDS0VUX1RZUEVfQVVESU9fQ0xPQ0tfUkVHRU4gPSAweDAxLAo+ID4g KwlIRE1JX1BBQ0tFVF9UWVBFX0FVRElPX1NBTVBMRSA9IDB4MDIsCj4gPiArCUhETUlfUEFDS0VU X1RZUEVfR0VORVJBTF9DT05UUk9MID0gMHgwMywKPiA+ICsJSERNSV9QQUNLRVRfVFlQRV9BVURJ T19DUCA9IDB4MDQsCj4gPiArCUhETUlfUEFDS0VUX1RZUEVfSVNSQzEgPSAweDA1LAo+ID4gKwlI RE1JX1BBQ0tFVF9UWVBFX0lTUkMyID0gMHgwNiwKPiA+ICsJSERNSV9QQUNLRVRfVFlQRV9PTkVf QklUX0FVRElPX1NBTVBMRSA9IDB4MDcsCj4gPiArCUhETUlfUEFDS0VUX1RZUEVfRFNUX0FVRElP ID0gMHgwOCwKPiA+ICsJSERNSV9QQUNLRVRfVFlQRV9IQlJfQVVESU9fU1RSRUFNID0gMHgwOSwK PiA+ICsJSERNSV9QQUNLRVRfVFlQRV9HQU1VVF9NRVRBREFUQSA9IDB4MGEsCj4gPiArCS8qICsg ZW51bSBoZG1pX2luZm9mcmFtZV90eXBlICovCj4gPiArfTsKPiA+ICsKPiA+ICBlbnVtIGhkbWlf aW5mb2ZyYW1lX3R5cGUgewo+ID4gIAlIRE1JX0lORk9GUkFNRV9UWVBFX1ZFTkRPUiA9IDB4ODEs Cj4gPiAgCUhETUlfSU5GT0ZSQU1FX1RZUEVfQVZJID0gMHg4MiwKPiA+IAoKLS0gClZpbGxlIFN5 cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:5688 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeIUTuj (ORCPT ); Fri, 21 Sep 2018 15:50:39 -0400 Date: Fri, 21 Sep 2018 17:01:35 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Hans Verkuil Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Thierry Reding , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types Message-ID: <20180921140135.GX5565@intel.com> References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-6-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: > On 09/20/18 20:51, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We'll be wanting to send more than just infoframes over HDMI. So add an > > enum for other packet types. > > > > TODO: Maybe just include the infoframe types in the packet type enum > > and get rid of the infoframe type enum? > > I think that's better, IMHO. With a comment that the types starting with > 0x81 are defined in CTA-861-G. > > It's really the same byte that is being checked, so having two enums is > a bit misleading. The main difference is really which standard defines > the packet types. Right. The only slight annoyance is that we'll get a bunch of warnings from the compiler if we don't handle all the enum valus in the switch statements. If we want to avoid that I guess I could limit this to just the null, gcp and gamut metadata packets initially and try to write some actual code for them. Those three are the only ones we care about in i915 at the moment. > > Regards, > > Hans > > > > > Cc: Thierry Reding > > Cc: Hans Verkuil > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Ville Syrjälä > > --- > > include/linux/hdmi.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h > > index c76b50a48e48..80521d9591a1 100644 > > --- a/include/linux/hdmi.h > > +++ b/include/linux/hdmi.h > > @@ -27,6 +27,21 @@ > > #include > > #include > > > > +enum hdmi_packet_type { > > + HDMI_PACKET_TYPE_NULL = 0x00, > > + HDMI_PACKET_TYPE_AUDIO_CLOCK_REGEN = 0x01, > > + HDMI_PACKET_TYPE_AUDIO_SAMPLE = 0x02, > > + HDMI_PACKET_TYPE_GENERAL_CONTROL = 0x03, > > + HDMI_PACKET_TYPE_AUDIO_CP = 0x04, > > + HDMI_PACKET_TYPE_ISRC1 = 0x05, > > + HDMI_PACKET_TYPE_ISRC2 = 0x06, > > + HDMI_PACKET_TYPE_ONE_BIT_AUDIO_SAMPLE = 0x07, > > + HDMI_PACKET_TYPE_DST_AUDIO = 0x08, > > + HDMI_PACKET_TYPE_HBR_AUDIO_STREAM = 0x09, > > + HDMI_PACKET_TYPE_GAMUT_METADATA = 0x0a, > > + /* + enum hdmi_infoframe_type */ > > +}; > > + > > enum hdmi_infoframe_type { > > HDMI_INFOFRAME_TYPE_VENDOR = 0x81, > > HDMI_INFOFRAME_TYPE_AVI = 0x82, > > -- Ville Syrjälä Intel