From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types Date: Fri, 21 Sep 2018 18:07:12 +0300 Message-ID: <20180921150712.GB5565@intel.com> References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-6-ville.syrjala@linux.intel.com> <20180921140135.GX5565@intel.com> <55a45f48-f9d8-a28f-c847-d8083d500585@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <55a45f48-f9d8-a28f-c847-d8083d500585@cisco.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: intel-gfx@lists.freedesktop.org, Thierry Reding , Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDQ6MTI6MzZQTSArMDIwMCwgSGFucyBWZXJrdWlsIHdy b3RlOgo+IE9uIDA5LzIxLzE4IDE2OjAxLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBG cmksIFNlcCAyMSwgMjAxOCBhdCAxMDo0MTo0NkFNICswMjAwLCBIYW5zIFZlcmt1aWwgd3JvdGU6 Cj4gPj4gT24gMDkvMjAvMTggMjA6NTEsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gPj4+IEZyb206 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4+Cj4g Pj4+IFdlJ2xsIGJlIHdhbnRpbmcgdG8gc2VuZCBtb3JlIHRoYW4ganVzdCBpbmZvZnJhbWVzIG92 ZXIgSERNSS4gU28gYWRkIGFuCj4gPj4+IGVudW0gZm9yIG90aGVyIHBhY2tldCB0eXBlcy4KPiA+ Pj4KPiA+Pj4gVE9ETzogTWF5YmUganVzdCBpbmNsdWRlIHRoZSBpbmZvZnJhbWUgdHlwZXMgaW4g dGhlIHBhY2tldCB0eXBlIGVudW0KPiA+Pj4gICAgICAgYW5kIGdldCByaWQgb2YgdGhlIGluZm9m cmFtZSB0eXBlIGVudW0/Cj4gPj4KPiA+PiBJIHRoaW5rIHRoYXQncyBiZXR0ZXIsIElNSE8uIFdp dGggYSBjb21tZW50IHRoYXQgdGhlIHR5cGVzIHN0YXJ0aW5nIHdpdGgKPiA+PiAweDgxIGFyZSBk ZWZpbmVkIGluIENUQS04NjEtRy4KPiA+Pgo+ID4+IEl0J3MgcmVhbGx5IHRoZSBzYW1lIGJ5dGUg dGhhdCBpcyBiZWluZyBjaGVja2VkLCBzbyBoYXZpbmcgdHdvIGVudW1zIGlzCj4gPj4gYSBiaXQg bWlzbGVhZGluZy4gVGhlIG1haW4gZGlmZmVyZW5jZSBpcyByZWFsbHkgd2hpY2ggc3RhbmRhcmQg ZGVmaW5lcwo+ID4+IHRoZSBwYWNrZXQgdHlwZXMuCj4gPiAKPiA+IFJpZ2h0LiBUaGUgb25seSBz bGlnaHQgYW5ub3lhbmNlIGlzIHRoYXQgd2UnbGwgZ2V0IGEgYnVuY2ggb2Ygd2FybmluZ3MKPiA+ IGZyb20gdGhlIGNvbXBpbGVyIGlmIHdlIGRvbid0IGhhbmRsZSBhbGwgdGhlIGVudW0gdmFsdXMg aW4gdGhlIHN3aXRjaAo+ID4gc3RhdGVtZW50cy4gSWYgd2Ugd2FudCB0byBhdm9pZCB0aGF0IEkg Z3Vlc3MgSSBjb3VsZCBsaW1pdCB0aGlzCj4gPiB0byBqdXN0IHRoZSBudWxsLCBnY3AgYW5kIGdh bXV0IG1ldGFkYXRhIHBhY2tldHMgaW5pdGlhbGx5IGFuZCB0cnkgdG8KPiA+IHdyaXRlIHNvbWUg YWN0dWFsIGNvZGUgZm9yIHRoZW0uIFRob3NlIHRocmVlIGFyZSB0aGUgb25seSBvbmVzIHdlCj4g PiBjYXJlIGFib3V0IGluIGk5MTUgYXQgdGhlIG1vbWVudC4KPiAKPiBOb3RlIHRoYXQgSSBkb24n dCBoYXZlIGEgdGVycmlibHkgc3Ryb25nIG9waW5pb24gb24gdGhpcywgc28gaWYgdXNpbmcKPiBv bmUgZW51bSBpbnN0ZWFkIG9mIHR3byBjYXVzZXMgbW9yZSBwcm9ibGVtcyB0aGFuIGl0IGlzIHdv cnRoLCB0aGVuCj4gdGhhdCdzIGZpbmUgd2l0aCBtZSBhcyB3ZWxsLgo+IAo+IEJ1dCB5b3UgYXNr ZWQsIGFuZCBnaXZlbiBhIGNob2ljZSB3aXRoIGFsbCBvdGhlciB0aGluZ3MgYmVpbmcgZXF1YWws Cj4gdGhlbiBvbmUgZW51bSBoYXMgbXkgcHJlZmVyZW5jZS4KCkkgZG8gYWdyZWUgdGhhdCBpdCB3 b3VsZCBzZWVtIG5pY2VyLgoKQnV0IEknbSBhIGJpdCBidXN5IHdpdGggb3RoZXIgdGhpbmdzIGF0 IHRoZSBtb21lbnQgc28gSSBtaWdodCB3YW50CnRvIGxlYXZlIGl0IGxpa2UgdGhpcyBmb3Igbm93 IGFuZCByZXZpc2l0IHRoZSB0b3BpYyBpbiB0aGUKaG9wZWZ1bGx5LW5vdC10b28tZGlzdGFudCBm dXR1cmUuCgo+IAo+IFJlZ2FyZHMsCj4gCj4gCUhhbnMKPiAKPiA+IAo+ID4+Cj4gPj4gUmVnYXJk cywKPiA+Pgo+ID4+IAlIYW5zCj4gPj4KPiA+Pj4KPiA+Pj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0 aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPj4+IENjOiBIYW5zIFZlcmt1aWwgPGhhbnMudmVy a3VpbEBjaXNjby5jb20+Cj4gPj4+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiA+ Pj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+Pj4gLS0tCj4gPj4+ICBpbmNsdWRlL2xpbnV4L2hkbWkuaCB8IDE1ICsrKysr KysrKysrKysrKwo+ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykKPiA+Pj4K PiA+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaGRtaS5oIGIvaW5jbHVkZS9saW51eC9o ZG1pLmgKPiA+Pj4gaW5kZXggYzc2YjUwYTQ4ZTQ4Li44MDUyMWQ5NTkxYTEgMTAwNjQ0Cj4gPj4+ IC0tLSBhL2luY2x1ZGUvbGludXgvaGRtaS5oCj4gPj4+ICsrKyBiL2luY2x1ZGUvbGludXgvaGRt aS5oCj4gPj4+IEBAIC0yNyw2ICsyNywyMSBAQAo+ID4+PiAgI2luY2x1ZGUgPGxpbnV4L3R5cGVz Lmg+Cj4gPj4+ICAjaW5jbHVkZSA8bGludXgvZGV2aWNlLmg+Cj4gPj4+ICAKPiA+Pj4gK2VudW0g aGRtaV9wYWNrZXRfdHlwZSB7Cj4gPj4+ICsJSERNSV9QQUNLRVRfVFlQRV9OVUxMID0gMHgwMCwK PiA+Pj4gKwlIRE1JX1BBQ0tFVF9UWVBFX0FVRElPX0NMT0NLX1JFR0VOID0gMHgwMSwKPiA+Pj4g KwlIRE1JX1BBQ0tFVF9UWVBFX0FVRElPX1NBTVBMRSA9IDB4MDIsCj4gPj4+ICsJSERNSV9QQUNL RVRfVFlQRV9HRU5FUkFMX0NPTlRST0wgPSAweDAzLAo+ID4+PiArCUhETUlfUEFDS0VUX1RZUEVf QVVESU9fQ1AgPSAweDA0LAo+ID4+PiArCUhETUlfUEFDS0VUX1RZUEVfSVNSQzEgPSAweDA1LAo+ ID4+PiArCUhETUlfUEFDS0VUX1RZUEVfSVNSQzIgPSAweDA2LAo+ID4+PiArCUhETUlfUEFDS0VU X1RZUEVfT05FX0JJVF9BVURJT19TQU1QTEUgPSAweDA3LAo+ID4+PiArCUhETUlfUEFDS0VUX1RZ UEVfRFNUX0FVRElPID0gMHgwOCwKPiA+Pj4gKwlIRE1JX1BBQ0tFVF9UWVBFX0hCUl9BVURJT19T VFJFQU0gPSAweDA5LAo+ID4+PiArCUhETUlfUEFDS0VUX1RZUEVfR0FNVVRfTUVUQURBVEEgPSAw eDBhLAo+ID4+PiArCS8qICsgZW51bSBoZG1pX2luZm9mcmFtZV90eXBlICovCj4gPj4+ICt9Owo+ ID4+PiArCj4gPj4+ICBlbnVtIGhkbWlfaW5mb2ZyYW1lX3R5cGUgewo+ID4+PiAgCUhETUlfSU5G T0ZSQU1FX1RZUEVfVkVORE9SID0gMHg4MSwKPiA+Pj4gIAlIRE1JX0lORk9GUkFNRV9UWVBFX0FW SSA9IDB4ODIsCj4gPj4+Cj4gPiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com ([134.134.136.20]:8872 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390065AbeIUU4d (ORCPT ); Fri, 21 Sep 2018 16:56:33 -0400 Date: Fri, 21 Sep 2018 18:07:12 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Hans Verkuil Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Thierry Reding , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types Message-ID: <20180921150712.GB5565@intel.com> References: <20180920185145.1912-1-ville.syrjala@linux.intel.com> <20180920185145.1912-6-ville.syrjala@linux.intel.com> <20180921140135.GX5565@intel.com> <55a45f48-f9d8-a28f-c847-d8083d500585@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55a45f48-f9d8-a28f-c847-d8083d500585@cisco.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Sep 21, 2018 at 04:12:36PM +0200, Hans Verkuil wrote: > On 09/21/18 16:01, Ville Syrjälä wrote: > > On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: > >> On 09/20/18 20:51, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>> We'll be wanting to send more than just infoframes over HDMI. So add an > >>> enum for other packet types. > >>> > >>> TODO: Maybe just include the infoframe types in the packet type enum > >>> and get rid of the infoframe type enum? > >> > >> I think that's better, IMHO. With a comment that the types starting with > >> 0x81 are defined in CTA-861-G. > >> > >> It's really the same byte that is being checked, so having two enums is > >> a bit misleading. The main difference is really which standard defines > >> the packet types. > > > > Right. The only slight annoyance is that we'll get a bunch of warnings > > from the compiler if we don't handle all the enum valus in the switch > > statements. If we want to avoid that I guess I could limit this > > to just the null, gcp and gamut metadata packets initially and try to > > write some actual code for them. Those three are the only ones we > > care about in i915 at the moment. > > Note that I don't have a terribly strong opinion on this, so if using > one enum instead of two causes more problems than it is worth, then > that's fine with me as well. > > But you asked, and given a choice with all other things being equal, > then one enum has my preference. I do agree that it would seem nicer. But I'm a bit busy with other things at the moment so I might want to leave it like this for now and revisit the topic in the hopefully-not-too-distant future. > > Regards, > > Hans > > > > >> > >> Regards, > >> > >> Hans > >> > >>> > >>> Cc: Thierry Reding > >>> Cc: Hans Verkuil > >>> Cc: linux-media@vger.kernel.org > >>> Signed-off-by: Ville Syrjälä > >>> --- > >>> include/linux/hdmi.h | 15 +++++++++++++++ > >>> 1 file changed, 15 insertions(+) > >>> > >>> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h > >>> index c76b50a48e48..80521d9591a1 100644 > >>> --- a/include/linux/hdmi.h > >>> +++ b/include/linux/hdmi.h > >>> @@ -27,6 +27,21 @@ > >>> #include > >>> #include > >>> > >>> +enum hdmi_packet_type { > >>> + HDMI_PACKET_TYPE_NULL = 0x00, > >>> + HDMI_PACKET_TYPE_AUDIO_CLOCK_REGEN = 0x01, > >>> + HDMI_PACKET_TYPE_AUDIO_SAMPLE = 0x02, > >>> + HDMI_PACKET_TYPE_GENERAL_CONTROL = 0x03, > >>> + HDMI_PACKET_TYPE_AUDIO_CP = 0x04, > >>> + HDMI_PACKET_TYPE_ISRC1 = 0x05, > >>> + HDMI_PACKET_TYPE_ISRC2 = 0x06, > >>> + HDMI_PACKET_TYPE_ONE_BIT_AUDIO_SAMPLE = 0x07, > >>> + HDMI_PACKET_TYPE_DST_AUDIO = 0x08, > >>> + HDMI_PACKET_TYPE_HBR_AUDIO_STREAM = 0x09, > >>> + HDMI_PACKET_TYPE_GAMUT_METADATA = 0x0a, > >>> + /* + enum hdmi_infoframe_type */ > >>> +}; > >>> + > >>> enum hdmi_infoframe_type { > >>> HDMI_INFOFRAME_TYPE_VENDOR = 0x81, > >>> HDMI_INFOFRAME_TYPE_AVI = 0x82, > >>> > > -- Ville Syrjälä Intel