From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 21 Sep 2018 18:05:33 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Benjamin Herrenschmidt , Alex Williamson , Christian =?iso-8859-1?Q?K=F6nig?= , Jens Axboe Subject: Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory Message-ID: <20180921160533.GA26601@lst.de> References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-2-logang@deltatee.com> <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Fri, Sep 21, 2018 at 09:37:33AM -0600, Logan Gunthorpe wrote: > On 2018-09-21 7:00 AM, Bjorn Helgaas wrote: > > On Thu, Sep 20, 2018 at 04:47:49PM -0600, Logan Gunthorpe wrote: > >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote: > >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt > >>> > >>> Is pr_fmt() actually used anywhere? > >> > >> It's used in a Patch 4 to print errors in the configfs helpers. > > > > Ideally pr_fmt() would be added in the same patch that uses it, but > > obviously pretty trivial. > > Hmm, well Christoph asked me to do it this way. ;) Sorry. I somehow was under the impression we already had a printk in the earlier patch, but it looks like I was confused. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B4BB521154135 for ; Fri, 21 Sep 2018 09:05:31 -0700 (PDT) Date: Fri, 21 Sep 2018 18:05:33 +0200 From: Christoph Hellwig Subject: Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory Message-ID: <20180921160533.GA26601@lst.de> References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-2-logang@deltatee.com> <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Jens Axboe , Alex Williamson , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Bjorn Helgaas , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On Fri, Sep 21, 2018 at 09:37:33AM -0600, Logan Gunthorpe wrote: > On 2018-09-21 7:00 AM, Bjorn Helgaas wrote: > > On Thu, Sep 20, 2018 at 04:47:49PM -0600, Logan Gunthorpe wrote: > >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote: > >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt > >>> > >>> Is pr_fmt() actually used anywhere? > >> > >> It's used in a Patch 4 to print errors in the configfs helpers. > > > > Ideally pr_fmt() would be added in the same patch that uses it, but > > obviously pretty trivial. > > Hmm, well Christoph asked me to do it this way. ;) Sorry. I somehow was under the impression we already had a printk in the earlier patch, but it looks like I was confused. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Fri, 21 Sep 2018 18:05:33 +0200 Subject: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory In-Reply-To: References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-2-logang@deltatee.com> <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> Message-ID: <20180921160533.GA26601@lst.de> On Fri, Sep 21, 2018@09:37:33AM -0600, Logan Gunthorpe wrote: > On 2018-09-21 7:00 AM, Bjorn Helgaas wrote: > > On Thu, Sep 20, 2018@04:47:49PM -0600, Logan Gunthorpe wrote: > >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote: > >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt > >>> > >>> Is pr_fmt() actually used anywhere? > >> > >> It's used in a Patch 4 to print errors in the configfs helpers. > > > > Ideally pr_fmt() would be added in the same patch that uses it, but > > obviously pretty trivial. > > Hmm, well Christoph asked me to do it this way. ;) Sorry. I somehow was under the impression we already had a printk in the earlier patch, but it looks like I was confused. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory Date: Fri, 21 Sep 2018 18:05:33 +0200 Message-ID: <20180921160533.GA26601@lst.de> References: <20180913001156.4115-1-logang@deltatee.com> <20180913001156.4115-2-logang@deltatee.com> <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> <20180921130010.GE224714@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Jens Axboe , Alex Williamson , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Bjorn Helgaas , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org On Fri, Sep 21, 2018 at 09:37:33AM -0600, Logan Gunthorpe wrote: > On 2018-09-21 7:00 AM, Bjorn Helgaas wrote: > > On Thu, Sep 20, 2018 at 04:47:49PM -0600, Logan Gunthorpe wrote: > >> On 2018-09-20 4:38 PM, Bjorn Helgaas wrote: > >>>> +#define pr_fmt(fmt) "pci-p2pdma: " fmt > >>> > >>> Is pr_fmt() actually used anywhere? > >> > >> It's used in a Patch 4 to print errors in the configfs helpers. > > > > Ideally pr_fmt() would be added in the same patch that uses it, but > > obviously pretty trivial. > > Hmm, well Christoph asked me to do it this way. ;) Sorry. I somehow was under the impression we already had a printk in the earlier patch, but it looks like I was confused.