From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Make sure fb gtt offsets stay within 32bits Date: Fri, 21 Sep 2018 20:07:29 +0300 Message-ID: <20180921170729.GG5565@intel.com> References: <20180920191018.19720-1-ville.syrjala@linux.intel.com> <153747405554.30044.13840862168097912993@skylake-alporthouse-com> <20180921130602.GR5565@intel.com> <153754654008.21139.16522252152684045368@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 306826E87F for ; Fri, 21 Sep 2018 17:07:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <153754654008.21139.16522252152684045368@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDU6MTU6NDBQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTA5LTIxIDE0OjA2OjAyKQo+ID4g T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMDk6MDc6MzVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+ID4gPiBRdW90aW5nIFZpbGxlIFN5cmphbGEgKDIwMTgtMDktMjAgMjA6MTA6MTgpCj4g PiA+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+ID4gPiAKPiA+ID4gPiBMZXQncyB0cnkgdG8gbWFrZSBzdXJlIHRoZSBmYiBvZmZzZXQg Y29tcHV0YXRpb25zIG5ldmVyIGhpdAo+ID4gPiA+IGFuIGludGVnZXIgb3ZlcmZsb3cgYnkgbWFr aW5nIHN1cmUgdGhlIGVudGlyZSBmYiBzdGF5cwo+ID4gPiA+IGJlbG93IDMyYml0cy4gZnJhbWVi dWZmZXJfY2hlY2soKSBpbiB0aGUgY29yZSBhbHJlYWR5IGRvZXMKPiA+ID4gPiB0aGUgc2FtZSBj aGVjaywgYnV0IGFzIGl0IGRvZXNuJ3Qga25vdyBhYm91dCB0aWxpbmcgc29tZSB0aGluZ3MKPiA+ ID4gPiBjYW4gc2xpcCB0aHJvdWdoLiBSZXBlYXQgdGhlIGNoZWNrIGluIHRoZSBkcml2ZXIgd2l0 aCB0aWxpbmcKPiA+ID4gPiB0YWtlbiBpbnRvIGFjY291bnQuCj4gPiA+ID4gCj4gPiA+ID4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIHwgMTggKysrKysrKysrKysrKysrKystCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiA+IGluZGV4IGU2NDJiNzcxNzEwNi4uNjcyNTljNzE5 ZmZlIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ID4gPiA+IEBAIC0yNDAwLDEwICsyNDAwLDI2IEBAIHN0YXRpYyBpbnQgaW50ZWxfZmJfb2Zmc2V0 X3RvX3h5KGludCAqeCwgaW50ICp5LAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBjb2xvcl9wbGFuZSkKPiA+ID4gPiAgewo+ID4gPiA+ICAgICAgICAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShmYi0+ZGV2KTsKPiA+ID4gPiAr ICAgICAgIHVuc2lnbmVkIGludCBoZWlnaHQ7Cj4gPiA+ID4gIAo+ID4gPiA+ICAgICAgICAgaWYg KGZiLT5tb2RpZmllciAhPSBEUk1fRk9STUFUX01PRF9MSU5FQVIgJiYKPiA+ID4gPiAtICAgICAg ICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0gJSBpbnRlbF90aWxlX3NpemUoZGV2X3ByaXYp KQo+ID4gPiA+ICsgICAgICAgICAgIGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5lXSAlIGludGVsX3Rp bGVfc2l6ZShkZXZfcHJpdikpIHsKPiA+ID4gPiArICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tN UygiTWlzYWxpZ25lZCBvZmZzZXQgMHglMDh4IGZvciBjb2xvciBwbGFuZSAlZFxuIiwKPiA+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0s IGNvbG9yX3BsYW5lKTsKPiA+ID4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4g PiA+ID4gKyAgICAgICB9Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgaGVpZ2h0ID0gZHJtX2Zy YW1lYnVmZmVyX3BsYW5lX2hlaWdodChmYi0+aGVpZ2h0LCBmYiwgY29sb3JfcGxhbmUpOwo+ID4g PiA+ICsgICAgICAgaGVpZ2h0ID0gQUxJR04oaGVpZ2h0LCBpbnRlbF90aWxlX2hlaWdodChmYiwg Y29sb3JfcGxhbmUpKTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAvKiBDYXRjaCBwb3RlbnRp YWwgb3ZlcmZsb3dzIGVhcmx5ICovCj4gPiA+ID4gKyAgICAgICBpZiAobXVsX3UzMl91MzIoaGVp Z2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9wbGFuZV0pICsKPiA+ID4gCj4gPiA+IGlmIChhZGRfb3Zl cmZsb3dzKG11bF91MzJfdTMyKGhlaWdodCwgZmItPnBpdGNoZXNbY29sb3JfcGxhbmVdKSwKPiA+ ID4gICAgICAgICAgICAgICAgIGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5lXSwKPiA+ID4gICAgICAg ICAgICAgICAgIFUzMl9NQVgpIHsKPiA+ID4gPwo+ID4gCj4gPiBEaWRuJ3Qga25vdyB3ZSBoYWQg dGhhdC4gTG9va3MgbGlrZSB3aGF0IHdlIGhhdmUgcmlnaHQgbm93IGRvZXNuJ3QgcXVpdGUKPiA+ IHdvcmsgYXMgaXQgb25seSB0YWtlcyB0d28gYXJndW1lbnRzLgo+IAo+IFRydWUsIHdlIHdvdWxk IG5lZWQgdGhlIG11bF9vdmVyZmxvd3MgYXMgd2VsbCBJIGd1ZXNzICh1bmxlc3Mgd2UgYXJlCj4g aGFwcHkgdGhhdCdzIGVsaW1pbmF0ZWQgZWFybGllcikuCgpJIGd1ZXNzIHdlJ2QgcmVhbGx5IHdh bnQgYSBtYWNfb3ZlcmZsb3dzKCkgdG8gZG9jdW1lbnQgd2hhdCBpdCdzCnJlYWxseSBjaGVja2lu Zy4KCj4gIAo+ID4gT2ggaW50ZXJlc3RpbmcuIF9fYnVpbHRpbl9hZGRfb3ZlcmZsb3dfcCgpICYg Y28uIHdvcmsgc3VwcG9zZWRseSB3b3JrIG9uCj4gPiBiaXRmaWVsZHMgYXMgd2VsbC4KPiA+IAo+ ID4gQmFoLiBMb29rcyBsaWtlIHRoaXMgc3R1ZmYgZ2VuZXJhdGVzcyB3b3JzZSBjb2RlIHRoYW4g dGhlIG5vcm1hbCB0aGluZzoKPiAKPiBUcnVlLiBNYXliZSBoYXJtbGVzcyB0aG91Z2ggc2luY2Ug d2UgYXJlIG9uIGFuIGluaXQgcGF0aCAoYW5kIHdobwo+IHdvdWxkIHJlaW5pdGlhbGlzZSB0aGVp ciBmYiBvbiBldmVyeSB1cGRhdGUuLi4pIFNvIHRoZSBkaWxlbW1hIGlzIGhhdmluZwo+IGlmIChh ZGRfb3ZlcmZsb3dzKCkpIGJldHRlciB0aGFuIGEgLyogY2hlY2sgaWYgYWRkIG92ZXJmbG93cyAq LyBjb21tZW50LAo+IGFuZCBpcyB0aGF0IHdvcnRoIHdhaXRpbmcgb24gYmV0dGVyIGNvZGUgZ2Vu ZXJhdGlvbi4KClllYWgsIGluIHRoaXMgY2FzZSBkb2Vzbid0IHJlYWxseSBtYXR0ZXIuIEp1c3Qg ZGlzYXBwb2ludGVkIHRoYXQKYSBidWlsdGluIGdpdmVzIHVzIHN1Ym9wdGltYWwgY29kZSBldmVu IHRob3VnaCB0aGUgZG9jdW1lbnRhdGlvbgpnb2VzIG91dCBvZiBpdHMgd2F5IHRvIHBvaW50IG91 dCB0aGF0IGl0IGNhbiB1c2UgZmFuY3kgb3B0aW1pemF0aW9ucy4KCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==