From: Eric Biggers <ebiggers@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Subject: Re: [PATCH] security/integrity: remove unnecessary 'init_keyring' variable
Date: Fri, 21 Sep 2018 11:54:34 -0700 [thread overview]
Message-ID: <20180921185433.GA255965@gmail.com> (raw)
In-Reply-To: <1537555358.3830.345.camel@linux.ibm.com>
On Fri, Sep 21, 2018 at 02:42:38PM -0400, Mimi Zohar wrote:
> On Fri, 2018-09-07 at 13:25 -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The 'init_keyring' variable actually just gave the value of
> > CONFIG_INTEGRITY_TRUSTED_KEYRING. We should check the config option
> > directly instead. No change in behavior; this just simplifies the code.
>
> We try to minimize as much as possible "ifdefs" in C code. This
> change is moving in the wrong direction.
>
> Mimi
So your preferred approach is to store the values of Kconfig options in
variables? That defeats much of the point of having Kconfig options...
- Eric
next prev parent reply other threads:[~2018-09-22 0:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 20:25 [PATCH] security/integrity: remove unnecessary 'init_keyring' variable Eric Biggers
2018-09-21 18:42 ` Mimi Zohar
2018-09-21 18:54 ` Eric Biggers [this message]
2018-09-21 19:02 ` Mimi Zohar
2018-09-21 19:33 ` Eric Biggers
2018-09-21 19:55 ` Mimi Zohar
2018-09-21 20:13 ` Eric Biggers
2018-09-21 20:42 ` Mimi Zohar
2018-10-04 0:16 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921185433.GA255965@gmail.com \
--to=ebiggers@kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.