Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2888 bytes --]

On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote:
> Hi Baolin,
> 
> On 09/21/2018 05:31 AM, Baolin Wang wrote:
> > Hi Jacek and Pavel,
> > 
> > On 11 September 2018 at 10:47, Baolin Wang <baolin.wang@linaro.org> wrote:
> >> This patch adds one new led trigger that LED device can configure
> >> the software or hardware pattern and trigger it.
> >>
> >> Consumers can write 'pattern' file to enable the software pattern
> >> which alters the brightness for the specified duration with one
> >> software timer.
> >>
> >> Moreover consumers can write 'hw_pattern' file to enable the hardware
> >> pattern for some LED controllers which can autonomously control
> >> brightness over time, according to some preprogrammed hardware
> >> patterns.
> >>
> >> Signed-off-by: Raphael Teysseyre <rteysseyre@gmail.com>
> >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> >> ---
> >> Changes from v11:
> >>  - Change -1 means repeat indefinitely.
> >>
> >> Changes from v10:
> >>  - Change 'int' to 'u32' for delta_t field.
> >>
> >> Changes from v9:
> >>  - None.
> >>
> >> Changes from v8:
> >>  - None.
> >>
> >> Changes from v7:
> >>  - Move the SC27XX hardware patterns description into its own ABI file.
> >>
> >> Changes from v6:
> >>  - Improve commit message.
> >>  - Optimize the description of the hw_pattern file.
> >>  - Simplify some logics.
> >>
> >> Changes from v5:
> >>  - Add one 'hw_pattern' file for hardware patterns.
> >>
> >> Changes from v4:
> >>  - Change the repeat file to return the originally written number.
> >>  - Improve comments.
> >>  - Fix some build warnings.
> >>
> >> Changes from v3:
> >>  - Reset pattern number to 0 if user provides incorrect pattern string.
> >>  - Support one pattern.
> >>
> >> Changes from v2:
> >>  - Remove hardware_pattern boolen.
> >>  - Chnage the pattern string format.
> >>
> >> Changes from v1:
> >>  - Use ATTRIBUTE_GROUPS() to define attributes.
> >>  - Introduce hardware_pattern flag to determine if software pattern
> >>  or hardware pattern.
> >>  - Re-implement pattern_trig_store_pattern() function.
> >>  - Remove pattern_get() interface.
> >>  - Improve comments.
> >>  - Other small optimization.
> >> ---
> > 
> > Do you have any comments for the v12 patch set? Thanks.
> 
> We will probably have to remove hw_pattern from ledtrig-pattern
> since we are unable to come up with generic interface for it.
> Unless thread [0] will end up with some brilliant ideas. So far
> we're waiting for Pavel's reply.

I believe same semantics as pattern works well for hw_pattern, and
suggested code changes to make it more robust. I don't really
understand what issues you see there.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]