All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-doc@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH RFC 3/3] Documentation: RCU: Fix rcu_preempt_state reference in stallwarn
Date: Sat, 22 Sep 2018 17:37:25 -0700	[thread overview]
Message-ID: <20180923003725.GK4222@linux.ibm.com> (raw)
In-Reply-To: <20180922234127.94970-3-joel@joelfernandes.org>

On Sat, Sep 22, 2018 at 07:41:27PM -0400, Joel Fernandes (Google) wrote:
> rcu_preempt_state doesn't exist anymore. Update stallwarn documentation
> accordingly.
> 
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Good eyes, queued and pushed with edits, including fixing a grammar
nit in my original.  ;-)

							Thanx, Paul

> ---
>  Documentation/RCU/stallwarn.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt
> index 491043fd976f..b6bc7a2a9961 100644
> --- a/Documentation/RCU/stallwarn.txt
> +++ b/Documentation/RCU/stallwarn.txt
> @@ -176,9 +176,8 @@ causing stalls, and that the stall was affecting RCU-sched.  This message
>  will normally be followed by stack dumps for each CPU.  Please note that
>  PREEMPT_RCU builds can be stalled by tasks as well as by CPUs, and that
>  the tasks will be indicated by PID, for example, "P3421".  It is even
> -possible for a rcu_preempt_state stall to be caused by both CPUs -and-
> -tasks, in which case the offending CPUs and tasks will all be called
> -out in the list.
> +possible for a rcu_state stall to be caused by both CPUs -and- tasks,
> +in which case the offending CPUs and tasks will all be called out in the list.
>  
>  CPU 2's "(3 GPs behind)" indicates that this CPU has not interacted with
>  the RCU core for the past three grace periods.  In contrast, CPU 16's "(0
> -- 
> 2.19.0.444.g18242da7ef-goog
> 


  reply	other threads:[~2018-09-23  0:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22 23:41 [PATCH RFC 1/3] rcu: tree: Remove unused externs Joel Fernandes (Google)
2018-09-22 23:41 ` [PATCH RFC 2/3] rcu: tree: Fix comment about gp_seq_needed Joel Fernandes (Google)
2018-09-23  0:36   ` Paul E. McKenney
2018-09-22 23:41 ` [PATCH RFC 3/3] Documentation: RCU: Fix rcu_preempt_state reference in stallwarn Joel Fernandes (Google)
2018-09-23  0:37   ` Paul E. McKenney [this message]
2018-09-23  0:35 ` [PATCH RFC 1/3] rcu: tree: Remove unused externs Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923003725.GK4222@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=corbet@lwn.net \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.