Re: [PATCH v3 3/4] app/test-eventdev: add Tx adapter support

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Thu, 20 Sep 2018 03:52:34 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com,
>  anoob.joseph@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support
> X-Mailer: git-send-email 2.18.0
> 
> Convert existing Tx service based pipeline to Tx adapter based APIs and
> simplify worker functions.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  app/test-eventdev/test_pipeline_atq.c    | 269 ++++++++++++-----------
>  app/test-eventdev/test_pipeline_common.c | 202 +++++------------
>  app/test-eventdev/test_pipeline_common.h |  62 +++---
>  app/test-eventdev/test_pipeline_queue.c  | 241 ++++++++++----------
>  4 files changed, 363 insertions(+), 411 deletions(-)
> 
> diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c
> index f0b2f9015..01af298f3 100644
> --- a/app/test-eventdev/test_pipeline_atq.c
> +++ b/app/test-eventdev/test_pipeline_atq.c
> @@ -15,7 +15,7 @@ pipeline_atq_nb_event_queues(struct evt_options *opt)
>  	return rte_eth_dev_count_avail();
>  }
> @@ -317,34 +291,36 @@ pipeline_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt)
>  	int nb_ports;
>  	int nb_queues;
>  	uint8_t queue;
> -	struct rte_event_dev_info info;
> -	struct test_pipeline *t = evt_test_priv(test);
> -	uint8_t tx_evqueue_id = 0;
> +	uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0};

Some old compiler throws error with this scheme. Please change to memset.

>  
>  int
> -pipeline_event_tx_service_setup(struct evt_test *test, struct evt_options *opt,
> -		uint8_t tx_queue_id, uint8_t tx_port_id,
> -		const struct rte_event_port_conf p_conf)
> +pipeline_event_tx_adapter_setup(struct evt_options *opt,
> +		struct rte_event_port_conf port_conf)
>  {
> -	int ret;
> -	struct rte_service_spec serv;
> -	struct test_pipeline *t = evt_test_priv(test);
> -	struct tx_service_data *tx = &t->tx_service;
> +	int ret = 0;
> +	uint16_t consm = 0;

Please check the above needs to be initialized to zero?
>  
>  
> @@ -326,25 +316,21 @@ pipeline_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt)
>  	int nb_queues;
>  	int nb_stages = opt->nb_stages;
>  	uint8_t queue;
> -	struct rte_event_dev_info info;
> -	struct test_pipeline *t = evt_test_priv(test);
> -	uint8_t tx_evqueue_id = 0;
> +	uint8_t tx_evport_id = 0;
> +	uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0};

Same as above.

With above changes:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>