From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ncmpc: depends on gcc >= 6
Date: Sun, 23 Sep 2018 16:40:23 +0200 [thread overview]
Message-ID: <20180923164023.6fb3a4ba@windsurf> (raw)
In-Reply-To: <20180923134355.25827-1-fontaine.fabrice@gmail.com>
Hello,
On Sun, 23 Sep 2018 15:43:55 +0200, Fabrice Fontaine wrote:
> Following upstream feedback on unique_ptr issue and the suggested fix
> (https://github.com/MusicPlayerDaemon/ncmpc/pull/29), add a dependency
> on gcc >= 6 and remove patch
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
If I'm correct, unique_ptr was supported before gcc 6.x, right ?
So if that's the case, the issue here is not the unavailability of
unique_ptr before gcc 6, but rather a gcc bug that prevents the
automatic cast from Page* to unique_ptr<Page> from happening.
So the proper course of action would be:
- Report a bug to gcc upstream about this
- Create a BR2_TOOLCHAIN_GCC_HAS_BUG_xyz
- Use that in ncmpc
Indeed, there is a big difference between "the feature does not exist
in gcc" and the "feature existed but was buggy".
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-09-23 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 13:43 [Buildroot] [PATCH 1/1] ncmpc: depends on gcc >= 6 Fabrice Fontaine
2018-09-23 14:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923164023.6fb3a4ba@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.