From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: stable <stable@vger.kernel.org>
Subject: Re: [PATCH stable-4.4] USB: serial: ti_usb_3410_5052: fix array underflow in completion handler
Date: Mon, 24 Sep 2018 09:28:56 +0200 [thread overview]
Message-ID: <20180924072856.GA26056@kroah.com> (raw)
In-Reply-To: <20180924071917.14149-1-johan@kernel.org>
On Mon, Sep 24, 2018 at 09:19:17AM +0200, Johan Hovold wrote:
> commit 5dfdd24eb3d39d815bc952ae98128e967c9bba49 upstream.
>
> Similarly to a recently reported bug in io_ti, a malicious USB device
> could set port_number to a negative value and we would underflow the
> port array in the interrupt completion handler.
>
> As these devices only have one or two ports, fix this by making sure we
> only consider the seventh bit when determining the port number (and
> ignore bits 0xb0 which are typically set to 0x30).
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/serial/ti_usb_3410_5052.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, now queued up.
greg k-h
prev parent reply other threads:[~2018-09-24 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 19:25 FAILED: patch "[PATCH] USB: serial: ti_usb_3410_5052: fix array underflow in" failed to apply to 4.4-stable tree gregkh
2018-09-24 7:19 ` [PATCH stable-4.4] USB: serial: ti_usb_3410_5052: fix array underflow in completion handler Johan Hovold
2018-09-24 7:28 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924072856.GA26056@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.