All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Aaron Williams <zero@zeroaptitude.com>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
	greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: control.c: fixed some coding style issues
Date: Mon, 24 Sep 2018 11:13:21 +0200	[thread overview]
Message-ID: <20180924091321.GG5101@localhost> (raw)
In-Reply-To: <20180920123828.22059-1-zero@zeroaptitude.com>

On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.

Note that this is not something that is mandated by the kernel coding
style, but rather a preference of the authors of checkpatch (and the
check is only enabled when the --strict option is given or when
checkpatch is run on net and staging code).

As the author and maintainer of this particular code, I do not think
this patch should be applied, but Greg may have a different opinion on
this as the overall staging maintainer.

> Signing up for the kernel clean up crew while I learn C

I would strongly suggest learning C *before* moving on to do kernel
work. 

Thanks,
Johan

  reply	other threads:[~2018-09-24  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 12:38 [PATCH] staging: greybus: control.c: fixed some coding style issues Aaron Williams
2018-09-24  9:13 ` Johan Hovold [this message]
2018-09-25 18:47 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180924091321.GG5101@localhost \
    --to=johan@kernel.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zero@zeroaptitude.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.