From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48202 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbeIXQ4Y (ORCPT ); Mon, 24 Sep 2018 12:56:24 -0400 Date: Mon, 24 Sep 2018 12:54:52 +0200 From: Greg Kroah-Hartman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: stable@vger.kernel.org, Michal Simek , Jiri Slaby , Russell King , Hauke Mehrtens , bcm-kernel-feedback-list , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 4.14-4.17 1/2] earlycon: Initialize port->uartclk based on clock-frequency property Message-ID: <20180924105452.GC16476@kroah.com> References: <20180923223446.3773-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180923223446.3773-1-zajec5@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 24, 2018 at 12:34:45AM +0200, Rafał Miłecki wrote: > From: Michal Simek > > commit 814453adea7d081ad8917aa0f32d6a14165a3563 upstream. > > On DT based platforms when current-speed property is present baudrate > is setup. Also port->uartclk is initialized to bogus BASE_BAUD * 16 > value. Drivers like uartps/ns16550 contain logic when baudrate and > uartclk is used for baudrate calculation. > > The patch is reading optional clock-frequency property to replace bogus > BASE_BAUD * 16 calculation to have proper baudrate calculation. > > [-stable comment: commit 31cb9a8575ca ("earlycon: initialise baud field > of earlycon device structure") has changed 8250_early.c behavior which > now tries to setup UART speed. Ignoring clock-frequency results in > wrong value of calculated divisor & malformed early console output.] Thanks for both of these, now queued up. greg k-h