From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Check fb stride against plane max stride Date: Mon, 24 Sep 2018 16:31:56 +0300 Message-ID: <20180924133156.GQ5565@intel.com> References: <20180918140243.12207-1-ville.syrjala@linux.intel.com> <2577088.l8ySodvzlW@dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67F606E2C4 for ; Mon, 24 Sep 2018 13:32:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <2577088.l8ySodvzlW@dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDM6MTc6NDVQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBUdWVzZGF5LCBTZXB0ZW1iZXIgMTgsIDIwMTggNzowMjo0MyBBTSBQ RFQgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IGNvbW1pdCA0ZTBiODNhNTY3ZTIgKCJk cm0vaTkxNTogRXh0cmFjdCBwZXItcGxhdGZvcm0gcGxhbmUtPmNoZWNrKCkKPiA+IGZ1bmN0aW9u cyIpIHJlbW92ZWQgdGhlIHBsYW5lIG1heCBzdHJpZGUgY2hlY2sgZm9yIHNwcml0ZSBwbGFuZXMu Cj4gPiBJIHdhcyBnb2luZyB0byBhZGQgaXQgYmFjayB3aGVuIGludHJvZHVjaW5nIEdUVCByZW1h cHBpbmcgZm9yIHRoZQo+ID4gZGlzcGxheSwgYnV0IGFmdGVyIGZ1cnRoZXIgdGhvdWdodCBpdCBz ZWVtcyBiZXR0ZXIgdG8gcmUtaW50cm9kdWNlCj4gPiBpdCBzZXBhcmF0ZWx5Lgo+ID4gCj4gPiBT byBsZXQncyBhZGQgdGhlIG1heCBzdHJpZGUgY2hlY2sgYmFjay4gQW5kIGxldCdzIGRvIGl0IGlu IGEgbmljZXIKPiA+IGZvcm0gdGhhbiB3aGF0IHdlIGhhZCBiZWZvcmUgYW5kIGRvIGl0IGZvciBh bGwgcGxhbmUgdHlwZXMgKGVhc3kKPiA+IG5vdyB0aGF0IHdlIGhhdmUgdGhlIC0+bWF4X3N0cmlk ZSgpIHBsYW5lIHZmdW5jKS4KPiA+IAo+ID4gT25seSBzcHJpdGUgcGxhbmVzIHJlYWxseSBuZWVk IHRoaXMgZm9yIG5vdyBzaW5jZSBwcmltYXJ5IHBsYW5lcwo+ID4gYXJlIGNhcGFibGUgb2Ygc2Nh bm5pbmcgb3V0IHRoZSBjdXJyZW50IG1heCBmYiBzaXplIHdlIGFsbG93LCBhbmQKPiA+IGN1cnNv cnMgaGF2ZSBtb3JlIHN0cmluZ2VudCBzdHJpZGUgY2hlY2tzIGVsc2V3aGVyZS4KPiA+IAo+ID4g Q2M6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+ID4gRml4 ZXM6IDRlMGI4M2E1NjdlMiAoImRybS9pOTE1OiBFeHRyYWN0IHBlci1wbGF0Zm9ybSBwbGFuZS0+ Y2hlY2soKQo+ID4gZnVuY3Rpb25zIikgU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE0ICsrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Nwcml0ZS5jICB8IDIyICsrKysrKysrKysrKysrKysrKysrKysKPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgaW5kZXggZWIyNTAzN2Q3YjM4Li4xZWI5OWQ1ZWMyMjEKPiA+IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0zMTUxLDYg KzMxNTEsMTAgQEAgaW50IHNrbF9jaGVja19wbGFuZV9zdXJmYWNlKHN0cnVjdCBpbnRlbF9wbGFu ZV9zdGF0ZQo+ID4gKnBsYW5lX3N0YXRlKSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0uc3Ry aWRlID0gaW50ZWxfZmJfcGl0Y2goZmIsIDAsCj4gPiByb3RhdGlvbik7IHBsYW5lX3N0YXRlLT5j b2xvcl9wbGFuZVsxXS5zdHJpZGUgPSBpbnRlbF9mYl9waXRjaChmYiwgMSwKPiA+IHJvdGF0aW9u KTsKPiA+IAo+ID4gKwlyZXQgPSBpbnRlbF9wbGFuZV9jaGVja19zdHJpZGUocGxhbmVfc3RhdGUp Owo+ID4gKwlpZiAocmV0KQo+ID4gKwkJcmV0dXJuIHJldDsKPiA+ICsKPiA+ICAJaWYgKCFwbGFu ZV9zdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAKPiA+IEBAIC0zMjg2 LDEwICszMjkwLDE1IEBAIGludCBpOXh4X2NoZWNrX3BsYW5lX3N1cmZhY2Uoc3RydWN0Cj4gPiBp bnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpIGludCBzcmNfeCA9IHBsYW5lX3N0YXRlLT5i YXNlLnNyYy54MSA+PiAxNjsKPiA+ICAJaW50IHNyY195ID0gcGxhbmVfc3RhdGUtPmJhc2Uuc3Jj LnkxID4+IDE2Owo+ID4gIAl1MzIgb2Zmc2V0Owo+ID4gKwlpbnQgcmV0Owo+ID4gCj4gPiAgCWlu dGVsX2ZpbGxfZmJfZ2d0dF92aWV3KCZwbGFuZV9zdGF0ZS0+dmlldywgZmIsIHJvdGF0aW9uKTsK PiA+ICAJcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLnN0cmlkZSA9IGludGVsX2ZiX3BpdGNo KGZiLCAwLCByb3RhdGlvbik7Cj4gPiAKPiBJcyB0aGVyZSBhIGdvb2QgcmVhc29uIHRvIG5vdCAg aW5saW5lIHRoZSBjb2RlID8KPiAJaWYgKGNvbG9yX3BsYW5lWzBdLnN0cmlkZSA+IHBsYW5lLT5t YXhfc3RyaWRlKCkpCj4gCQlyZXR1cm4gLUVJTlZBTDsKCkNvbnNpc3RlbmN5LiBFYXNpZXIgdG8g anVzdCBjYWxsIGEgc2luZ2xlIGZ1bmN0aW9uIHRoYXQgZG9lcyB0aGluZ3MgaW4gYQpjb25zaXN0 ZW50IGZhc2hpb24gcmF0aGVyIHRoYW4gZHVwbGljYXRpbmcgdGhlIHNhbWUgY2hlY2sgZXZlcnl3 aGVyZS4KQWxzbyBrZWVwcyB0aGUgZGVidWcgcHJpbnQgY29uc2lzdGVudC4KCj4gCj4gCj4gPiAr CXJldCA9IGludGVsX3BsYW5lX2NoZWNrX3N0cmlkZShwbGFuZV9zdGF0ZSk7Cj4gPiArCWlmIChy ZXQpCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwo+ID4gIAlpbnRlbF9hZGRfZmJfb2Zmc2V0cygm c3JjX3gsICZzcmNfeSwgcGxhbmVfc3RhdGUsIDApOwo+ID4gCj4gPiAgCWlmIChJTlRFTF9HRU4o ZGV2X3ByaXYpID49IDQpCj4gPiBAQCAtOTY4NSwxMCArOTY5NCwxNSBAQCBzdGF0aWMgaW50IGlu dGVsX2N1cnNvcl9jaGVja19zdXJmYWNlKHN0cnVjdAo+ID4gaW50ZWxfcGxhbmVfc3RhdGUgKnBs YW5lX3N0YXRlKSB1bnNpZ25lZCBpbnQgcm90YXRpb24gPQo+ID4gcGxhbmVfc3RhdGUtPmJhc2Uu cm90YXRpb247Cj4gPiAgCWludCBzcmNfeCwgc3JjX3k7Cj4gPiAgCXUzMiBvZmZzZXQ7Cj4gPiAr CWludCByZXQ7Cj4gPiAKPiA+ICAJaW50ZWxfZmlsbF9mYl9nZ3R0X3ZpZXcoJnBsYW5lX3N0YXRl LT52aWV3LCBmYiwgcm90YXRpb24pOwo+ID4gIAlwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0u c3RyaWRlID0gaW50ZWxfZmJfcGl0Y2goZmIsIDAsIHJvdGF0aW9uKTsKPiA+IAo+ID4gKwlyZXQg PSBpbnRlbF9wbGFuZV9jaGVja19zdHJpZGUocGxhbmVfc3RhdGUpOwo+ID4gKwlpZiAocmV0KQo+ ID4gKwkJcmV0dXJuIHJldDsKPiA+ICsKPiA+ICAJc3JjX3ggPSBwbGFuZV9zdGF0ZS0+YmFzZS5z cmNfeCA+PiAxNjsKPiA+ICAJc3JjX3kgPSBwbGFuZV9zdGF0ZS0+YmFzZS5zcmNfeSA+PiAxNjsK PiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4g PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGluZGV4IGJmMWMzODcyOGE1OS4u YTM0YzJmMWY5MTU5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAt MjE0MCw2ICsyMTQwLDcgQEAgdW5zaWduZWQgaW50IHNrbF9wbGFuZV9tYXhfc3RyaWRlKHN0cnVj dCBpbnRlbF9wbGFuZQo+ID4gKnBsYW5lLCB1bnNpZ25lZCBpbnQgcm90YXRpb24pOwo+ID4gIGlu dCBza2xfcGxhbmVfY2hlY2soc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4g PiAgCQkgICAgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSk7Cj4gPiAraW50 IGludGVsX3BsYW5lX2NoZWNrX3N0cmlkZShjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUg KnBsYW5lX3N0YXRlKTsKPiA+ICBpbnQgaW50ZWxfcGxhbmVfY2hlY2tfc3JjX2Nvb3JkaW5hdGVz KHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZQo+ID4gKnBsYW5lX3N0YXRlKTsgaW50IGNodl9wbGFu ZV9jaGVja19yb3RhdGlvbihjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUKPiA+ICpwbGFu ZV9zdGF0ZSk7Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9zcHJpdGUuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBpbmRl eCBkNGM4ZTEwZmM5MGIuLjVmZDJmN2JmMzkyNwo+ID4gMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfc3ByaXRlLmMKPiA+IEBAIC0yMzAsNiArMjMwLDI4IEBAIHZvaWQgaW50ZWxfcGlw ZV91cGRhdGVfZW5kKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlCj4gPiAqbmV3X2NydGNfc3RhdGUp ICNlbmRpZgo+ID4gIH0KPiA+IAo+ID4gK2ludCBpbnRlbF9wbGFuZV9jaGVja19zdHJpZGUoY29u c3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiA+ICt7Cj4gPiArCXN0 cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUgPSB0b19pbnRlbF9wbGFuZShwbGFuZV9zdGF0ZS0+YmFz ZS5wbGFuZSk7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxhbmVf c3RhdGUtPmJhc2UuZmI7Cj4gPiArCXVuc2lnbmVkIGludCByb3RhdGlvbiA9IHBsYW5lX3N0YXRl LT5iYXNlLnJvdGF0aW9uOwo+ID4gKwl1MzIgc3RyaWRlLCBtYXhfc3RyaWRlOwo+ID4gKwo+ID4g KwkvKiBGSVhNRSBvdGhlciBjb2xvciBwbGFuZXM/ICovCj4gRG9lc24ndCB0aGUgY29sb3IgcGxh bmUgMCBoYXZlIHRoZSBtYXggc3RyaWRlIGFsd2F5cz8KCkVhY2ggY29sb3IgcGxhbmUgY291bGQg aGF2ZSBhIGRpZmZlcmVudCBtYXhpbXVtLiBEZXBlbmRzIG9uIHRoZSBody4KTm90IHRoYXQgaXQn cyBhY3R1YWxseSBkb2N1bWVudGVkIGZvciB0aGUgc2tsKyBhdXggc3VyZmFjZS4gV291bGQKcHJv YmFibHkgbmVlZCB0byB0ZXN0IHdoYXQgaXMgdGhlIG1heCwgb3IganVzdCBwaWNrIGEgc2Vuc2li bGUKbGltaXQgdGhhdCBzdGlsbCBzZWVtcyB0byB3b3JrLgoKPiAKPiAKPiA+ICsJc3RyaWRlID0g cGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLnN0cmlkZTsKPiA+ICsJbWF4X3N0cmlkZSA9IHBs YW5lLT5tYXhfc3RyaWRlKHBsYW5lLCBmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gPiArCQkJCSAgICAg ICBmYi0+bW9kaWZpZXIsIHJvdGF0aW9uKTsKPiA+ICsKPiA+ICsJaWYgKHN0cmlkZSA+IG1heF9z dHJpZGUpIHsKPiA+ICsJCURSTV9ERUJVR19LTVMoIltGQjolZF0gc3RyaWRlICglZCkgZXhjZWVk cyBbUExBTkU6JWQ6JXNdIG1heCBzdHJpZGUKPiA+ICglZClcbiIsICsJCQkgICAgICBmYi0+YmFz ZS5pZCwgc3RyaWRlLAo+ID4gKwkJCSAgICAgIHBsYW5lLT5iYXNlLmJhc2UuaWQsIHBsYW5lLT5i YXNlLm5hbWUsIG1heF9zdHJpZGUpOwo+IEluY2x1ZGUgdGhlIGNvbG9yIHBsYW5lIG51bWJlciBp biB0aGUgZGVidWcgcHJpbnQ/CgpJIHN1cHBvc2UuCgo+IAo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gPiArCX0KPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ID4gIGludCBpbnRl bF9wbGFuZV9jaGVja19zcmNfY29vcmRpbmF0ZXMoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlCj4g PiAqcGxhbmVfc3RhdGUpIHsKPiA+ICAJY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIg PSBwbGFuZV9zdGF0ZS0+YmFzZS5mYjsKPiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==