From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 1/3] drm/driver: Add defaults for .gem_prime_export/import callbacks Date: Mon, 24 Sep 2018 16:47:16 +0200 Message-ID: <20180924144716.GS11082@phenom.ffwll.local> References: <20180921164230.51838-1-noralf@tronnes.org> <20180921164230.51838-2-noralf@tronnes.org> <20180922101033.GP11082@phenom.ffwll.local> <52e4a0ba-6b3d-4c7a-e7fe-93c977e30c4b@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66F316E24E for ; Mon, 24 Sep 2018 14:47:21 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id k14-v6so16497563edr.13 for ; Mon, 24 Sep 2018 07:47:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <52e4a0ba-6b3d-4c7a-e7fe-93c977e30c4b@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBTZXAgMjIsIDIwMTggYXQgMDU6NTg6MzBQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAyMi4wOS4yMDE4IDEyLjEwLCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDY6NDI6MjhQTSArMDIwMCwgTm9yYWxmIFRyw7hu bmVzIHdyb3RlOgo+ID4gPiBUaGUgbWFqb3JpdHkgb2YgZHJpdmVycyB1c2UgZHJtX2dlbV9wcmlt ZV9leHBvcnQoKSBhbmQKPiA+ID4gZHJtX2dlbV9wcmltZV9pbXBvcnQoKSBmb3IgdGhlc2UgY2Fs bGJhY2tzIHNvIGxldCdzIG1ha2UgdGhlbSB0aGUKPiA+ID4gZGVmYXVsdC4KPiA+ID4gCj4gPiA+ IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4g PiAtLS0KPiA+ID4gICBEb2N1bWVudGF0aW9uL2dwdS90b2RvLnJzdCAgfCAgNyArKysrKysrCj4g PiA+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jIHwgMTAgKysrKysrKystLQo+ID4gPiAg IGluY2x1ZGUvZHJtL2RybV9kcnYuaCAgICAgICB8ICA0ICsrKysKPiA+ID4gICAzIGZpbGVzIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZm IC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QgYi9Eb2N1bWVudGF0aW9uL2dwdS90 b2RvLnJzdAo+ID4gPiBpbmRleCA3N2MyYjNjMjU1NjUuLjM5NzQ4ZTIyZGVhOCAxMDA2NDQKPiA+ ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3QKPiA+ID4gKysrIGIvRG9jdW1lbnRh dGlvbi9ncHUvdG9kby5yc3QKPiA+ID4gQEAgLTIzNCw2ICsyMzQsMTMgQEAgZWZmaWNpZW50Lgo+ ID4gPiAgIENvbnRhY3Q6IERhbmllbCBWZXR0ZXIKPiA+ID4gK0RlZmF1bHRzIGZvciAuZ2VtX3By aW1lX2ltcG9ydCBhbmQgZXhwb3J0Cj4gPiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQo+ID4gPiArCj4gPiA+ICtNb3N0IGRyaXZlcnMgZG9uJ3QgbmVlZCB0byBz ZXQgZHJtX2RyaXZlci0+Z2VtX3ByaW1lX2ltcG9ydCBhbmQKPiA+ID4gKy0+Z2VtX3ByaW1lX2V4 cG9ydCBub3cgdGhhdCBkcm1fZ2VtX3ByaW1lX2ltcG9ydCgpIGFuZCBkcm1fZ2VtX3ByaW1lX2V4 cG9ydCgpCj4gPiA+ICthcmUgdGhlIGRlZmF1bHQuCj4gPiA+ICsKPiA+ID4gICBDb3JlIHJlZmFj dG9yaW5ncwo+ID4gPiAgID09PT09PT09PT09PT09PT09Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMKPiA+ ID4gaW5kZXggM2YwMjA1ZmMwYTFhLi42NzIxNTcxNzQ5ZmYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3ByaW1lLmMKPiA+ID4gQEAgLTU1OSw3ICs1NTksMTAgQEAgc3RhdGljIHN0cnVjdCBkbWFfYnVm ICpleHBvcnRfYW5kX3JlZ2lzdGVyX29iamVjdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4g PiAgIAkJcmV0dXJuIGRtYWJ1ZjsKPiA+ID4gICAJfQo+ID4gPiAtCWRtYWJ1ZiA9IGRldi0+ZHJp dmVyLT5nZW1fcHJpbWVfZXhwb3J0KGRldiwgb2JqLCBmbGFncyk7Cj4gPiA+ICsJaWYgKGRldi0+ ZHJpdmVyLT5nZW1fcHJpbWVfZXhwb3J0KQo+ID4gPiArCQlkbWFidWYgPSBkZXYtPmRyaXZlci0+ Z2VtX3ByaW1lX2V4cG9ydChkZXYsIG9iaiwgZmxhZ3MpOwo+ID4gPiArCWVsc2UKPiA+ID4gKwkJ ZG1hYnVmID0gZHJtX2dlbV9wcmltZV9leHBvcnQoZGV2LCBvYmosIGZsYWdzKTsKPiA+IEhtLCB0 aGlzIG9uZSBoZXJlIG9wZXJhdGVzIG9uIGEgZHJtX2dlbV9vYmplY3QgKHRoZSBkZXYgcGFyYW1l dGVyIGlzIGtpbmRhCj4gPiByZWR1bmRhbnQpLiBJIHRoaW5rIHRoaXMgd291bGQgbG9vayBuZWF0 IGluIHRoZSBjYWxsYmFjayBzdHJ1Y3R1cmUgeW91J3JlCj4gPiBhZGRpbmcgaW4gdGhlIG5leHQg cGF0Y2guIFRoZXJlJ3MgYWxzbyBhIGJ1bmNoIG9mIGdlbSBkcml2ZXJzIG92ZXJ3cml0aW5nCj4g PiB0aGlzIG9uZSwgc28gd291bGQgbWFrZSB5b3VyIGNhbGxiYWNrcyBzdHJ1Y3R1cmUgbW9yZSBn ZW5lcmFsbHkgdXNlZnVsLgo+IAo+IEknbSBub3QgZm9sbG93aW5nIHlvdSBoZXJlLgo+IFdoYXQg SSBkbyBpcyB0byBhZGQgYSBkZWZhdWx0IGZvciB0aGUgMjkgZHJpdmVycyB0aGF0IGhhdmUgdGhp cyBzZXQgdG8KPiBkcm1fZ2VtX3ByaW1lX2V4cG9ydCgpLiBGb3IgdGhlIDggZHJpdmVycyB0aGF0 IGhhdmUgdGhlaXIgb3duIHRoaW5nLCBJCj4gaGF2ZSB0aGUgZnVuY3MtPmV4cG9ydCBjYWxsYmFj ayB0aGF0IHRoZXkgY2FuIHVzZS4KPiAKPiBDb21iaW5lZCB3aXRoIHRoZSBuZXh0IHBhdGNoIGl0 IGxvb2tzIGxpa2UgdGhpczoKPiAKPiDCoMKgwqAgaWYgKGRldi0+ZHJpdmVyLT5nZW1fcHJpbWVf ZXhwb3J0KQo+IMKgwqDCoCDCoMKgwqAgZG1hYnVmID0gZGV2LT5kcml2ZXItPmdlbV9wcmltZV9l eHBvcnQoZGV2LCBvYmosIGZsYWdzKTsKPiDCoMKgwqAgZWxzZSBpZiAob2JqLT5mdW5jcyAmJiBv YmotPmZ1bmNzLT5leHBvcnQpCj4gwqDCoMKgIMKgwqDCoCBkbWFidWYgPSBvYmotPmZ1bmNzLT5l eHBvcnQob2JqLCBmbGFncyk7Cj4gwqDCoMKgIGVsc2UKPiDCoMKgwqAgwqDCoMKgIGRtYWJ1ZiA9 IGRybV9nZW1fcHJpbWVfZXhwb3J0KGRldiwgb2JqLCBmbGFncyk7CgpPaCwgSSBtaXNzZWQgdGhh dCB5b3UncmUgYWRkaW5nIHRoZSBmdW5jcy0+ZXhwb3J0IHRoaW5nIGFscmVhZHksIHRoYXQncwp3 aGF0IEkgd2FudGVkIHRvIHN1Z2dlc3RlZC4KLURhbmllbAoKPiAKPiBOb3JhbGYuCj4gCj4gPiBP dGhlcndpc2UgbGd0bS4KPiA+IC1EYW5pZWwKPiA+IAo+ID4gPiAgIAlpZiAoSVNfRVJSKGRtYWJ1 ZikpIHsKPiA+ID4gICAJCS8qIG5vcm1hbGx5IHRoZSBjcmVhdGVkIGRtYS1idWYgdGFrZXMgb3du ZXJzaGlwIG9mIHRoZSByZWYsCj4gPiA+ICAgCQkgKiBidXQgaWYgdGhhdCBmYWlscyB0aGVuIGRy b3AgdGhlIHJlZgo+ID4gPiBAQCAtNzkyLDcgKzc5NSwxMCBAQCBpbnQgZHJtX2dlbV9wcmltZV9m ZF90b19oYW5kbGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gICAJLyogbmV2ZXIgc2Vl biB0aGlzIG9uZSwgbmVlZCB0byBpbXBvcnQgKi8KPiA+ID4gICAJbXV0ZXhfbG9jaygmZGV2LT5v YmplY3RfbmFtZV9sb2NrKTsKPiA+ID4gLQlvYmogPSBkZXYtPmRyaXZlci0+Z2VtX3ByaW1lX2lt cG9ydChkZXYsIGRtYV9idWYpOwo+ID4gPiArCWlmIChkZXYtPmRyaXZlci0+Z2VtX3ByaW1lX2lt cG9ydCkKPiA+ID4gKwkJb2JqID0gZGV2LT5kcml2ZXItPmdlbV9wcmltZV9pbXBvcnQoZGV2LCBk bWFfYnVmKTsKPiA+ID4gKwllbHNlCj4gPiA+ICsJCW9iaiA9IGRybV9nZW1fcHJpbWVfaW1wb3J0 KGRldiwgZG1hX2J1Zik7Cj4gPiA+ICAgCWlmIChJU19FUlIob2JqKSkgewo+ID4gPiAgIAkJcmV0 ID0gUFRSX0VSUihvYmopOwo+ID4gPiAgIAkJZ290byBvdXRfdW5sb2NrOwo+ID4gPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Rydi5oIGIvaW5jbHVkZS9kcm0vZHJtX2Rydi5oCj4gPiA+ IGluZGV4IDg4MzBlM2RlM2E4Ni4uMTE2MjE0NWY3ZjY4IDEwMDY0NAo+ID4gPiAtLS0gYS9pbmNs dWRlL2RybS9kcm1fZHJ2LmgKPiA+ID4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Rydi5oCj4gPiA+ IEBAIC00NzEsNiArNDcxLDggQEAgc3RydWN0IGRybV9kcml2ZXIgewo+ID4gPiAgIAkgKiBAZ2Vt X3ByaW1lX2V4cG9ydDoKPiA+ID4gICAJICoKPiA+ID4gICAJICogZXhwb3J0IEdFTSAtPiBkbWFi dWYKPiA+ID4gKwkgKgo+ID4gPiArCSAqIFRoaXMgZGVmYXVsdHMgdG8gZHJtX2dlbV9wcmltZV9l eHBvcnQoKSBpZiBub3Qgc2V0Lgo+ID4gPiAgIAkgKi8KPiA+ID4gICAJc3RydWN0IGRtYV9idWYg KiAoKmdlbV9wcmltZV9leHBvcnQpKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiA+ICAgCQkJ CXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqLCBpbnQgZmxhZ3MpOwo+ID4gPiBAQCAtNDc4LDYg KzQ4MCw4IEBAIHN0cnVjdCBkcm1fZHJpdmVyIHsKPiA+ID4gICAJICogQGdlbV9wcmltZV9pbXBv cnQ6Cj4gPiA+ICAgCSAqCj4gPiA+ICAgCSAqIGltcG9ydCBkbWFidWYgLT4gR0VNCj4gPiA+ICsJ ICoKPiA+ID4gKwkgKiBUaGlzIGRlZmF1bHRzIHRvIGRybV9nZW1fcHJpbWVfaW1wb3J0KCkgaWYg bm90IHNldC4KPiA+ID4gICAJICovCj4gPiA+ICAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqICgq Z2VtX3ByaW1lX2ltcG9ydCkoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gICAJCQkJc3Ry dWN0IGRtYV9idWYgKmRtYV9idWYpOwo+ID4gPiAtLSAKPiA+ID4gMi4xNS4xCj4gPiA+IAo+ID4g PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBk cmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK