All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 03/19] cmd: avb: print error message if command fails
Date: Tue, 25 Sep 2018 16:40:07 +0200	[thread overview]
Message-ID: <20180925144023.24555-4-jens.wiklander@linaro.org> (raw)
In-Reply-To: <20180925144023.24555-1-jens.wiklander@linaro.org>

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
---
 cmd/avb.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/cmd/avb.c b/cmd/avb.c
index ca4b26d5d7b3..ff00be4cee38 100644
--- a/cmd/avb.c
+++ b/cmd/avb.c
@@ -35,6 +35,8 @@ int do_avb_init(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	if (avb_ops)
 		return CMD_RET_SUCCESS;
 
+	printf("Failed to initialize avb2\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -65,6 +67,8 @@ int do_avb_read_part(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return CMD_RET_SUCCESS;
 	}
 
+	printf("Failed to read from partition\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -108,6 +112,8 @@ int do_avb_read_part_hex(cmd_tbl_t *cmdtp, int flag, int argc,
 		return CMD_RET_SUCCESS;
 	}
 
+	printf("Failed to read from partition\n");
+
 	free(buffer);
 	return CMD_RET_FAILURE;
 }
@@ -138,6 +144,8 @@ int do_avb_write_part(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return CMD_RET_SUCCESS;
 	}
 
+	printf("Failed to write in partition\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -161,6 +169,9 @@ int do_avb_read_rb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		printf("Rollback index: %llx\n", rb_idx);
 		return CMD_RET_SUCCESS;
 	}
+
+	printf("Failed to read rollback index\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -184,6 +195,8 @@ int do_avb_write_rb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	    AVB_IO_RESULT_OK)
 		return CMD_RET_SUCCESS;
 
+	printf("Failed to write rollback index\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -210,6 +223,8 @@ int do_avb_get_uuid(cmd_tbl_t *cmdtp, int flag,
 		return CMD_RET_SUCCESS;
 	}
 
+	printf("Failed to read UUID\n");
+
 	return CMD_RET_FAILURE;
 }
 
@@ -320,6 +335,8 @@ int do_avb_is_unlocked(cmd_tbl_t *cmdtp, int flag,
 		return CMD_RET_SUCCESS;
 	}
 
+	printf("Can't determine device lock state.\n");
+
 	return CMD_RET_FAILURE;
 }
 
-- 
2.17.1

  parent reply	other threads:[~2018-09-25 14:40 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 14:40 [U-Boot] [PATCH v4 00/19] AVB using OP-TEE Jens Wiklander
2018-09-25 14:40 ` [U-Boot] [PATCH v4 01/19] dm: fdt: scan for devices under /firmware too Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 02/19] cmd: avb read_rb: print rb_idx in hexadecimal Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` Jens Wiklander [this message]
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, 03/19] cmd: avb: print error message if command fails Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 04/19] mmc: rpmb: add mmc_rpmb_route_frames() Jens Wiklander
2018-10-02 11:21   ` Simon Glass
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 05/19] Add UCLASS_TEE for Trusted Execution Environment Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 06/19] dt/bindings: add bindings for optee Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot,v4,06/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 07/19] tee: add OP-TEE driver Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot,v4,07/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 08/19] Documentation: tee uclass and op-tee driver Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 09/19] arm: dt: hikey: Add optee node Jens Wiklander
2018-10-08  1:40   ` [U-Boot] [U-Boot,v4,09/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 10/19] optee: support routing of rpmb data frames to mmc Jens Wiklander
2018-10-02 11:21   ` Simon Glass
2018-10-08  1:40   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 11/19] tee: optee: support AVB trusted application Jens Wiklander
2018-10-02 11:21   ` Simon Glass
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 12/19] sandbox: dt: add sandbox_tee node Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot,v4,12/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 13/19] sandbox: imply CONFIG_TEE (TEE uclass) Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 14/19] tee: add sandbox driver Jens Wiklander
2018-10-02 11:21   ` Simon Glass
2018-10-08  1:41   ` [U-Boot] [U-Boot,v4,14/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 15/19] test: tee: test TEE uclass Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot,v4,15/19] " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 16/19] avb_verify: support using OP-TEE TA AVB Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 17/19] test_avb: Update pymark.buildconfigspec information for the AVB tests Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 18/19] avb_verify: support sandbox configuration Jens Wiklander
2018-10-02 11:21   ` Simon Glass
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-09-25 14:40 ` [U-Boot] [PATCH v4 19/19] Kconfig: sandbox: enable cmd_avb and dependencies Jens Wiklander
2018-10-08  1:41   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-10-02 11:21 ` [U-Boot] [PATCH v4 00/19] AVB using OP-TEE Simon Glass
2018-10-08  7:18   ` Jens Wiklander
2018-10-09  3:40     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925144023.24555-4-jens.wiklander@linaro.org \
    --to=jens.wiklander@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.